From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
Date: Mon, 9 Mar 2015 23:32:56 +0100 [thread overview]
Message-ID: <20150309233256.0b0e0550@free-electrons.com> (raw)
In-Reply-To: <1425917011-16598-1-git-send-email-mike@mikebwilliams.com>
Dear Mike Williams,
On Mon, 9 Mar 2015 12:03:31 -0400, Mike Williams wrote:
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 682cb4c..242bea5 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -164,4 +164,15 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
> $(WPA_SUPPLICANT_INSTALL_DBUS)
> endef
>
> +define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant.service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant.service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant at .service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-nl80211 at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-nl80211 at .service
> + $(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-wired at .service \
> + $(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired at .service
> +endef
Could you please add the symlinks needed to make sure that these
services are started at boot by default?
I know this is not your opinion, but starting services by default is
what we do in basically all packages in Buildroot today, and therefore
something we should continue doing for consistency (and also because
we believe that's a sane default).
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-09 22:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 16:03 [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files Mike Williams
2015-03-09 22:32 ` Thomas Petazzoni [this message]
2015-03-11 13:55 ` Mike Williams
2015-03-11 14:49 ` Thomas Petazzoni
2015-03-18 15:02 ` Mike Williams
2015-03-19 0:41 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309233256.0b0e0550@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox