Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files
Date: Thu, 19 Mar 2015 01:41:49 +0100	[thread overview]
Message-ID: <550A1B4D.7000108@mind.be> (raw)
In-Reply-To: <1425917011-16598-1-git-send-email-mike@mikebwilliams.com>

On 09/03/15 17:03, Mike Williams wrote:
> Signed-off-by: Mike Williams <mike@mikebwilliams.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 As discussed on IRC, adding symlinks to actually start those services is not
such a great idea because
- you probably don't want all of them;
- also other things are needed, like hostapd config and ifup wlan0;
- you may have something to manage these services, like network-manager or networkd.

 Could be good to add that in a comment though.

 Regards,
 Arnout

> ---
>  package/wpa_supplicant/wpa_supplicant.mk | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 682cb4c..242bea5 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -164,4 +164,15 @@ define WPA_SUPPLICANT_INSTALL_TARGET_CMDS
>  	$(WPA_SUPPLICANT_INSTALL_DBUS)
>  endef
>  
> +define WPA_SUPPLICANT_INSTALL_INIT_SYSTEMD
> +	$(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant.service \
> +		$(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant.service
> +	$(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant at .service \
> +		$(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant at .service
> +	$(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-nl80211 at .service \
> +		$(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-nl80211 at .service
> +	$(INSTALL) -m 0644 -D $(@D)/$(WPA_SUPPLICANT_SUBDIR)/systemd/wpa_supplicant-wired at .service \
> +		$(TARGET_DIR)/usr/lib/systemd/system/wpa_supplicant-wired at .service
> +endef
> +
>  $(eval $(generic-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      parent reply	other threads:[~2015-03-19  0:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 16:03 [Buildroot] [PATCH v2] wpa_supplicant: install systemd service files Mike Williams
2015-03-09 22:32 ` Thomas Petazzoni
2015-03-11 13:55   ` Mike Williams
2015-03-11 14:49     ` Thomas Petazzoni
2015-03-18 15:02       ` Mike Williams
2015-03-19  0:41 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550A1B4D.7000108@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox