From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v5 1/3] pkg-cmake: allow to build package in a subdirectory
Date: Tue, 10 Mar 2015 18:56:12 +0100 [thread overview]
Message-ID: <20150310185612.10d9db1d@free-electrons.com> (raw)
In-Reply-To: <CAHXCMMK00FKgwO0iHs3J3kguRsFvMD5hfBgUUJ8dKcdKw0CDSQ@mail.gmail.com>
Dear Samuel Martin,
On Tue, 10 Mar 2015 18:35:21 +0100, Samuel Martin wrote:
> > +ifeq ($$($(2)_SUPPORTS_IN_SOURCE_BUILD), no)
> s/, no/,no/
Actually it should be 'NO' and not 'no'. All other package infra
variables have upper-case values.
I know I suggested the SUPPORTS_IN_SOURCE_BUILD name, but what worries
me a bit is that if one day we want to make the default to build things
out of tree, a variable named <pkg>_SUPPORTS_IN_SOURCE_BUILD would not
make much sense anymore. It would have to be named
<pkg>_REQUIRES_IN_SOURCE_BUILD, set to NO by default in the package
infra, and that can be overridden to YES by those packages that don't
support out of tree build.
So I'm not sure what to do know. Go with <pkg>_SUPPORTS_IN_SOURCE_BUILD
for the moment, and change that when time comes?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-10 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 18:24 [Buildroot] [PATCH v5 1/3] pkg-cmake: allow to build package in a subdirectory Gwenhael Goavec-Merou
2015-03-10 17:35 ` Samuel Martin
2015-03-10 17:56 ` Thomas Petazzoni [this message]
2015-03-10 21:43 ` Arnout Vandecappelle
2015-03-10 21:54 ` Thomas Petazzoni
2015-03-10 18:24 ` [Buildroot] [PATCH v5 2/3] python-cheetah: add host-package support Gwenhael Goavec-Merou
2015-03-10 22:39 ` Arnout Vandecappelle
2015-03-10 22:47 ` Thomas Petazzoni
2015-03-10 23:02 ` Arnout Vandecappelle
2015-03-10 23:07 ` Peter Korsgaard
2015-03-11 8:34 ` Thomas Petazzoni
2015-03-10 18:24 ` [Buildroot] [PATCH v5 3/3] GNURadio: new package Gwenhael Goavec-Merou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310185612.10d9db1d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox