From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] ljlinenoise: refactor with BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
Date: Tue, 17 Mar 2015 21:32:50 +0100 [thread overview]
Message-ID: <20150317213250.6ed620c9@free-electrons.com> (raw)
In-Reply-To: <1426622689-31844-2-git-send-email-francois.perrad@gadz.org>
Dear Francois Perrad,
On Tue, 17 Mar 2015 21:04:48 +0100, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/ljlinenoise/Config.in | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/ljlinenoise/Config.in b/package/ljlinenoise/Config.in
> index 17be1be..ce1a156 100644
> --- a/package/ljlinenoise/Config.in
> +++ b/package/ljlinenoise/Config.in
> @@ -5,7 +5,7 @@ config BR2_PACKAGE_LJLINENOISE
> # ljsyscall is specifically for LuaJIT, not Lua.
> depends on BR2_PACKAGE_LUAJIT
> # ljsyscall is only available for some target architectures
> - depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
> + depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
Are you sure?
BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS is clearly not the same as "BR2_i386
|| BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb". For example,
mips/mipsel are supported in LuaJIT, but not in the current condition
of ljlinenoise.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-17 20:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 20:04 [Buildroot] [PATCH 1/3] luarocks: bump to version 2.2.1 Francois Perrad
2015-03-17 20:04 ` [Buildroot] [PATCH 2/3] ljlinenoise: refactor with BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS Francois Perrad
2015-03-17 20:32 ` Thomas Petazzoni [this message]
2015-03-18 12:29 ` François Perrad
2015-03-17 20:04 ` [Buildroot] [PATCH 3/3] ljsyscall: " Francois Perrad
2015-03-17 21:45 ` Angelo Compagnucci
2015-03-17 22:37 ` Angelo Compagnucci
2015-03-18 12:26 ` François Perrad
2015-03-20 22:43 ` Thomas Petazzoni
2015-03-17 20:32 ` [Buildroot] [PATCH 1/3] luarocks: bump to version 2.2.1 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317213250.6ed620c9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox