Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] ljsyscall: refactor with BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
Date: Fri, 20 Mar 2015 23:43:06 +0100	[thread overview]
Message-ID: <20150320234306.76d71c18@free-electrons.com> (raw)
In-Reply-To: <1426622689-31844-3-git-send-email-francois.perrad@gadz.org>

Dear Francois Perrad,

On Tue, 17 Mar 2015 21:04:49 +0100, Francois Perrad wrote:

> diff --git a/package/ljsyscall/Config.in b/package/ljsyscall/Config.in
> index dcbd521..b9ff04d 100644
> --- a/package/ljsyscall/Config.in
> +++ b/package/ljsyscall/Config.in
> @@ -3,12 +3,12 @@ config BR2_PACKAGE_LJSYSCALL
>  	# ljsyscall is specifically for LuaJIT, not Lua.
>  	depends on BR2_PACKAGE_LUAJIT
>  	# ljsyscall is only available for some target architectures
> -	depends on BR2_i386 || BR2_x86_64 || BR2_powerpc || BR2_arm || BR2_armeb
> +	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

Since you say yourself in the discussion that the set of architectures
supported by ljsyscall is the same as the set of architectures
supported by LuaJIT, then this 'depends on
BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS' is not needed, because this package
already 'depends on BR2_PACKAGE_LUAJIT'.

So if BR2_PACKAGE_LUAJIT has been enabled,
BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS must be true. So adding this
dependency does not make sense.

Can you rework the ljlinenoise and ljsyscall patches to remove this
architecture dependency?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-03-20 22:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 20:04 [Buildroot] [PATCH 1/3] luarocks: bump to version 2.2.1 Francois Perrad
2015-03-17 20:04 ` [Buildroot] [PATCH 2/3] ljlinenoise: refactor with BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS Francois Perrad
2015-03-17 20:32   ` Thomas Petazzoni
2015-03-18 12:29     ` François Perrad
2015-03-17 20:04 ` [Buildroot] [PATCH 3/3] ljsyscall: " Francois Perrad
2015-03-17 21:45   ` Angelo Compagnucci
2015-03-17 22:37     ` Angelo Compagnucci
2015-03-18 12:26       ` François Perrad
2015-03-20 22:43   ` Thomas Petazzoni [this message]
2015-03-17 20:32 ` [Buildroot] [PATCH 1/3] luarocks: bump to version 2.2.1 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320234306.76d71c18@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox