Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/perf: fix build failures with high 'make -j' values
@ 2015-03-18 21:47 Steven Noonan
  2015-03-19  6:56 ` Baruch Siach
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Noonan @ 2015-03-18 21:47 UTC (permalink / raw)
  To: buildroot

The 'perf' Makefile is flaky on some kernel versions. It will still parallelize
the build even with 'make -j1' because it explicitly invokes a sub-make with
the correct flags. But the top-level make is not smart enough to handle large
'-j' values.

Signed-off-by: Steven Noonan <steven@uplinklabs.net>
---
 package/perf/perf.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/perf/perf.mk b/package/perf/perf.mk
index 1fcc258..f6591a6 100644
--- a/package/perf/perf.mk
+++ b/package/perf/perf.mk
@@ -22,6 +22,8 @@ PERF_MAKE_FLAGS = \
 	WERROR=0 \
 	ASCIIDOC=
 
+PERF_MAKE_FLAGS += -j1
+
 # The call to backtrace() function fails for ARC, because for some
 # reason the unwinder from libgcc returns early. Thus the usage of
 # backtrace() should be disabled in perf explicitly: at build time
-- 
2.3.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/perf: fix build failures with high 'make -j' values
  2015-03-18 21:47 [Buildroot] [PATCH] package/perf: fix build failures with high 'make -j' values Steven Noonan
@ 2015-03-19  6:56 ` Baruch Siach
  0 siblings, 0 replies; 2+ messages in thread
From: Baruch Siach @ 2015-03-19  6:56 UTC (permalink / raw)
  To: buildroot

Hi Steven,

On Wed, Mar 18, 2015 at 02:47:24PM -0700, Steven Noonan wrote:
> The 'perf' Makefile is flaky on some kernel versions. It will still parallelize
> the build even with 'make -j1' because it explicitly invokes a sub-make with
> the correct flags. But the top-level make is not smart enough to handle large
> '-j' values.
> 
> Signed-off-by: Steven Noonan <steven@uplinklabs.net>
> ---
>  package/perf/perf.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/perf/perf.mk b/package/perf/perf.mk
> index 1fcc258..f6591a6 100644
> --- a/package/perf/perf.mk
> +++ b/package/perf/perf.mk
> @@ -22,6 +22,8 @@ PERF_MAKE_FLAGS = \
>  	WERROR=0 \
>  	ASCIIDOC=
>  
> +PERF_MAKE_FLAGS += -j1

Please use $(MAKE1).

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-19  6:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-18 21:47 [Buildroot] [PATCH] package/perf: fix build failures with high 'make -j' values Steven Noonan
2015-03-19  6:56 ` Baruch Siach

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox