* [Buildroot] [PATCH v2 2/3] libgtk2: drop libxcomposite mandatory dep
2015-03-30 21:16 [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27 Gustavo Zacarias
@ 2015-03-30 21:16 ` Gustavo Zacarias
2015-03-30 21:22 ` Yann E. MORIN
2015-03-30 21:16 ` [Buildroot] [PATCH v2 3/3] libgtk2: adjust style Gustavo Zacarias
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Gustavo Zacarias @ 2015-03-30 21:16 UTC (permalink / raw)
To: buildroot
It's not selected, not required and duplicate with the autodep.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/libgtk2/libgtk2.mk | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
index 39c629c..c92bbd2 100644
--- a/package/libgtk2/libgtk2.mk
+++ b/package/libgtk2/libgtk2.mk
@@ -82,8 +82,7 @@ LIBGTK2_CONF_OPTS += \
--x-libraries=$(STAGING_DIR)/usr/lib \
--with-gdktarget=x11
LIBGTK2_DEPENDENCIES += \
- xlib_libXcomposite fontconfig xlib_libX11 \
- xlib_libXext xlib_libXrender
+ fontconfig xlib_libX11 xlib_libXext xlib_libXrender
ifeq ($(BR2_PACKAGE_XLIB_LIBXINERAMA),y)
LIBGTK2_CONF_OPTS += --enable-xinerama
--
2.0.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH v2 2/3] libgtk2: drop libxcomposite mandatory dep
2015-03-30 21:16 ` [Buildroot] [PATCH v2 2/3] libgtk2: drop libxcomposite mandatory dep Gustavo Zacarias
@ 2015-03-30 21:22 ` Yann E. MORIN
0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2015-03-30 21:22 UTC (permalink / raw)
To: buildroot
Gustavo, All,
On 2015-03-30 18:16 -0300, Gustavo Zacarias spake thusly:
> It's not selected, not required and duplicate with the autodep.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/libgtk2/libgtk2.mk | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
> index 39c629c..c92bbd2 100644
> --- a/package/libgtk2/libgtk2.mk
> +++ b/package/libgtk2/libgtk2.mk
> @@ -82,8 +82,7 @@ LIBGTK2_CONF_OPTS += \
> --x-libraries=$(STAGING_DIR)/usr/lib \
> --with-gdktarget=x11
> LIBGTK2_DEPENDENCIES += \
> - xlib_libXcomposite fontconfig xlib_libX11 \
> - xlib_libXext xlib_libXrender
> + fontconfig xlib_libX11 xlib_libXext xlib_libXrender
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXINERAMA),y)
> LIBGTK2_CONF_OPTS += --enable-xinerama
> --
> 2.0.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 3/3] libgtk2: adjust style
2015-03-30 21:16 [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27 Gustavo Zacarias
2015-03-30 21:16 ` [Buildroot] [PATCH v2 2/3] libgtk2: drop libxcomposite mandatory dep Gustavo Zacarias
@ 2015-03-30 21:16 ` Gustavo Zacarias
2015-03-30 21:23 ` Yann E. MORIN
2015-03-30 21:29 ` [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27 Yann E. MORIN
2015-03-30 21:37 ` Thomas Petazzoni
3 siblings, 1 reply; 7+ messages in thread
From: Gustavo Zacarias @ 2015-03-30 21:16 UTC (permalink / raw)
To: buildroot
Cleanup indentation and mention why we need AUTORECONF.
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/libgtk2/libgtk2.mk | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
index c92bbd2..fbc0d08 100644
--- a/package/libgtk2/libgtk2.mk
+++ b/package/libgtk2/libgtk2.mk
@@ -11,7 +11,7 @@ LIBGTK2_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk+/$(LIBGTK2_VERSION_MAJ
LIBGTK2_INSTALL_STAGING = YES
LIBGTK2_LICENSE = LGPLv2+
LIBGTK2_LICENSE_FILES = COPYING
-
+# For 0001-reduce-dependencies.patch
LIBGTK2_AUTORECONF = YES
LIBGTK2_CONF_ENV = \
@@ -85,37 +85,37 @@ LIBGTK2_DEPENDENCIES += \
fontconfig xlib_libX11 xlib_libXext xlib_libXrender
ifeq ($(BR2_PACKAGE_XLIB_LIBXINERAMA),y)
- LIBGTK2_CONF_OPTS += --enable-xinerama
- LIBGTK2_DEPENDENCIES += xlib_libXinerama
+LIBGTK2_CONF_OPTS += --enable-xinerama
+LIBGTK2_DEPENDENCIES += xlib_libXinerama
else
- LIBGTK2_CONF_OPTS += --disable-xinerama
+LIBGTK2_CONF_OPTS += --disable-xinerama
endif
ifeq ($(BR2_PACKAGE_XLIB_LIBXI),y)
- LIBGTK2_CONF_OPTS += --with-xinput=yes
- LIBGTK2_DEPENDENCIES += xlib_libXi
+LIBGTK2_CONF_OPTS += --with-xinput=yes
+LIBGTK2_DEPENDENCIES += xlib_libXi
else
- LIBGTK2_CONF_OPTS += --with-xinput=no
+LIBGTK2_CONF_OPTS += --with-xinput=no
endif
ifeq ($(BR2_PACKAGE_XLIB_LIBXRANDR),y)
- LIBGTK2_DEPENDENCIES += xlib_libXrandr
+LIBGTK2_DEPENDENCIES += xlib_libXrandr
endif
ifeq ($(BR2_PACKAGE_XLIB_LIBXCURSOR),y)
- LIBGTK2_DEPENDENCIES += xlib_libXcursor
+LIBGTK2_DEPENDENCIES += xlib_libXcursor
endif
ifeq ($(BR2_PACKAGE_XLIB_LIBXFIXES),y)
- LIBGTK2_DEPENDENCIES += xlib_libXfixes
+LIBGTK2_DEPENDENCIES += xlib_libXfixes
endif
ifeq ($(BR2_PACKAGE_XLIB_LIBXCOMPOSITE),y)
- LIBGTK2_DEPENDENCIES += xlib_libXcomposite
+LIBGTK2_DEPENDENCIES += xlib_libXcomposite
endif
ifeq ($(BR2_PACKAGE_XLIB_LIBXDAMAGE),y)
- LIBGTK2_DEPENDENCIES += xlib_libXdamage
+LIBGTK2_DEPENDENCIES += xlib_libXdamage
endif
ifeq ($(BR2_PACKAGE_LIBPNG),y)
--
2.0.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 3/3] libgtk2: adjust style
2015-03-30 21:16 ` [Buildroot] [PATCH v2 3/3] libgtk2: adjust style Gustavo Zacarias
@ 2015-03-30 21:23 ` Yann E. MORIN
0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2015-03-30 21:23 UTC (permalink / raw)
To: buildroot
Gustavo, All,
On 2015-03-30 18:16 -0300, Gustavo Zacarias spake thusly:
> Cleanup indentation and mention why we need AUTORECONF.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/libgtk2/libgtk2.mk | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
> index c92bbd2..fbc0d08 100644
> --- a/package/libgtk2/libgtk2.mk
> +++ b/package/libgtk2/libgtk2.mk
> @@ -11,7 +11,7 @@ LIBGTK2_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk+/$(LIBGTK2_VERSION_MAJ
> LIBGTK2_INSTALL_STAGING = YES
> LIBGTK2_LICENSE = LGPLv2+
> LIBGTK2_LICENSE_FILES = COPYING
> -
> +# For 0001-reduce-dependencies.patch
> LIBGTK2_AUTORECONF = YES
>
> LIBGTK2_CONF_ENV = \
> @@ -85,37 +85,37 @@ LIBGTK2_DEPENDENCIES += \
> fontconfig xlib_libX11 xlib_libXext xlib_libXrender
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXINERAMA),y)
> - LIBGTK2_CONF_OPTS += --enable-xinerama
> - LIBGTK2_DEPENDENCIES += xlib_libXinerama
> +LIBGTK2_CONF_OPTS += --enable-xinerama
> +LIBGTK2_DEPENDENCIES += xlib_libXinerama
> else
> - LIBGTK2_CONF_OPTS += --disable-xinerama
> +LIBGTK2_CONF_OPTS += --disable-xinerama
> endif
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXI),y)
> - LIBGTK2_CONF_OPTS += --with-xinput=yes
> - LIBGTK2_DEPENDENCIES += xlib_libXi
> +LIBGTK2_CONF_OPTS += --with-xinput=yes
> +LIBGTK2_DEPENDENCIES += xlib_libXi
> else
> - LIBGTK2_CONF_OPTS += --with-xinput=no
> +LIBGTK2_CONF_OPTS += --with-xinput=no
> endif
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXRANDR),y)
> - LIBGTK2_DEPENDENCIES += xlib_libXrandr
> +LIBGTK2_DEPENDENCIES += xlib_libXrandr
> endif
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXCURSOR),y)
> - LIBGTK2_DEPENDENCIES += xlib_libXcursor
> +LIBGTK2_DEPENDENCIES += xlib_libXcursor
> endif
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXFIXES),y)
> - LIBGTK2_DEPENDENCIES += xlib_libXfixes
> +LIBGTK2_DEPENDENCIES += xlib_libXfixes
> endif
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXCOMPOSITE),y)
> - LIBGTK2_DEPENDENCIES += xlib_libXcomposite
> +LIBGTK2_DEPENDENCIES += xlib_libXcomposite
> endif
>
> ifeq ($(BR2_PACKAGE_XLIB_LIBXDAMAGE),y)
> - LIBGTK2_DEPENDENCIES += xlib_libXdamage
> +LIBGTK2_DEPENDENCIES += xlib_libXdamage
> endif
>
> ifeq ($(BR2_PACKAGE_LIBPNG),y)
> --
> 2.0.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27
2015-03-30 21:16 [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27 Gustavo Zacarias
2015-03-30 21:16 ` [Buildroot] [PATCH v2 2/3] libgtk2: drop libxcomposite mandatory dep Gustavo Zacarias
2015-03-30 21:16 ` [Buildroot] [PATCH v2 3/3] libgtk2: adjust style Gustavo Zacarias
@ 2015-03-30 21:29 ` Yann E. MORIN
2015-03-30 21:37 ` Thomas Petazzoni
3 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2015-03-30 21:29 UTC (permalink / raw)
To: buildroot
Gustavo, All,
On 2015-03-30 18:16 -0300, Gustavo Zacarias spake thusly:
> Also add hash file.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Manually downloaded and checked the hash file.
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/libgtk2/libgtk2.hash | 2 ++
> package/libgtk2/libgtk2.mk | 3 +--
> 2 files changed, 3 insertions(+), 2 deletions(-)
> create mode 100644 package/libgtk2/libgtk2.hash
>
> diff --git a/package/libgtk2/libgtk2.hash b/package/libgtk2/libgtk2.hash
> new file mode 100644
> index 0000000..c2189f8
> --- /dev/null
> +++ b/package/libgtk2/libgtk2.hash
> @@ -0,0 +1,2 @@
> +# From http://ftp.gnome.org/pub/gnome/sources/gtk+/2.24/gtk+-2.24.27.sha256sum
> +sha256 20cb10cae43999732a9af2e9aac4d1adebf2a9c2e1ba147050976abca5cd24f4 gtk+-2.24.27.tar.xz
> diff --git a/package/libgtk2/libgtk2.mk b/package/libgtk2/libgtk2.mk
> index f52dfaf..39c629c 100644
> --- a/package/libgtk2/libgtk2.mk
> +++ b/package/libgtk2/libgtk2.mk
> @@ -5,8 +5,7 @@
> ################################################################################
>
> LIBGTK2_VERSION_MAJOR = 2.24
> -LIBGTK2_VERSION = $(LIBGTK2_VERSION_MAJOR).18
> -
> +LIBGTK2_VERSION = $(LIBGTK2_VERSION_MAJOR).27
> LIBGTK2_SOURCE = gtk+-$(LIBGTK2_VERSION).tar.xz
> LIBGTK2_SITE = http://ftp.gnome.org/pub/gnome/sources/gtk+/$(LIBGTK2_VERSION_MAJOR)
> LIBGTK2_INSTALL_STAGING = YES
> --
> 2.0.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150330/5a470665/attachment.asc>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27
2015-03-30 21:16 [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27 Gustavo Zacarias
` (2 preceding siblings ...)
2015-03-30 21:29 ` [Buildroot] [PATCH v2 1/3] libgtk2: bump to version 2.24.27 Yann E. MORIN
@ 2015-03-30 21:37 ` Thomas Petazzoni
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2015-03-30 21:37 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Mon, 30 Mar 2015 18:16:28 -0300, Gustavo Zacarias wrote:
> Also add hash file.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/libgtk2/libgtk2.hash | 2 ++
> package/libgtk2/libgtk2.mk | 3 +--
> 2 files changed, 3 insertions(+), 2 deletions(-)
> create mode 100644 package/libgtk2/libgtk2.hash
All three patches applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread