From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] miraclecast: new package
Date: Fri, 3 Apr 2015 08:00:43 +0300 [thread overview]
Message-ID: <20150403050043.GM17056@tarshish> (raw)
In-Reply-To: <1428030634-23928-1-git-send-email-ryanbarnett3@gmail.com>
Hi Ryan,
On Thu, Apr 02, 2015 at 10:10:34PM -0500, Ryan Barnett wrote:
> diff --git a/package/systemd/systemd.mk b/package/systemd/systemd.mk
> index 98bda02..a94ce04 100644
> --- a/package/systemd/systemd.mk
> +++ b/package/systemd/systemd.mk
> @@ -77,6 +77,11 @@ else
> SYSTEMD_CONF_OPTS += --disable-seccomp
> endif
>
> +ifeq ($(BR2_PACKAGE_MIRACLECAST),y)
> +# Must enable kdbus in order to get sd-events.h in staging
> +SYSTEMD_CONF_OPTS += --enable-kdbus
> +endif
This looks somewhat unusual. And besides, kdbus should be a useful feature on
its own right. So why not add a BR2_PACKAGE_SYSTEMD_KDBUS option, and have
BR2_PACKAGE_MIRACLECAST select that? Setting the right kernel dependency for
BR2_PACKAGE_SYSTEMD_KDBUS would be an interesting question, though.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-04-03 5:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 3:10 [Buildroot] [PATCH 1/1] miraclecast: new package Ryan Barnett
2015-04-03 5:00 ` Baruch Siach [this message]
2015-04-03 12:39 ` Ryan Barnett
2015-04-03 17:47 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150403050043.GM17056@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox