Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] lirc-tools: fix build with host python3
Date: Sun, 5 Apr 2015 18:34:54 +0300	[thread overview]
Message-ID: <20150405153454.GA2183@tarshish> (raw)
In-Reply-To: <20150405172857.7b773e82@free-electrons.com>

Hi Thomas,

On Sun, Apr 05, 2015 at 05:28:57PM +0200, Thomas Petazzoni wrote:
> On Sun,  5 Apr 2015 18:26:06 +0300, Baruch Siach wrote:
> > Add an upstream patch making make_rel_symlink.py python3 compatible and making
> > python3 mandatory. Update lirc-tools dependencies accordingly.
> > 
> > Fixes:
> > http://autobuild.buildroot.net/results/6c6/6c6e014a751650c16d25dfd3d673bd3199c72b2e/
> > http://autobuild.buildroot.net/results/857/85724dfd014cec5a80dd18a635826daa2edc1417/
> > http://autobuild.buildroot.net/results/a74/a74563f700a47065ffd1ba42c83c2d7722bacd89/
> > 
> > and many others.
> > 
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> 
> Is host-python3 actually mandatory? When BR2_PACKAGE_PYTHON3 is not
> enabled, it can perfectly fine use the host python?
> 
> So what about:
> 
>  * Using #!/usr/bin/env python in the script, and make the script both
>    python 2 and python 3 compliant.
> 
>  * Use $(if $(BR2_PACKAGE_PYTHON3),host-python3) in the dependencies ?

Are both needed? If the script is compliant with both python2 and python3, 
then we can rely on the host provided python in case host-python3 has not been 
built by the time lirc-tools builds, isn't it?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-04-05 15:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-05 15:26 [Buildroot] [PATCH] lirc-tools: fix build with host python3 Baruch Siach
2015-04-05 15:28 ` Thomas Petazzoni
2015-04-05 15:34   ` Baruch Siach [this message]
2015-04-05 15:38     ` Thomas Petazzoni
  -- strict thread matches above, loose matches on Subject: below --
2015-04-06  4:45 Baruch Siach
2015-04-06  8:58 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150405153454.GA2183@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox