Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] Target to create missing hashes.
@ 2015-04-05 22:58 Johan Sagaert
  2015-04-06  8:53 ` Thomas Petazzoni
  2015-04-06  8:56 ` Yann E. MORIN
  0 siblings, 2 replies; 4+ messages in thread
From: Johan Sagaert @ 2015-04-05 22:58 UTC (permalink / raw)
  To: buildroot

Dear Yann ,

Would be nice to have a convenience make target to create missing hashes.
(Comes in handy for custom packages not available in upstream buildroot, 
or when bumping versions before
posting the patches to the mailing list.)

  make  <pkg>-sha256_hash

Maybe the missing hash warnings should also be redirected to a file 
.missing_hashes, they mostly go unnoticed otherwise while building.

Best Regards , Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] Target to create missing hashes.
  2015-04-05 22:58 [Buildroot] Target to create missing hashes Johan Sagaert
@ 2015-04-06  8:53 ` Thomas Petazzoni
  2015-04-06  8:56 ` Yann E. MORIN
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-04-06  8:53 UTC (permalink / raw)
  To: buildroot

Dear Johan Sagaert,

On Mon, 06 Apr 2015 00:58:16 +0200, Johan Sagaert wrote:

> Would be nice to have a convenience make target to create missing hashes.
> (Comes in handy for custom packages not available in upstream buildroot, 
> or when bumping versions before
> posting the patches to the mailing list.)
> 
>   make  <pkg>-sha256_hash

Not sure, because we want to encourage people to look for hashes on the
upstream web site rather than generating them locally. Generating
hashes locally should be a last resort.

> Maybe the missing hash warnings should also be redirected to a file 
> .missing_hashes, they mostly go unnoticed otherwise while building.

There is a series from Yann that makes such warnings become hard
errors. However, we had to disable it because it was breaking custom
external toolchain. Another series from Yann is fixing this, but is
pending review. But clearly, this is where we want to go.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] Target to create missing hashes.
  2015-04-05 22:58 [Buildroot] Target to create missing hashes Johan Sagaert
  2015-04-06  8:53 ` Thomas Petazzoni
@ 2015-04-06  8:56 ` Yann E. MORIN
  2015-04-06  9:53   ` Johan Sagaert
  1 sibling, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2015-04-06  8:56 UTC (permalink / raw)
  To: buildroot

Johan, All,

On 2015-04-06 00:58 +0200, Johan Sagaert spake thusly:
> Would be nice to have a convenience make target to create missing hashes.
> (Comes in handy for custom packages not available in upstream buildroot, or
> when bumping versions before posting the patches to the mailing list.)
> 
>  make  <pkg>-sha256_hash

Well, we do not want the hashes to be automatically created, because we
want them to come from upstream if possible, and only if upstream does
not provide hashes do we locally compute them.

So, we can't offer an automatic way to create hashes. It has to be a
manual process.

> Maybe the missing hash warnings should also be redirected to a file
> .missing_hashes, they mostly go unnoticed otherwise while building.

Well, I have a series that makes missing hashes a hard error (when the
.hash file exists), so that will be caught fairly easily! ;-) And a
missing .hash file would become a warning for now, with the ultimate
goal of making it a hard error in the future (because we do not have
enough packages with a .hash file for now).

There is the idea floatign around of creating a check-package (or
check-patch) script that could be used to validate a new package, and
checking a .hash file exists could be part of that script.

Any taker? ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] Target to create missing hashes.
  2015-04-06  8:56 ` Yann E. MORIN
@ 2015-04-06  9:53   ` Johan Sagaert
  0 siblings, 0 replies; 4+ messages in thread
From: Johan Sagaert @ 2015-04-06  9:53 UTC (permalink / raw)
  To: buildroot

Yann E. MORIN schreef op 6/04/2015 om 10:56:
> Johan, All,
>
> On 2015-04-06 00:58 +0200, Johan Sagaert spake thusly:
>> Would be nice to have a convenience make target to create missing hashes.
>> (Comes in handy for custom packages not available in upstream buildroot, or
>> when bumping versions before posting the patches to the mailing list.)
>>
>>   make  <pkg>-sha256_hash
> Well, we do not want the hashes to be automatically created, because we
> want them to come from upstream if possible, and only if upstream does
> not provide hashes do we locally compute them.
>
> So, we can't offer an automatic way to create hashes. It has to be a
> manual process.
I did not mean 'automatic'  in the sense that buildroot would create the 
missing hashes
whenever its finds one during the build, but only as an aid to manually 
add / update a hash after
  for example adding a new package, or bumping to a newer version.
>> Maybe the missing hash warnings should also be redirected to a file
>> .missing_hashes, they mostly go unnoticed otherwise while building.
> Well, I have a series that makes missing hashes a hard error (when the
> .hash file exists), so that will be caught fairly easily! ;-) And a
> missing .hash file would become a warning for now, with the ultimate
> goal of making it a hard error in the future (because we do not have
> enough packages with a .hash file for now).
>
> There is the idea floatign around of creating a check-package (or
> check-patch) script that could be used to validate a new package, and
> checking a .hash file exists could be part of that script.
>
> Any taker? ;-)
>
> Regards,
> Yann E. MORIN.
>
Best Regards Johan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-04-06  9:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-05 22:58 [Buildroot] Target to create missing hashes Johan Sagaert
2015-04-06  8:53 ` Thomas Petazzoni
2015-04-06  8:56 ` Yann E. MORIN
2015-04-06  9:53   ` Johan Sagaert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox