From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: remove redundant ifdef V
Date: Tue, 7 Apr 2015 07:19:11 +0300 [thread overview]
Message-ID: <20150407041911.GB2241@tarshish> (raw)
In-Reply-To: <1428379696-16079-1-git-send-email-yamada.masahiro@socionext.com>
Hi Masahiro Yamada,
On Tue, Apr 07, 2015 at 01:08:16PM +0900, Masahiro Yamada wrote:
> If "V" is not defined, "$(origin V)" returns "undefined".
> "ifdev V" is redundant.
V is not defined in code but ...
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> Makefile | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index d6426b3..9db52a8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -184,10 +184,8 @@ endif
>
> # To put more focus on warnings, be less verbose as default
> # Use 'make V=1' to see the full commands
... as this comment says, you can define V manually on the make invocation
command line. That is its intended use.
> -ifdef V
> - ifeq ("$(origin V)", "command line")
> - KBUILD_VERBOSE = $(V)
> - endif
> +ifeq ("$(origin V)", "command line")
> + KBUILD_VERBOSE = $(V)
> endif
> ifndef KBUILD_VERBOSE
> KBUILD_VERBOSE = 0
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-04-07 4:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 4:08 [Buildroot] [PATCH] Makefile: remove redundant ifdef V Masahiro Yamada
2015-04-07 4:19 ` Baruch Siach [this message]
2015-04-07 4:36 ` Masahiro Yamada
2015-04-07 4:50 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150407041911.GB2241@tarshish \
--to=baruch@tkos.co.il \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox