[Buildroot] [PATCH] Makefile: remove redundant ifdef V

[Baruch Siach <baruch@tkos.co.il>]

Hi Masahiro Yamada,
On Tue, Apr 07, 2015 at 01:36:39PM +0900, Masahiro Yamada wrote:
> 2015-04-07 13:19 GMT+09:00 Baruch Siach <baruch@tkos.co.il>:
> > On Tue, Apr 07, 2015 at 01:08:16PM +0900, Masahiro Yamada wrote:
> >> If "V" is not defined, "$(origin V)" returns "undefined".
> >> "ifdev V" is redundant.
> >
> > V is not defined in code but ...
> 
> Right.
> 
> V=1 is supposed to be passed from the command line,
> like Linux, U-Boot, barebox, busybox and other projects that use Kbuild.
> 
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> >> ---
> >>
> >>  Makefile | 6 ++----
> >>  1 file changed, 2 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/Makefile b/Makefile
> >> index d6426b3..9db52a8 100644
> >> --- a/Makefile
> >> +++ b/Makefile
> >> @@ -184,10 +184,8 @@ endif
> >>
> >>  # To put more focus on warnings, be less verbose as default
> >>  # Use 'make V=1' to see the full commands
> >
> > ... as this comment says, you can define V manually on the make invocation
> > command line. That is its intended use.
> 
> Right. I do understand this.
> 
> I am afraid you are misunderstanding my patch.
> 
> 
> I recommend you to read the git-log of
> commit b8b0618cf6fab3bd5b1da8c72f4b29847d81ac42  of Linux Kernel.

Thanks for the pointer. This is clearer now. Please update the commit log of 
your patch to include a more verbose explanation, like the kernel commit log 
you pointed.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -