[Buildroot] [PATCH v5 1/1] tovid: new package

[Buildroot] [PATCH v5 1/1] tovid: new package

[Steve Kenton]

The tovid suite, also known simply as tovid, is a collection of shell
and Python scripts for creating DVDs and (S)VCDs. It is pronounced
"to vid" (because it converts to video disc formats).

Signed-off-by: Steve Kenton <skenton@ou.edu>
---
V5 change to depends on python or python3

V4 added comments and fixed nits, changed to:
   TOVID_SETUP_TYPE = distutils
   $(eval $(python-package))

V3 delete hash file since download is from SVN

 package/Config.in                |  1 +
 package/tovid/0001-manpage.patch | 25 +++++++++++++++++++++++++
 package/tovid/Config.in          | 35 +++++++++++++++++++++++++++++++++++
 package/tovid/tovid.mk           | 14 ++++++++++++++
 4 files changed, 75 insertions(+)
 create mode 100644 package/tovid/0001-manpage.patch
 create mode 100644 package/tovid/Config.in
 create mode 100644 package/tovid/tovid.mk

diff --git a/package/Config.in b/package/Config.in
index 93fde92..a9d816e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
 	source "package/tidsp-binaries/Config.in"
+	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
 	source "package/twolame/Config.in"
 	source "package/upmpdcli/Config.in"
diff --git a/package/tovid/0001-manpage.patch b/package/tovid/0001-manpage.patch
new file mode 100644
index 0000000..21669c9
--- /dev/null
+++ b/package/tovid/0001-manpage.patch
@@ -0,0 +1,25 @@
+setup.py: disable man page to kill txt2tags SVN checkout dependency
+
+Signed-off-by: Steve Kenton <skenton@ou.edu>
+
++diff -pruN tovid-3534.ori/setup.py tovid-3534/setup.py
+--- tovid-3534.ori/setup.py	2013-04-14 09:52:08.000000000 -0500
++++ tovid-3534/setup.py	2015-03-21 09:39:14.880173176 -0500
+@@ -186,7 +186,7 @@ class BuildTovidInit (Command):
+ 
+ # Build tovid-init with regular 'build' command
+ build.sub_commands.append(('build_tovid_init', None))
+-build.sub_commands.append(('build_docs', None))
++#build.sub_commands.append(('build_docs', None))
+ 
+ # The actual setup
+ setup(
+@@ -244,8 +244,6 @@ setup(
+             'src/tovid.ini',
+         ]),
+         # Manual page
+-        ('share/man/man1',
+-         ['docs/man/tovid.1']),
+         # Desktop shortcut
+         ('share/applications',
+          ['tovidgui.desktop',
diff --git a/package/tovid/Config.in b/package/tovid/Config.in
new file mode 100644
index 0000000..532daa2
--- /dev/null
+++ b/package/tovid/Config.in
@@ -0,0 +1,35 @@
+config BR2_PACKAGE_TOVID
+	bool "tovid"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_INET_IPV6 # ffmpeg
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_USE_WCHAR
+	depends on BR2_LARGEFILE
+	depends on BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3
+	# The below dependencies are runtime dependencies only
+	select BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # procps_ng
+	select BR2_PACKAGE_DVDAUTHOR
+	select BR2_PACKAGE_DVDRW_TOOLS
+	select BR2_PACKAGE_FFMPEG
+	select BR2_PACKAGE_IMAGEMAGICK
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_MJPEGTOOLS
+	select BR2_PACKAGE_MPLAYER
+	select BR2_PACKAGE_PROCPS_NG # pgrep and pkill
+	select BR2_PACKAGE_SOX
+	help
+	  The tovid suite, also known simply as tovid, is a collection of shell 
+	  and Python scripts for creating DVDs and (S)VCDs. It is pronounced 
+	  "to vid" (because it converts to video disc formats). 
+
+	  http://tovid.wikia.com/wiki/Installing_tovid
+
+comment "tovid needs a toolchain w/ threads, ipv6, C++, wchar, largefile"
+	depends on BR2_USE_MMU
+	depends on !BR2_TOOLCHAIN_HAS_THREADS \
+		|| !BR2_INET_IPV6 || !BR2_INSTALL_LIBSTDCPP \
+		|| !BR2_USE_WCHAR || !BR2_LARGEFILE
+
+comment "tovid depends on python or python3"
+	depends on !BR2_PACKAGE_PYTHON && !BR2_PACKAGE_PYTHON3
diff --git a/package/tovid/tovid.mk b/package/tovid/tovid.mk
new file mode 100644
index 0000000..790044c
--- /dev/null
+++ b/package/tovid/tovid.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# tovid
+#
+################################################################################
+
+TOVID_SITE = http://tovid.googlecode.com/svn/trunk/tovid
+TOVID_SITE_METHOD = svn
+TOVID_VERSION = 3534
+TOVID_LICENSE = GPLv2
+TOVID_LICENSE_FILES = COPYING
+TOVID_SETUP_TYPE = distutils
+
+$(eval $(python-package))
-- 
2.1.0

[Buildroot] [PATCH v5 1/1] tovid: new package

[Thomas Petazzoni]

Dear Steve Kenton,

On Sun, 22 Mar 2015 10:35:13 -0500, Steve Kenton wrote:
> The tovid suite, also known simply as tovid, is a collection of shell
> and Python scripts for creating DVDs and (S)VCDs. It is pronounced
> "to vid" (because it converts to video disc formats).
> 
> Signed-off-by: Steve Kenton <skenton@ou.edu>

Applied, with some minor changes:

    [Thomas:
      - remove largefile dependency
      - properly propagate mplayer and ffmpeg dependencies.
      - fix license: it's GPLv2+, not GPLv2.]

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v5 1/1] tovid: new package

[Steve Kenton]

<snip>
On 04/05/2015 04:45 AM, Thomas Petazzoni wrote:
> 
> Applied, with some minor changes:
> 
>     Thomas
It looks like Tovid has finished moving from SVN to github.

Github Green "Latest release" button for Tovid shows:

https://github.com/tovid-suite/tovid/releases/download/v0.35.0/tovid-0.35.0.tar.gz

I could not find any indication of a hash file - does github offer them anywhere
that I'm missing? Computed the one below locally after downloading. Is sha256sum
still preferred hash for local computation?

$ sha256sum tovid-0.35.0.tar.gz
06f7cb00b213bbe83d72f4f2076b675a662697034e1d2cdc2dce987e35c827bc  tovid-0.35.0.tar.gz

Are uploaded tarballs still preferred for projects on github?

Not quite sure how to submit the change over.


Steve Kenton

[Buildroot] [PATCH v5 1/1] tovid: new package

[Yann E. MORIN]

Steve, All,

On 2015-04-08 17:15 -0500, Steve Kenton spake thusly:
> <snip>
> On 04/05/2015 04:45 AM, Thomas Petazzoni wrote:
> > 
> > Applied, with some minor changes:
> > 
> >     Thomas
> It looks like Tovid has finished moving from SVN to github.

Great! :-)

> Github Green "Latest release" button for Tovid shows:
> 
> https://github.com/tovid-suite/tovid/releases/download/v0.35.0/tovid-0.35.0.tar.gz
> 
> I could not find any indication of a hash file - does github offer them anywhere
> that I'm missing?

No, GitHub does not provide hashes of tarballs.

> Computed the one below locally after downloading. Is sha256sum
> still preferred hash for local computation?

Yes, computing it is fine; sha256 is good.

> $ sha256sum tovid-0.35.0.tar.gz
> 06f7cb00b213bbe83d72f4f2076b675a662697034e1d2cdc2dce987e35c827bc  tovid-0.35.0.tar.gz

So, you'd add this hash as thus in the .hash file:

    # Locally computed:
    sha256  06f7cb00b213bbe83d72f4f2076b675a662697034e1d2cdc2dce987e35c827bc  tovid-0.35.0.tar.gz

> Are uploaded tarballs still preferred for projects on github?

Yes. See:

    http://buildroot.net/downloads/manual/manual.html#github-download-url

Quoting:

    If there is a release tarball uploaded by the maintainer, we prefer
    to use that [...]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'