From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] uboot: deprecate BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR
Date: Sat, 18 Apr 2015 15:54:41 +0200 [thread overview]
Message-ID: <20150418155441.76edbfe1@free-electrons.com> (raw)
In-Reply-To: <1429302375-12275-2-git-send-email-fhunleth@troodon-software.com>
Dear Frank Hunleth,
On Fri, 17 Apr 2015 16:26:14 -0400, Frank Hunleth wrote:
> Users should use BR2_TARGET_UBOOT_PATCHES instead.
>
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
Except that your implementation of BR2_TARGET_UBOOT_PATCHES does not
allow the same thing as BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR.
BR2_TARGET_UBOOT_PATCHES, as per your current implementation, can only
be used for remote patches: they will be downloaded from the given URL
if a full URL is given, or from $(UBOOT_SITE) if just a file name is
given.
See how things are done in linux/linux.mk for an example that allows
both remote and local patches. Though I'm not necessarily too happy to
see the linux/linux.mk being duplicated...
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-18 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 20:26 [Buildroot] [PATCH 1/3] uboot: add support for patch files and URLs Frank Hunleth
2015-04-17 20:26 ` [Buildroot] [PATCH 2/3] uboot: deprecate BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR Frank Hunleth
2015-04-18 13:54 ` Thomas Petazzoni [this message]
2015-04-17 20:26 ` [Buildroot] [PATCH 3/3] altera: update use of BR2_TARGET_UBOOT_PATCH_DIR Frank Hunleth
2015-04-18 13:55 ` Thomas Petazzoni
2015-04-18 14:28 ` Frank Hunleth
2015-04-18 15:48 ` Thomas Petazzoni
2015-04-18 0:40 ` [Buildroot] [PATCH 1/3] uboot: add support for patch files and URLs Vivien Didelot
2015-04-18 13:53 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418155441.76edbfe1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox