Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] uboot: add support for patch files and URLs
Date: Fri, 17 Apr 2015 20:40:41 -0400 (EDT)	[thread overview]
Message-ID: <877797848.435510.1429317641487.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <1429302375-12275-1-git-send-email-fhunleth@troodon-software.com>

Hi all,

Sorry for showing up a bit late on this thread.

> +config BR2_TARGET_UBOOT_PATCHES
> +	string "custom patches"
[...]
> +UBOOT_PATCH += $(call qstrip,$(BR2_TARGET_UBOOT_PATCHES))
> +
>  define UBOOT_CONFIGURE_CMDS

While we are adding new U-Boot related symbols, I think it would be nice
to respect the project naming convention, which is described in the
"Names and Spelling" section [1] of the project README file.

So, I'd suggest these symbols to be named BR2_TARGET_U_BOOT_PATCHES and
U_BOOT_PATCH in respect to the official project name.

[1] http://git.denx.de/?p=u-boot.git;a=blob;f=README;h=9b748ccc34120b3c10dd8c33d84269bff6853b1b;hb=HEAD#l93

Best Regards,
-v

  parent reply	other threads:[~2015-04-18  0:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-17 20:26 [Buildroot] [PATCH 1/3] uboot: add support for patch files and URLs Frank Hunleth
2015-04-17 20:26 ` [Buildroot] [PATCH 2/3] uboot: deprecate BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR Frank Hunleth
2015-04-18 13:54   ` Thomas Petazzoni
2015-04-17 20:26 ` [Buildroot] [PATCH 3/3] altera: update use of BR2_TARGET_UBOOT_PATCH_DIR Frank Hunleth
2015-04-18 13:55   ` Thomas Petazzoni
2015-04-18 14:28     ` Frank Hunleth
2015-04-18 15:48       ` Thomas Petazzoni
2015-04-18  0:40 ` Vivien Didelot [this message]
2015-04-18 13:53 ` [Buildroot] [PATCH 1/3] uboot: add support for patch files and URLs Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877797848.435510.1429317641487.JavaMail.zimbra@savoirfairelinux.com \
    --to=vivien.didelot@savoirfairelinux.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox