Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] expect: bump to version 5.45.3
Date: Sun, 19 Apr 2015 12:35:43 +0200	[thread overview]
Message-ID: <20150419103543.GG4313@free.fr> (raw)
In-Reply-To: <CAHkwnC_X6OCfau4QcN1=rvF7VV3vXHg1pYcYUutBD9m6qkoqVw@mail.gmail.com>

Fabio, All,

On 2015-04-19 12:12 +0200, Fabio Porcedda spake thusly:
> On Sun, Apr 19, 2015 at 10:11 AM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> > On 2015-04-18 18:54 +0200, Fabio Porcedda spake thusly:
[--SNIP--]
> >> +EXPECT_VERSION = 2014/05/02 # v5.45.3
> >
> > Do not put comments after the variable definition, it breaks things.
> 
> Could you explain it?

I'm not sure what's going on here, but we've observed failures with
that, most notably when downloading via git, and removing the comment
made the error vanish.

One wild guess is that the space(s) between the version and the '#' are
part of the value, and that breaks later on. Really, just a wild
guess...

> > Note that the example we have in the manual is wrong. Care to address
> > that as well, please?
> 
> Sure

Thanks! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

      reply	other threads:[~2015-04-19 10:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 16:54 [Buildroot] [PATCH 0/3] expect: bump to version 5.45.3 Fabio Porcedda
2015-04-18 16:54 ` [Buildroot] [PATCH 1/3] support/download/cvs: add support to use a date instead of a tag Fabio Porcedda
2015-04-19  8:04   ` Yann E. MORIN
2015-04-18 16:54 ` [Buildroot] [PATCH 2/3] manual: cvs: document that a date can be used " Fabio Porcedda
2015-04-19  8:10   ` Yann E. MORIN
2015-04-19 10:08     ` Fabio Porcedda
2015-04-19 15:45       ` Arnout Vandecappelle
2015-04-20  2:36         ` Fabio Porcedda
2015-04-20 21:06           ` Arnout Vandecappelle
2015-04-22  8:03             ` Fabio Porcedda
2015-04-22 16:29               ` Yann E. MORIN
2015-04-22 20:27                 ` Arnout Vandecappelle
2015-04-20 17:32       ` Yann E. MORIN
2015-04-18 16:54 ` [Buildroot] [PATCH 3/3] expect: bump to version 5.45.3 Fabio Porcedda
2015-04-19  8:11   ` Yann E. MORIN
2015-04-19 10:12     ` Fabio Porcedda
2015-04-19 10:35       ` Yann E. MORIN [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150419103543.GG4313@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox