From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] manual: cvs: document that a date can be used instead of a tag
Date: Wed, 22 Apr 2015 18:29:36 +0200 [thread overview]
Message-ID: <20150422162936.GA4069@free.fr> (raw)
In-Reply-To: <CAHkwnC9qgzpdV9owFZr+Vi51-6fP18+XoeuMkKO=KLfg013xkw@mail.gmail.com>
Fabio, Gustavo, All,
On 2015-04-22 10:03 +0200, Fabio Porcedda spake thusly:
> On Mon, Apr 20, 2015 at 11:06 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> > On 20/04/15 04:36, Fabio Porcedda wrote:
[--SNIP--]
> >> This one works: (<YYYY>-<MM>-<DD>[T<HH>:<MM>[:<SS>][-<ZZ>] e.g
> >> 2015-12-20 or 2015-12-20T10:10-00)
> >
> > Well, the example should include a timezone and mention that adding a timezone
> > is advisable.
> Ok.
>
> > Alternatively, we could specifies that times are in UTC and set TZ=UTC in the
> > cvs helper.
>
> Fine for me.
> Yann what do you think about it?
I don't care. But what if a user specifies a timezone?
The tricky part with dealing with date (aka human date and timei) is
exactly that: having to deal with it. It is very complex to parse a date
in a reliable manner.
So we can't really validate a date. I'd rather we allow the full range
of dates supported by cvs, and let it deal with whatever the user
provides, and if that's incorrect, let cvs fail, not us (well, we'd
eventually fail, but not on our will).
> >> But to made it works I must replace the ":" with "_":
> >
> > Why? The / substitution is only needed because VERSION is used in filenames,
> > and : is fine in filenames, no?
>
> The colon is fine for filenames, neverthless if i don't replace it, I
> get this error:
>
> $ make expect-source
> package/expect/expect.mk:19: *** target pattern contains no '%'. Stop.
Yes, because the $(@D) contains the version string, and it is a make
goal. So, we'd end up wth something like;
foo-2015-04-22T18:26/.stamp_extracted:
blabla
Notice that there are two columns, and that is not valid make syntax
(AFAIR).
Which make me think: "2015-04-22 18:26" is an equally valid date, and we
do not really support spaces in paths, so we'd have to also replaces
spaces as well.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-04-22 16:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 16:54 [Buildroot] [PATCH 0/3] expect: bump to version 5.45.3 Fabio Porcedda
2015-04-18 16:54 ` [Buildroot] [PATCH 1/3] support/download/cvs: add support to use a date instead of a tag Fabio Porcedda
2015-04-19 8:04 ` Yann E. MORIN
2015-04-18 16:54 ` [Buildroot] [PATCH 2/3] manual: cvs: document that a date can be used " Fabio Porcedda
2015-04-19 8:10 ` Yann E. MORIN
2015-04-19 10:08 ` Fabio Porcedda
2015-04-19 15:45 ` Arnout Vandecappelle
2015-04-20 2:36 ` Fabio Porcedda
2015-04-20 21:06 ` Arnout Vandecappelle
2015-04-22 8:03 ` Fabio Porcedda
2015-04-22 16:29 ` Yann E. MORIN [this message]
2015-04-22 20:27 ` Arnout Vandecappelle
2015-04-20 17:32 ` Yann E. MORIN
2015-04-18 16:54 ` [Buildroot] [PATCH 3/3] expect: bump to version 5.45.3 Fabio Porcedda
2015-04-19 8:11 ` Yann E. MORIN
2015-04-19 10:12 ` Fabio Porcedda
2015-04-19 10:35 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422162936.GA4069@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox