Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] u-boot: Add sha256 hash value for earlier 2013.10 version.
@ 2015-04-19 16:49 Robert P. J. Day
  2015-04-21 11:35 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Robert P. J. Day @ 2015-04-19 16:49 UTC (permalink / raw)
  To: buildroot


Add a hash value for u-boot-2013.10.tar.bz2.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

  if i understand this correctly, if a package has no hash file, then
downloading generates a warning. but with the newly-added uboot.hash
file, the missing sha256sum for the earlier 2013.10 version generates
an "ERROR" when running "make source", even though the tarball is in
fact downloaded correctly. so just add a hash value to quiet the
download.

diff --git a/boot/uboot/uboot.hash b/boot/uboot/uboot.hash
index 9cc96f6..b98c2ff 100644
--- a/boot/uboot/uboot.hash
+++ b/boot/uboot/uboot.hash
@@ -1,2 +1,3 @@
 # Locally computed:
 sha256	0a1a70df586655f527befa6f12e184e96ed61b126e5a567382321b17200f5d60  u-boot-2015.04.tar.bz2
+sha256	0d71e62beb952b41ebafb20a7ee4df2f960db64c31b054721ceb79ff14014c55  u-boot-2013.10.tar.bz2

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] u-boot: Add sha256 hash value for earlier 2013.10 version.
  2015-04-19 16:49 [Buildroot] [PATCH] u-boot: Add sha256 hash value for earlier 2013.10 version Robert P. J. Day
@ 2015-04-21 11:35 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-04-21 11:35 UTC (permalink / raw)
  To: buildroot

Dear Robert P. J. Day,

On Sun, 19 Apr 2015 12:49:26 -0400 (EDT), Robert P. J. Day wrote:
> 
> Add a hash value for u-boot-2013.10.tar.bz2.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
>   if i understand this correctly, if a package has no hash file, then
> downloading generates a warning. but with the newly-added uboot.hash
> file, the missing sha256sum for the earlier 2013.10 version generates
> an "ERROR" when running "make source", even though the tarball is in
> fact downloaded correctly. so just add a hash value to quiet the
> download.

Nope, that's not the right way of doing things. First and foremost, a
missing hash in the hash file is currently not a hard failure, only a
warning. It will be turned into a hard failure soon, but with
appropriate handling of custom versions (see the patch series being
sent by Yann E. Morin and Arnout Vandecappelle about this).

The problem with your patch is that it adds just the hash file 2013.10.
What about the dozens of other U-Boot releases? And the zillions of
U-Boot forks all over the place?

Since it doesn't scale, we're going t keep it is simple: a hash for the
default U-Boot version currently used by Buildroot, and that's it.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-21 11:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-19 16:49 [Buildroot] [PATCH] u-boot: Add sha256 hash value for earlier 2013.10 version Robert P. J. Day
2015-04-21 11:35 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox