Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain
@ 2015-03-24  9:51 Alexey Brodkin
  2015-05-01 21:10 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Brodkin @ 2015-03-24  9:51 UTC (permalink / raw)
  To: buildroot

This external arc-2014.12 toolchain has uClibc with disabled
UCLIBC_HAS_PROGRAM_INVOCATION_NAME.

Because of this following build failure happens in autobuilder -
http://autobuild.buildroot.net/results/0fd/0fd36a0d79c4d82aedebb5aca8d3ce4214b1ed61/
--->8---
evtest.c: In function 'version':
evtest.c:730:20: error: 'program_invocation_short_name' undeclared (first use in this function)
  printf("%s %s\n", program_invocation_short_name, PACKAGE_VERSION);
                    ^
evtest.c:730:20: note: each undeclared identifier is reported only once for each function it appears in
evtest.c: In function 'usage':
evtest.c:742:38: error: 'program_invocation_short_name' undeclared (first use in this function)
  printf("   %s /dev/input/eventX\n", program_invocation_short_name);
--->8---

Mentioned config option was recently enabled in uClibc's defconfig for ARC:
https://github.com/foss-for-synopsys-dwc-arc-processors/uClibc/commit/c2460b9b7b8c76098dfb1313be4aa4a4a65ff619

So newer ARC uClibc toolchains should build evtest perfectly well.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Peter Seiderer <ps.report@gmx.net>
---
 scripts/autobuild-run | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index 872ee9d..69637f2 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -420,6 +420,10 @@ def fixup_config(**kwargs):
     if 'BR2_PACKAGE_WESTON=y\n' in configlines and \
        'BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/mipsel-ctng-linux-uclibc.tar.xz"\n' in configlines:
         return False
+    # This ARC uClibc toolchain fails to build the evtest package
+    if 'BR2_PACKAGE_EVTEST=y\n' in configlines and \
+       'BR2_TOOLCHAIN_EXTERNAL_SYNOPSYS_ARC_2014_12=y\n' in configlines:
+        return False
 
     with open(os.path.join(outputdir, ".config"), "w+") as configf:
         configf.writelines(configlines)
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain
  2015-03-24  9:51 [Buildroot] [PATCH] autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain Alexey Brodkin
@ 2015-05-01 21:10 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-05-01 21:10 UTC (permalink / raw)
  To: buildroot

Dear Alexey Brodkin,

On Tue, 24 Mar 2015 12:51:43 +0300, Alexey Brodkin wrote:
> This external arc-2014.12 toolchain has uClibc with disabled
> UCLIBC_HAS_PROGRAM_INVOCATION_NAME.
> 
> Because of this following build failure happens in autobuilder -
> http://autobuild.buildroot.net/results/0fd/0fd36a0d79c4d82aedebb5aca8d3ce4214b1ed61/
> --->8---
> evtest.c: In function 'version':
> evtest.c:730:20: error: 'program_invocation_short_name' undeclared (first use in this function)
>   printf("%s %s\n", program_invocation_short_name, PACKAGE_VERSION);
>                     ^
> evtest.c:730:20: note: each undeclared identifier is reported only once for each function it appears in
> evtest.c: In function 'usage':
> evtest.c:742:38: error: 'program_invocation_short_name' undeclared (first use in this function)
>   printf("   %s /dev/input/eventX\n", program_invocation_short_name);
> --->8---

I've marked this patch as Rejected, since I have committed another
patch to mark the Synopsys ARC external toolchain as "broken" because
the uClibc configuration is too far from the default Buildroot uClibc
configuration. We'll re-enable this toolchain once a new release is
made upstream, as we discussed.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-01 21:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-24  9:51 [Buildroot] [PATCH] autobuild-run: do not build evtest using extrenal arc-2014.12 toolchain Alexey Brodkin
2015-05-01 21:10 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox