Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] arch/Config.in.xtensa: provide BR2_ENDIAN symbol
@ 2015-05-05 16:18 Max Filippov
  2015-05-05 20:44 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Max Filippov @ 2015-05-05 16:18 UTC (permalink / raw)
  To: buildroot

Packages get hints from the buildroot at configure time, e.g.
ac_cv_c_bigendian=yes/no. This particular hint is based on the value of
BR2_ENDIAN and when it doesn't match actual toolchain endiannes the
build may break.
Provide BR2_ENDIAN for xtensa to fix this sort of build errors.

Fixes:
  http://autobuild.buildroot.net/results/31115fe8d88f52d77ed0f2da769eb8896a1b34a2/

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
Changes v1->v2:
- add spaces between configure items;
- expand changelog.

 arch/Config.in.xtensa | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/Config.in.xtensa b/arch/Config.in.xtensa
index ff71e0b..0687319 100644
--- a/arch/Config.in.xtensa
+++ b/arch/Config.in.xtensa
@@ -33,6 +33,23 @@ config BR2_XTENSA_OVERLAY_DIR
 	  configurations. They are provided by the processor vendor or
 	  directly from Tensilica.
 
+choice
+	prompt "Target Architecture Endianness"
+	depends on BR2_XTENSA_CUSTOM
+	default BR2_XTENSA_LITTLE_ENDIAN
+
+config BR2_XTENSA_LITTLE_ENDIAN
+	bool "Little endian"
+
+config BR2_XTENSA_BIG_ENDIAN
+	bool "Big endian"
+
+endchoice
+
+config BR2_ENDIAN
+	default "LITTLE"	if BR2_XTENSA_LITTLE_ENDIAN
+	default "BIG"		if BR2_xtensa_fsf || BR2_XTENSA_BIG_ENDIAN
+
 config BR2_ARCH
 	default "xtensa"	if BR2_xtensa
 
-- 
1.8.1.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2] arch/Config.in.xtensa: provide BR2_ENDIAN symbol
  2015-05-05 16:18 [Buildroot] [PATCH v2] arch/Config.in.xtensa: provide BR2_ENDIAN symbol Max Filippov
@ 2015-05-05 20:44 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-05-05 20:44 UTC (permalink / raw)
  To: buildroot

Dear Max Filippov,

On Tue,  5 May 2015 19:18:24 +0300, Max Filippov wrote:
> Packages get hints from the buildroot at configure time, e.g.
> ac_cv_c_bigendian=yes/no. This particular hint is based on the value of
> BR2_ENDIAN and when it doesn't match actual toolchain endiannes the
> build may break.
> Provide BR2_ENDIAN for xtensa to fix this sort of build errors.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/31115fe8d88f52d77ed0f2da769eb8896a1b34a2/
> 
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> Changes v1->v2:
> - add spaces between configure items;
> - expand changelog.

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-05-05 20:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-05 16:18 [Buildroot] [PATCH v2] arch/Config.in.xtensa: provide BR2_ENDIAN symbol Max Filippov
2015-05-05 20:44 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox