[Buildroot] [PATCH 1/1] zmqpp: fix compilation with some toolchains

[Buildroot] [PATCH 1/1] zmqpp: fix compilation with some toolchains

[Lionel Orry]

Fixes:
http://autobuild.buildroot.net/results/d9ec39dc5829aac1b25bfea7484458fcebd68412/

add cstdlib header to ensure EXIT_FAILURE presence

Using some cross-compiling toolchains, EXIT_FAILURE is not always
properly defined without this inclusion.

Patch is upstream:
https://github.com/zeromq/zmqpp/pull/109

Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
---
 package/zmqpp/0001-add-ctsdlib-header.patch | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/zmqpp/0001-add-ctsdlib-header.patch

diff --git a/package/zmqpp/0001-add-ctsdlib-header.patch b/package/zmqpp/0001-add-ctsdlib-header.patch
new file mode 100644
index 0000000..a4ae16e
--- /dev/null
+++ b/package/zmqpp/0001-add-ctsdlib-header.patch
@@ -0,0 +1,23 @@
+commit 57a27ccebdc2bc375267fcf0b82f5a66b20f86fa
+Author: Lionel Orry <lionel.orry@gmail.com>
+Date:   Fri May 15 14:13:22 2015 +0200
+
+    add cstdlib header to ensure EXIT_FAILURE presence
+    
+    Using some cross-compiling toolchains, EXIT_FAILURE is not always
+    properly defined without this inclusion.
+    
+    Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
+
+diff --git a/src/client/main.cpp b/src/client/main.cpp
+index 082c06b..760f01a 100644
+--- a/src/client/main.cpp
++++ b/src/client/main.cpp
+@@ -3,6 +3,7 @@
+  *      Author: @benjamg
+  */
+ 
++#include <cstdlib>
+ #include <array>
+ #include <iostream>
+ #include <tuple>
-- 
2.1.0

[Buildroot] [PATCH 1/1] zmqpp: fix compilation with some toolchains

[Thomas Petazzoni]

Dear Lionel Orry,

On Fri, 15 May 2015 14:26:40 +0200, Lionel Orry wrote:
> Fixes:
> http://autobuild.buildroot.net/results/d9ec39dc5829aac1b25bfea7484458fcebd68412/
> 
> add cstdlib header to ensure EXIT_FAILURE presence
> 
> Using some cross-compiling toolchains, EXIT_FAILURE is not always
> properly defined without this inclusion.
> 
> Patch is upstream:
> https://github.com/zeromq/zmqpp/pull/109
> 
> Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
> ---
>  package/zmqpp/0001-add-ctsdlib-header.patch | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 package/zmqpp/0001-add-ctsdlib-header.patch

I've applied your patch, but I've replaced the patch you included which
was just the output of 'git show' or 'git log -p' by a patch properly
formatted with 'git format-patch', so that it can be applied with 'git
am'.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] zmqpp: fix compilation with some toolchains

[Lionel Orry]

Hi Thomas,

On Sat, May 16, 2015 at 2:20 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Lionel Orry,
>
> On Fri, 15 May 2015 14:26:40 +0200, Lionel Orry wrote:
>> Fixes:
>> http://autobuild.buildroot.net/results/d9ec39dc5829aac1b25bfea7484458fcebd68412/
>>
>> add cstdlib header to ensure EXIT_FAILURE presence
>>
>> Using some cross-compiling toolchains, EXIT_FAILURE is not always
>> properly defined without this inclusion.
>>
>> Patch is upstream:
>> https://github.com/zeromq/zmqpp/pull/109
>>
>> Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
>> ---
>>  package/zmqpp/0001-add-ctsdlib-header.patch | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>  create mode 100644 package/zmqpp/0001-add-ctsdlib-header.patch
>
> I've applied your patch, but I've replaced the patch you included which
> was just the output of 'git show' or 'git log -p' by a patch properly
> formatted with 'git format-patch', so that it can be applied with 'git
> am'.

I did not know it was a preferred format, thanks for making that.
Maybe it could be interesting to give some more precisions about the
preferred package patches format in the manual, and how to prepare
them? cf. http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches

(of course it depends on the upstream software SCM and the method used
to make the patch...)

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

BR,
Lionel

[Buildroot] [PATCH 1/1] zmqpp: fix compilation with some toolchains

[Thomas Petazzoni]

Lionel,

On Mon, 18 May 2015 10:20:39 +0200, Lionel Orry wrote:

> > I've applied your patch, but I've replaced the patch you included which
> > was just the output of 'git show' or 'git log -p' by a patch properly
> > formatted with 'git format-patch', so that it can be applied with 'git
> > am'.
> 
> I did not know it was a preferred format, thanks for making that.
> Maybe it could be interesting to give some more precisions about the
> preferred package patches format in the manual, and how to prepare
> them? cf. http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches

Sure, feel free to send patches to the Buildroot documentation!

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com