From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/harfbuzz: disable test programs
Date: Mon, 18 May 2015 23:03:46 +0200 [thread overview]
Message-ID: <20150518230346.4c8a9a45@free-electrons.com> (raw)
In-Reply-To: <1431467484-14459-1-git-send-email-romain.naour@openwide.fr>
Dear Romain Naour,
On Tue, 12 May 2015 23:51:23 +0200, Romain Naour wrote:
> Workaround a build issue by disabling all test
> binaries since it forget to link with -lstd++.
>
> Add a new configure option to disable test programs
> in a upstreamable way.
>
> Fixes:
> http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef521ca/
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
I was almost going to apply this one, but I'm not entirely happy in
fact. I really works around the real problem, and does not fix it:
imagine a real program now links statically to harfbuzz using harfbuzz
pkg-config file. This pkg-config file does not advertise the dependency
on libstdc++ in its Libs.private, so the link would also fail, just
like it currently fails for the test programs.
Unfortunately, fixing the .pc file would not fix the internal harfbuzz
test programs, since they don't use pkg-config to get the link flags.
To be honest, I am not sure what is the correct automake way of fixing
this problem. Maybe:
-LDADD = $(top_builddir)/src/libharfbuzz.la $(GLIB_LIBS)
+LDADD = $(top_builddir)/src/libharfbuzz.la $(GLIB_LIBS) -lstdc++
in test/api/Makefile.am ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-18 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:51 [Buildroot] [PATCH v2 1/2] package/harfbuzz: disable test programs Romain Naour
2015-05-12 21:51 ` [Buildroot] [PATCH v2 2/2] Revert "harfbuzz: fix static linking of test programs when toolchain has threads support" Romain Naour
2015-05-18 21:03 ` Thomas Petazzoni [this message]
2015-05-18 21:40 ` [Buildroot] [PATCH v2 1/2] package/harfbuzz: disable test programs Romain Naour
2015-05-19 7:33 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150518230346.4c8a9a45@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox