[Buildroot] [PATCH v2 1/2] package/harfbuzz: disable test programs

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Romain,

On Mon, 18 May 2015 23:40:02 +0200, Romain Naour wrote:

> > I was almost going to apply this one, but I'm not entirely happy in
> > fact. I really works around the real problem, and does not fix it:
> > imagine a real program now links statically to harfbuzz using harfbuzz
> > pkg-config file. This pkg-config file does not advertise the dependency
> > on libstdc++ in its Libs.private, so the link would also fail, just
> > like it currently fails for the test programs.
> 
> -lstdc++ is only needed by libharfbuzz-icu.la which use the icu package.
> So maybe -lstdc++ is missing in Libs.private from icu-uc.pc ?

Yes, might be. It's weird: harfbuzz uses .cc as the extension for its
source files, but it seems to be only pure C, not C++. And to add to
the confusion, it also uses AC_PROG_CXX in its configure.ac, which
would also indicate it's in C++.

But obviously, icu is implemented in C++, so the icu-uc pkg-config file
should have the corresponding -lstdc++ Libs.private flag.


> You would said ;)
> test_unicode_LDADD += $(top_builddir)/src/libharfbuzz-icu.la -lstdc++
> 
> With that fixed, Harbuzz build fine.

Sounds good to me.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com