* [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV
@ 2015-05-20 16:00 Baruch Siach
2015-05-20 17:23 ` Baruch Siach
2015-05-20 21:28 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2015-05-20 16:00 UTC (permalink / raw)
To: buildroot
Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
QT5BASE_CONFIGURE_ENV is never set. Remove it.
Cc: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/qt5/qt5base/qt5base.mk | 1 -
1 file changed, 1 deletion(-)
diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index 3de824f5424b..e2db5d1e029c 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -174,7 +174,6 @@ define QT5BASE_CONFIGURE_CMDS
PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
- $(QT5BASE_CONFIGURE_ENV) \
./configure \
-v \
-prefix /usr \
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV
2015-05-20 16:00 [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV Baruch Siach
@ 2015-05-20 17:23 ` Baruch Siach
2015-05-20 21:28 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2015-05-20 17:23 UTC (permalink / raw)
To: buildroot
Hi Buildroot list,
On Wed, May 20, 2015 at 07:00:30PM +0300, Baruch Siach wrote:
> Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
> QT5BASE_CONFIGURE_ENV is never set. Remove it.
>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Adding Peter's Reviewed-by tag from the other email with a proper In-Reply-To
header for patchwork:
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Thanks,
baruch
> ---
> package/qt5/qt5base/qt5base.mk | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 3de824f5424b..e2db5d1e029c 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -174,7 +174,6 @@ define QT5BASE_CONFIGURE_CMDS
> PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
> PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
> MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
> - $(QT5BASE_CONFIGURE_ENV) \
> ./configure \
> -v \
> -prefix /usr \
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV
2015-05-20 16:00 [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV Baruch Siach
2015-05-20 17:23 ` Baruch Siach
@ 2015-05-20 21:28 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2015-05-20 21:28 UTC (permalink / raw)
To: buildroot
Dear Baruch Siach,
On Wed, 20 May 2015 19:00:30 +0300, Baruch Siach wrote:
> Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
> QT5BASE_CONFIGURE_ENV is never set. Remove it.
>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/qt5/qt5base/qt5base.mk | 1 -
> 1 file changed, 1 deletion(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV
@ 2015-05-20 16:09 Peter Seiderer
0 siblings, 0 replies; 4+ messages in thread
From: Peter Seiderer @ 2015-05-20 16:09 UTC (permalink / raw)
To: buildroot
Hello Baruch,
On Wed, May 20, 2015 at 07:00:30PM +0300, Baruch Siach wrote:
> Since 1b54fbc925f4 (qt5base: fix postgresql plugin compile, 2015-02-19)
> QT5BASE_CONFIGURE_ENV is never set. Remove it.
>
> Cc: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/qt5/qt5base/qt5base.mk | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 3de824f5424b..e2db5d1e029c 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -174,7 +174,6 @@ define QT5BASE_CONFIGURE_CMDS
> PKG_CONFIG_LIBDIR="$(STAGING_DIR)/usr/lib/pkgconfig" \
> PKG_CONFIG_SYSROOT_DIR="$(STAGING_DIR)" \
> MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
> - $(QT5BASE_CONFIGURE_ENV) \
> ./configure \
> -v \
> -prefix /usr \
> --
> 2.1.4
>
Thanks for spotting this one, you can add my:
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-20 21:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-20 16:00 [Buildroot] [PATCH] qt5base: remove never set QT5BASE_CONFIGURE_ENV Baruch Siach
2015-05-20 17:23 ` Baruch Siach
2015-05-20 21:28 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2015-05-20 16:09 Peter Seiderer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox