* [Buildroot] [PATCH 0/2] new packages gflags and glog
@ 2015-06-09 6:27 Rahul Bedarkar
2015-06-09 6:27 ` [Buildroot] [PATCH 1/2] gflags: new package Rahul Bedarkar
2015-06-09 6:27 ` [Buildroot] [PATCH 2/2] glog: " Rahul Bedarkar
0 siblings, 2 replies; 5+ messages in thread
From: Rahul Bedarkar @ 2015-06-09 6:27 UTC (permalink / raw)
To: buildroot
This patch set adds two new packages gflags and glog.
Rahul Bedarkar (2):
gflags: new package
glog: new package
package/Config.in | 2 ++
package/gflags/Config.in | 13 +++++++++++++
package/gflags/gflags.hash | 2 ++
package/gflags/gflags.mk | 17 +++++++++++++++++
package/glog/Config.in | 11 +++++++++++
package/glog/glog.hash | 2 ++
package/glog/glog.mk | 17 +++++++++++++++++
7 files changed, 64 insertions(+)
create mode 100644 package/gflags/Config.in
create mode 100644 package/gflags/gflags.hash
create mode 100644 package/gflags/gflags.mk
create mode 100644 package/glog/Config.in
create mode 100644 package/glog/glog.hash
create mode 100644 package/glog/glog.mk
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] gflags: new package
2015-06-09 6:27 [Buildroot] [PATCH 0/2] new packages gflags and glog Rahul Bedarkar
@ 2015-06-09 6:27 ` Rahul Bedarkar
2015-06-09 7:01 ` Thomas Petazzoni
2015-06-09 6:27 ` [Buildroot] [PATCH 2/2] glog: " Rahul Bedarkar
1 sibling, 1 reply; 5+ messages in thread
From: Rahul Bedarkar @ 2015-06-09 6:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
Reviewed-by: Abhimanyu Vishwakarma <abhimanyu.v@imgtec.com>
Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
package/Config.in | 1 +
package/gflags/Config.in | 13 +++++++++++++
package/gflags/gflags.hash | 2 ++
package/gflags/gflags.mk | 17 +++++++++++++++++
4 files changed, 33 insertions(+)
create mode 100644 package/gflags/Config.in
create mode 100644 package/gflags/gflags.hash
create mode 100644 package/gflags/gflags.mk
diff --git a/package/Config.in b/package/Config.in
index e0c2e2a..84248c4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1013,6 +1013,7 @@ menu "Other"
source "package/elfutils/Config.in"
source "package/fftw/Config.in"
source "package/flann/Config.in"
+ source "package/gflags/Config.in"
source "package/glibmm/Config.in"
source "package/glm/Config.in"
source "package/gmp/Config.in"
diff --git a/package/gflags/Config.in b/package/gflags/Config.in
new file mode 100644
index 0000000..ed05944
--- /dev/null
+++ b/package/gflags/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_GFLAGS
+ bool "gflags"
+ depends on BR2_INSTALL_LIBSTDCPP
+ help
+ The gflags package contains a C++ library that implements
+ commandline flags processing. It includes built-in support for
+ standard types such as string and the ability to define flags
+ in the source file in which they are used.
+
+ https://github.com/gflags/gflags
+
+comment "gflags needs a toolchain w/ C++"
+ depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/gflags/gflags.hash b/package/gflags/gflags.hash
new file mode 100644
index 0000000..9c8b27a
--- /dev/null
+++ b/package/gflags/gflags.hash
@@ -0,0 +1,2 @@
+# No hash for v2.1.2, comes from the github-helper:
+none xxx gflags-v2.1.2.tar.gz
diff --git a/package/gflags/gflags.mk b/package/gflags/gflags.mk
new file mode 100644
index 0000000..a6029c7
--- /dev/null
+++ b/package/gflags/gflags.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# gflags
+#
+################################################################################
+
+GFLAGS_VERSION = v2.1.2
+GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION))
+GFLAGS_INSTALL_STAGING = YES
+GFLAGS_LICENSE = BSD-3c
+GFLAGS_LICENSE_FILES = COPYING.txt
+
+ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n)
+GFLAGS_CONF_OPTS = -DBUILD_gflags_LIB=OFF
+endif
+
+$(eval $(cmake-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] glog: new package
2015-06-09 6:27 [Buildroot] [PATCH 0/2] new packages gflags and glog Rahul Bedarkar
2015-06-09 6:27 ` [Buildroot] [PATCH 1/2] gflags: new package Rahul Bedarkar
@ 2015-06-09 6:27 ` Rahul Bedarkar
1 sibling, 0 replies; 5+ messages in thread
From: Rahul Bedarkar @ 2015-06-09 6:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com>
Reviewed-by: Abhimanyu Vishwakarma <abhimanyu.v@imgtec.com>
Reviewed-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
package/Config.in | 1 +
package/glog/Config.in | 11 +++++++++++
package/glog/glog.hash | 2 ++
package/glog/glog.mk | 17 +++++++++++++++++
4 files changed, 31 insertions(+)
create mode 100644 package/glog/Config.in
create mode 100644 package/glog/glog.hash
create mode 100644 package/glog/glog.mk
diff --git a/package/Config.in b/package/Config.in
index 84248c4..1d9c972 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -892,6 +892,7 @@ menu "JSON/XML"
endmenu
menu "Logging"
+ source "package/glog/Config.in"
source "package/liblog4c-localtime/Config.in"
source "package/liblogging/Config.in"
source "package/log4cplus/Config.in"
diff --git a/package/glog/Config.in b/package/glog/Config.in
new file mode 100644
index 0000000..aed0a3e
--- /dev/null
+++ b/package/glog/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_GLOG
+ bool "glog"
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_THREADS
+ help
+ C++ implementation of the Google logging module
+
+ https://github.com/google/glog
+
+comment "glog needs a toolchain w/ C++, threads"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/glog/glog.hash b/package/glog/glog.hash
new file mode 100644
index 0000000..dad1543
--- /dev/null
+++ b/package/glog/glog.hash
@@ -0,0 +1,2 @@
+# No hash for v0.3.4, comes from the github-helper:
+none xxx glog-v0.3.4.tar.gz
diff --git a/package/glog/glog.mk b/package/glog/glog.mk
new file mode 100644
index 0000000..8a84094
--- /dev/null
+++ b/package/glog/glog.mk
@@ -0,0 +1,17 @@
+################################################################################
+#
+# glog
+#
+################################################################################
+
+GLOG_VERSION = v0.3.4
+GLOG_SITE = $(call github,google,glog,$(GLOG_VERSION))
+GLOG_INSTALL_STAGING = YES
+GLOG_LICENSE = BSD-3c
+GLOG_LICENSE_FILES = COPYING
+
+ifeq ($(BR2_PACKAGE_GFLAGS),y)
+GLOG_DEPENDENCIES = gflags
+endif
+
+$(eval $(autotools-package))
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] gflags: new package
2015-06-09 6:27 ` [Buildroot] [PATCH 1/2] gflags: new package Rahul Bedarkar
@ 2015-06-09 7:01 ` Thomas Petazzoni
2015-06-09 21:57 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2015-06-09 7:01 UTC (permalink / raw)
To: buildroot
Dear Rahul Bedarkar,
Thanks for this contribution. A few comments below.
On Tue, 9 Jun 2015 11:57:29 +0530, Rahul Bedarkar wrote:
> diff --git a/package/gflags/gflags.hash b/package/gflags/gflags.hash
> new file mode 100644
> index 0000000..9c8b27a
> --- /dev/null
> +++ b/package/gflags/gflags.hash
> @@ -0,0 +1,2 @@
> +# No hash for v2.1.2, comes from the github-helper:
> +none xxx gflags-v2.1.2.tar.gz
I believe in this case, we generally do not provide a hash file at all.
Though maybe in the future we will want to have a hash file for *all*
packages. Yann, what is our policy on this?
> +GFLAGS_VERSION = v2.1.2
> +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION))
> +GFLAGS_INSTALL_STAGING = YES
> +GFLAGS_LICENSE = BSD-3c
> +GFLAGS_LICENSE_FILES = COPYING.txt
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n)
This should be:
ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] gflags: new package
2015-06-09 7:01 ` Thomas Petazzoni
@ 2015-06-09 21:57 ` Yann E. MORIN
0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-06-09 21:57 UTC (permalink / raw)
To: buildroot
Thomas, Rahul, All,
On 2015-06-09 09:01 +0200, Thomas Petazzoni spake thusly:
> On Tue, 9 Jun 2015 11:57:29 +0530, Rahul Bedarkar wrote:
>
> > diff --git a/package/gflags/gflags.hash b/package/gflags/gflags.hash
> > new file mode 100644
> > index 0000000..9c8b27a
> > --- /dev/null
> > +++ b/package/gflags/gflags.hash
> > @@ -0,0 +1,2 @@
> > +# No hash for v2.1.2, comes from the github-helper:
> > +none xxx gflags-v2.1.2.tar.gz
>
> I believe in this case, we generally do not provide a hash file at all.
> Though maybe in the future we will want to have a hash file for *all*
> packages. Yann, what is our policy on this?
Hmm. Ideally, I think we want a .hash file for all packages, so that can
eventually be a hard error when one is missing.
However, I can see that can be cumbersome to add a .hash file to just
say 'talk to my hand, I have no hash'. Especially as we're not enforcing
it so far...
But I was planning on working on .hash sometime this summer to add all
those missing at the time, so we have all .hash files for the lat
release of the year. I'm pretty happy to see so many hashes being added
in the meantime! ;-)
So, to answer the specific question: I think that is good to have a
none-hash file; and to top it off, it's nicely commented. :-)
Regards,
Yann E. MORIN.
> > +GFLAGS_VERSION = v2.1.2
> > +GFLAGS_SITE = $(call github,gflags,gflags,$(GFLAGS_VERSION))
> > +GFLAGS_INSTALL_STAGING = YES
> > +GFLAGS_LICENSE = BSD-3c
> > +GFLAGS_LICENSE_FILES = COPYING.txt
> > +
> > +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),n)
>
> This should be:
>
> ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-09 21:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-09 6:27 [Buildroot] [PATCH 0/2] new packages gflags and glog Rahul Bedarkar
2015-06-09 6:27 ` [Buildroot] [PATCH 1/2] gflags: new package Rahul Bedarkar
2015-06-09 7:01 ` Thomas Petazzoni
2015-06-09 21:57 ` Yann E. MORIN
2015-06-09 6:27 ` [Buildroot] [PATCH 2/2] glog: " Rahul Bedarkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox