From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libxmlrpc: fix static build
Date: Fri, 12 Jun 2015 23:13:07 +0200 [thread overview]
Message-ID: <20150612231307.690e22d0@free-electrons.com> (raw)
In-Reply-To: <5425b32256128e928f8ad22c596f91ab7ac5f9e8.1433859609.git.baruch@tkos.co.il>
Dear Baruch Siach,
On Tue, 9 Jun 2015 17:20:09 +0300, Baruch Siach wrote:
> Fixes:
> http://autobuild.buildroot.net/results/16d/16de14ace7b4e089f56b9cb173542e487cae3a9d/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/libxmlrpc/libxmlrpc.mk | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/package/libxmlrpc/libxmlrpc.mk b/package/libxmlrpc/libxmlrpc.mk
> index c3788d6c3f36..a6137e07b828 100644
> --- a/package/libxmlrpc/libxmlrpc.mk
> +++ b/package/libxmlrpc/libxmlrpc.mk
> @@ -35,4 +35,14 @@ LIBXMLRPC_MAKE_ENV = \
> CFLAGS_FOR_BUILD="$(HOST_CFLAGS)" \
> LDFLAGS_FOR_BUILD="$(HOST_LDFLAGS)"
>
> +ifeq ($(BR2_STATIC_LIBS),y)
> +LIBXMLRPC_STATIC_OPTS = SHARED_LIB_TYPE=NONE MUST_BUILD_SHLIB=N
> +endif
> +
> +LIBXMLRPC_MAKE_OPTS = $(LIBXMLRPC_STATIC_OPTS)
> +LIBXMLRPC_INSTALL_STAGING_OPTS = $(LIBXMLRPC_STATIC_OPTS) \
> + DESTDIR=$(STAGING_DIR) install
> +LIBXMLRPC_INSTALL_TARGET_OPTS = $(LIBXMLRPC_STATIC_OPTS) \
> + DESTDIR=$(TARGET_DIR) install
> +
> $(eval $(autotools-package))
Can you try instead something like:
ifeq ($(BR2_STATIC_LIBS),y)
LIBXMLRPC_MAKE_ENV += SHARED_LIB_TYPE=NONE MUST_BUILD_SHLIB=N
endif
The advantage is that LIBXMLRPC_MAKE_ENV is passed to the build,
install staging and install target steps.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-06-12 21:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 14:20 [Buildroot] [PATCH] libxmlrpc: fix static build Baruch Siach
2015-06-12 21:13 ` Thomas Petazzoni [this message]
2015-06-14 19:07 ` Baruch Siach
2015-06-14 21:00 ` Thomas Petazzoni
2015-06-14 21:48 ` Arnout Vandecappelle
2015-06-19 4:34 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612231307.690e22d0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox