[Buildroot] [PATCH] libxmlrpc: fix static build

[Arnout Vandecappelle <arnout@mind.be>]

On 06/14/15 23:00, Thomas Petazzoni wrote:
> Dear Baruch Siach,
> 
> On Sun, 14 Jun 2015 22:07:38 +0300, Baruch Siach wrote:
> 
>> Unfortunately, these make variables are set explicitly in common.mk. So 
>> passing them in make environment has no effect.
> 
> Argh, ok.
> 
>> Now that I think about it, why don't we have a similar thing for MAKE_OPTS, 
>> say, $(PKG)_MAKE_VARS. Something like (untested, host packages missing):
>>
>> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
>> index 1d694f0618fc..27ff16235f27 100644
>> --- a/package/pkg-autotools.mk
>> +++ b/package/pkg-autotools.mk
>> @@ -154,10 +154,10 @@ endif
>>  $(2)_CONF_ENV			?=
>>  $(2)_CONF_OPTS			?=
>>  $(2)_MAKE_ENV			?=
>> -$(2)_MAKE_OPTS			?=
>> -$(2)_INSTALL_OPTS                ?= install
>> -$(2)_INSTALL_STAGING_OPTS	?= DESTDIR=$$(STAGING_DIR) install
>> -$(2)_INSTALL_TARGET_OPTS		?= DESTDIR=$$(TARGET_DIR)  install
>> +$(2)_MAKE_OPTS			?= $$($(2)_MAKE_VARS)
>> +$(2)_INSTALL_OPTS		?= $$($(2)_MAKE_VARS) install
>> +$(2)_INSTALL_STAGING_OPTS	?= $$($(2)_MAKE_VARS) DESTDIR=$$(STAGING_DIR) install
>> +$(2)_INSTALL_TARGET_OPTS	?= $$($(2)_MAKE_VARS) DESTDIR=$$(TARGET_DIR) install
> 
> Why not. Though I'd be more convinced if there is some evidence that it
> would also be useful for other packages.
> 
> Or maybe we simply need to make $(2)_MAKE_OPTS used for both the build
> and install steps?

 Well, MAKE_OPTS includes the target that has to be built, so it can't just be
reused as is for _INSTALL. So Baruch's proposal makes more sense to me.

 Regards,
 Arnout

> 
> Best regards,
> 
> Thomas
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F