* [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version
@ 2015-06-30 10:42 Martin Bark
2015-06-30 10:42 ` [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin Martin Bark
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Martin Bark @ 2015-06-30 10:42 UTC (permalink / raw)
To: buildroot
The version of the V8 JavaScript engine used by node.js v0.12.5 requires
at least an ARMv6 architecture with VFPv2. For this reason v0.10.39
remains the default for ARMv5 targets, all other targets now default to
v0.12.5.
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v2 -> v3
- Corrected default node.js version on ARMv5 (Suggested by Yann E. MORIN)
- Removed stray empty line (Suggested by Yann E. MORIN)
- Corrected Signed-off-by in 0.12.5 patches (Suggested by Yann E. MORIN)
- Improved commit message
Changes v1 -> v2
- Added depends on !BR2_ARM_CPU_ARMV5
- Updated from node.js v0.12.4 to v0.12.5
---
...01-Remove-dependency-on-Python-bz2-module.patch | 39 ++++++++++++++
.../0002-gyp-force-link-command-to-use-CXX.patch | 27 ++++++++++
...hon-variable-instead-of-hardcoding-Python.patch | 63 ++++++++++++++++++++++
...4-fix-build-error-without-OpenSSL-support.patch | 46 ++++++++++++++++
package/nodejs/Config.in | 7 ++-
package/nodejs/nodejs.hash | 3 ++
6 files changed, 184 insertions(+), 1 deletion(-)
create mode 100644 package/nodejs/0.12.5/0001-Remove-dependency-on-Python-bz2-module.patch
create mode 100644 package/nodejs/0.12.5/0002-gyp-force-link-command-to-use-CXX.patch
create mode 100644 package/nodejs/0.12.5/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
create mode 100644 package/nodejs/0.12.5/0004-fix-build-error-without-OpenSSL-support.patch
diff --git a/package/nodejs/0.12.5/0001-Remove-dependency-on-Python-bz2-module.patch b/package/nodejs/0.12.5/0001-Remove-dependency-on-Python-bz2-module.patch
new file mode 100644
index 0000000..24a78a4
--- /dev/null
+++ b/package/nodejs/0.12.5/0001-Remove-dependency-on-Python-bz2-module.patch
@@ -0,0 +1,39 @@
+From 3d4817c152d6f3afddcc699949c4d1664da91e2b Mon Sep 17 00:00:00 2001
+From: Martin Bark <martin@barkynet.com>
+Date: Tue, 30 Jun 2015 09:43:11 +0100
+Subject: [PATCH 1/4] Remove dependency on Python bz2 module
+
+The Python bz2 module is only needed in certain cases, so only import
+it when needed. In the normal nodejs build, this allows to remove the
+dependency on this module.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+[Martin: adapt to 0.12.5]
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ deps/v8/tools/js2c.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/deps/v8/tools/js2c.py b/deps/v8/tools/js2c.py
+index 77485f6..371caf5 100755
+--- a/deps/v8/tools/js2c.py
++++ b/deps/v8/tools/js2c.py
+@@ -34,7 +34,6 @@
+ import os, re, sys, string
+ import optparse
+ import jsmin
+-import bz2
+ import textwrap
+
+
+@@ -492,6 +491,7 @@ def CompressMaybe(sources, compression_type):
+ if compression_type == "off":
+ return sources_bytes
+ elif compression_type == "bz2":
++ import bz2
+ return bz2.compress(sources_bytes)
+ else:
+ raise Error("Unknown compression type %s." % compression_type)
+--
+2.1.4
+
diff --git a/package/nodejs/0.12.5/0002-gyp-force-link-command-to-use-CXX.patch b/package/nodejs/0.12.5/0002-gyp-force-link-command-to-use-CXX.patch
new file mode 100644
index 0000000..3b007f1
--- /dev/null
+++ b/package/nodejs/0.12.5/0002-gyp-force-link-command-to-use-CXX.patch
@@ -0,0 +1,27 @@
+From 90a3c113c19ec615249ab880c45c6c0a8d369098 Mon Sep 17 00:00:00 2001
+From: Martin Bark <martin@barkynet.com>
+Date: Tue, 30 Jun 2015 09:43:47 +0100
+Subject: [PATCH 2/4] gyp: force link command to use CXX
+
+Signed-off-by: Samuel Martin <s.martin49@gmail.com>
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ tools/gyp/pylib/gyp/generator/make.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/gyp/pylib/gyp/generator/make.py b/tools/gyp/pylib/gyp/generator/make.py
+index b88a433..0a1f2e0 100644
+--- a/tools/gyp/pylib/gyp/generator/make.py
++++ b/tools/gyp/pylib/gyp/generator/make.py
+@@ -141,7 +141,7 @@ cmd_alink_thin = rm -f $@ && $(AR.$(TOOLSET)) crsT $@ $(filter %.o,$^)
+ # special "figure out circular dependencies" flags around the entire
+ # input list during linking.
+ quiet_cmd_link = LINK($(TOOLSET)) $@
+-cmd_link = $(LINK.$(TOOLSET)) $(GYP_LDFLAGS) $(LDFLAGS.$(TOOLSET)) -o $@ -Wl,--start-group $(LD_INPUTS) -Wl,--end-group $(LIBS)
++cmd_link = $(CXX.$(TOOLSET)) $(GYP_LDFLAGS) $(LDFLAGS.$(TOOLSET)) -o $@ -Wl,--start-group $(LD_INPUTS) -Wl,--end-group $(LIBS)
+
+ # We support two kinds of shared objects (.so):
+ # 1) shared_library, which is just bundling together many dependent libraries
+--
+2.1.4
+
diff --git a/package/nodejs/0.12.5/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch b/package/nodejs/0.12.5/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
new file mode 100644
index 0000000..37ceda3
--- /dev/null
+++ b/package/nodejs/0.12.5/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
@@ -0,0 +1,63 @@
+From 4a48c65921b0f05b621aef5b902b6aa54811ad7a Mon Sep 17 00:00:00 2001
+From: Martin Bark <martin@barkynet.com>
+Date: Tue, 30 Jun 2015 09:44:33 +0100
+Subject: [PATCH 3/4] Use a python variable instead of hardcoding Python
+
+The nodejs build system uses python in a number of locations. However,
+there are some locations where it hardcodes 'python' as the Python
+interpreter. However, this causes problems when we need to use python2
+instead of just python.
+
+This patch fixes that by using the python variable already in place in
+the nodejs build system.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+[Martin: adapt to 0.12.5]
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ deps/v8/tools/gyp/v8.gyp | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+diff --git a/deps/v8/tools/gyp/v8.gyp b/deps/v8/tools/gyp/v8.gyp
+index c703155..06c0b2b 100644
+--- a/deps/v8/tools/gyp/v8.gyp
++++ b/deps/v8/tools/gyp/v8.gyp
+@@ -1353,7 +1353,7 @@
+ 'outputs': [
+ '<(PRODUCT_DIR)/natives_blob.bin',
+ ],
+- 'action': ['python', '<@(_inputs)', '<@(_outputs)'],
++ 'action': ['<(python)', '<@(_inputs)', '<@(_outputs)'],
+ }],
+ }],
+ ['want_separate_host_toolset==1', {
+@@ -1435,7 +1435,7 @@
+ '<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
+ ],
+ 'action': [
+- 'python',
++ '<(python)',
+ '../../tools/js2c.py',
+ '<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
+ 'CORE',
+@@ -1462,7 +1462,7 @@
+ '<(SHARED_INTERMEDIATE_DIR)/experimental-libraries.cc',
+ ],
+ 'action': [
+- 'python',
++ '<(python)',
+ '../../tools/js2c.py',
+ '<(SHARED_INTERMEDIATE_DIR)/experimental-libraries.cc',
+ 'EXPERIMENTAL',
+@@ -1500,7 +1500,7 @@
+ '<(SHARED_INTERMEDIATE_DIR)/debug-support.cc',
+ ],
+ 'action': [
+- 'python',
++ '<(python)',
+ '../../tools/gen-postmortem-metadata.py',
+ '<@(_outputs)',
+ '<@(heapobject_files)'
+--
+2.1.4
+
diff --git a/package/nodejs/0.12.5/0004-fix-build-error-without-OpenSSL-support.patch b/package/nodejs/0.12.5/0004-fix-build-error-without-OpenSSL-support.patch
new file mode 100644
index 0000000..ccb29b1
--- /dev/null
+++ b/package/nodejs/0.12.5/0004-fix-build-error-without-OpenSSL-support.patch
@@ -0,0 +1,46 @@
+From 6bfa497dceb83de5257c64da59fbcf6a32d83305 Mon Sep 17 00:00:00 2001
+From: Martin Bark <martin@barkynet.com>
+Date: Tue, 30 Jun 2015 09:45:07 +0100
+Subject: [PATCH 4/4] fix build error without OpenSSL support
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Signed-off-by: J?rg Krause <jkrause@posteo.de>
+[Martin: adapt to 0.12.5]
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ src/node.cc | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/src/node.cc b/src/node.cc
+index e669706..d43b791 100644
+--- a/src/node.cc
++++ b/src/node.cc
+@@ -2934,8 +2934,10 @@ static void PrintHelp() {
+ " present.\n"
+ #endif
+ #endif
++#if HAVE_OPENSSL
+ " --enable-ssl2 enable ssl2\n"
+ " --enable-ssl3 enable ssl3\n"
++#endif
+ "\n"
+ "Environment variables:\n"
+ #ifdef _WIN32
+@@ -3003,10 +3005,12 @@ static void ParseArgs(int* argc,
+ } else if (strcmp(arg, "--version") == 0 || strcmp(arg, "-v") == 0) {
+ printf("%s\n", NODE_VERSION);
+ exit(0);
++#if HAVE_OPENSSL
+ } else if (strcmp(arg, "--enable-ssl2") == 0) {
+ SSL2_ENABLE = true;
+ } else if (strcmp(arg, "--enable-ssl3") == 0) {
+ SSL3_ENABLE = true;
++#endif
+ } else if (strcmp(arg, "--help") == 0 || strcmp(arg, "-h") == 0) {
+ PrintHelp();
+ exit(0);
+--
+2.1.4
+
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index 9a39385..1e0681b 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -24,18 +24,23 @@ if BR2_PACKAGE_NODEJS
choice
prompt "Node.js version"
- default BR2_BR2_PACKAGE_NODEJS_0_10_39
+ default BR2_BR2_PACKAGE_NODEJS_0_10_39 if BR2_ARM_CPU_ARMV5
+ default BR2_BR2_PACKAGE_NODEJS_0_12_5
help
Select the version of Node.js you wish to use.
config BR2_BR2_PACKAGE_NODEJS_0_10_39
bool "v0.10.39"
+config BR2_BR2_PACKAGE_NODEJS_0_12_5
+ bool "v0.12.5"
+
endchoice
config BR2_PACKAGE_NODEJS_VERSION_STRING
string
default "0.10.39" if BR2_BR2_PACKAGE_NODEJS_0_10_39
+ default "0.12.5" if BR2_BR2_PACKAGE_NODEJS_0_12_5
menu "Module Selection"
diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
index bc1f15f..816d602 100644
--- a/package/nodejs/nodejs.hash
+++ b/package/nodejs/nodejs.hash
@@ -1,2 +1,5 @@
# From upstream URL: http://nodejs.org/dist/v0.10.39/SHASUMS256.txt
sha256 68f8d8f9515c4e77e2a06034b742e19e9848c1fee5bcadedc1d68f3e4302df37 node-v0.10.39.tar.gz
+
+# From upstream URL: http://nodejs.org/dist/v0.12.5/SHASUMS256.txt
+sha256 4bc1e25f4c62ac65324d3cf4aa9de2d801cd708757c3567b6ad2ced7df30cdd2 node-v0.12.5.tar.gz
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin
2015-06-30 10:42 [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Martin Bark
@ 2015-06-30 10:42 ` Martin Bark
2015-06-30 17:48 ` Yann E. MORIN
2015-06-30 10:42 ` [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command Martin Bark
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Martin Bark @ 2015-06-30 10:42 UTC (permalink / raw)
To: buildroot
This patch symlinks all executables in /usr/lib/node_modules/.bin
to /usr/bin so that node.js modules installed using
BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL are accessible from the command line.
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v2 -> v3
- Create symlinks instead of setting PATH (Suggested by Yann E. MORIN)
Changes v1 -> v2
- Improved commit message
---
package/nodejs/nodejs.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 59e03b0..0b3f8a5 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -111,6 +111,14 @@ define NODEJS_INSTALL_MODULES
$(HOST_DIR)/usr/bin/npm install \
$(NODEJS_MODULES_LIST) \
)
+
+ # Symlink all executables in $(TARGET_DIR)/usr/lib/node_modules/.bin to
+ # $(TARGET_DIR)/usr/bin so they are accessible from the command line
+ cd $(TARGET_DIR)/usr/bin; \
+ for f in ../../usr/lib/node_modules/.bin/*; do \
+ [ -f "$${f}" -a -x "$${f}" ] || continue; \
+ ln -sf "$${f}" "$${f##*/}" || exit 1; \
+ done
endef
endif
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command
2015-06-30 10:42 [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Martin Bark
2015-06-30 10:42 ` [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin Martin Bark
@ 2015-06-30 10:42 ` Martin Bark
2015-06-30 18:01 ` Yann E. MORIN
2015-06-30 10:42 ` [Buildroot] [v3 4/4] package/nodejs: Define NPM command for other packages to use Martin Bark
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Martin Bark @ 2015-06-30 10:42 UTC (permalink / raw)
To: buildroot
Many packages use node-pre-gpy as a way of deploying precompiled binary
dependencies with fall back to compilation for other targets. node-gyp
uses the option --arch to determine its target architecture (which is
already set correctly), however, node-pre-gyp uses --target-arch. Without
this set node.js packages that uses node-pre-gyp will pick the wrong target
architecture.
This patch sets npm_config_target_arch to solve this issue. I have tested
this using the node.js package serialport.
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v2 -> v3
- Adjusted patch order so this is before the new definition of $(NPM)
Changes v1 -> v2
- No changes, new in v2
---
package/nodejs/nodejs.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 0b3f8a5..78db49d 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -107,6 +107,7 @@ define NODEJS_INSTALL_MODULES
$(TARGET_CONFIGURE_OPTS) \
LD="$(TARGET_CXX)" \
npm_config_arch=$(NODEJS_CPU) \
+ npm_config_target_arch=$(NODEJS_CPU) \
npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
$(HOST_DIR)/usr/bin/npm install \
$(NODEJS_MODULES_LIST) \
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [v3 4/4] package/nodejs: Define NPM command for other packages to use
2015-06-30 10:42 [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Martin Bark
2015-06-30 10:42 ` [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin Martin Bark
2015-06-30 10:42 ` [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command Martin Bark
@ 2015-06-30 10:42 ` Martin Bark
2015-06-30 17:52 ` Yann E. MORIN
2015-06-30 17:46 ` [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Yann E. MORIN
2015-06-30 22:20 ` Yann E. MORIN
4 siblings, 1 reply; 11+ messages in thread
From: Martin Bark @ 2015-06-30 10:42 UTC (permalink / raw)
To: buildroot
Other nodejs-related packages will need to call npm with the same set of
arguments as is currently used by the nodejs package itself.
To avoid duplicating this code, set the NPM variable so those packages can
re-use it.
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Note: currently, this is only used in the nodejs package itself. I
plan on sending new nodejs-related packages that will use this, like
a pm2 (https://github.com/Unitech/pm2) package which I have tested
successfully using this $(NPM).
Changes v2 -> v3
- Improved commit message (Suggested by Yann E. MORIN)
Changes v1 -> v2
- No changes
---
package/nodejs/nodejs.mk | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 78db49d..ea8ec0f5 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -95,6 +95,14 @@ NODEJS_MODULES_LIST= $(call qstrip,\
$(if $(BR2_PACKAGE_NODEJS_MODULES_COFFEESCRIPT),coffee-script) \
$(BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL))
+# Define NPM for other packages to use
+NPM = $(TARGET_CONFIGURE_OPTS) \
+ LD="$(TARGET_CXX)" \
+ npm_config_arch=$(NODEJS_CPU) \
+ npm_config_target_arch=$(NODEJS_CPU) \
+ npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
+ $(HOST_DIR)/usr/bin/npm
+
#
# We can only call NPM if there's something to install.
#
@@ -104,13 +112,7 @@ define NODEJS_INSTALL_MODULES
# npm install call below and setting npm_config_rollback=false can both
# help in diagnosing the problem.
(cd $(TARGET_DIR)/usr/lib && mkdir -p node_modules && \
- $(TARGET_CONFIGURE_OPTS) \
- LD="$(TARGET_CXX)" \
- npm_config_arch=$(NODEJS_CPU) \
- npm_config_target_arch=$(NODEJS_CPU) \
- npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
- $(HOST_DIR)/usr/bin/npm install \
- $(NODEJS_MODULES_LIST) \
+ $(NPM) install $(NODEJS_MODULES_LIST) \
)
# Symlink all executables in $(TARGET_DIR)/usr/lib/node_modules/.bin to
--
2.1.4
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version
2015-06-30 10:42 [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Martin Bark
` (2 preceding siblings ...)
2015-06-30 10:42 ` [Buildroot] [v3 4/4] package/nodejs: Define NPM command for other packages to use Martin Bark
@ 2015-06-30 17:46 ` Yann E. MORIN
2015-06-30 22:20 ` Yann E. MORIN
4 siblings, 0 replies; 11+ messages in thread
From: Yann E. MORIN @ 2015-06-30 17:46 UTC (permalink / raw)
To: buildroot
Martin, all,
On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
> The version of the V8 JavaScript engine used by node.js v0.12.5 requires
> at least an ARMv6 architecture with VFPv2. For this reason v0.10.39
> remains the default for ARMv5 targets, all other targets now default to
> v0.12.5.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[--SNIP--]
> diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
> index bc1f15f..816d602 100644
> --- a/package/nodejs/nodejs.hash
> +++ b/package/nodejs/nodejs.hash
> @@ -1,2 +1,5 @@
> # From upstream URL: http://nodejs.org/dist/v0.10.39/SHASUMS256.txt
> sha256 68f8d8f9515c4e77e2a06034b742e19e9848c1fee5bcadedc1d68f3e4302df37 node-v0.10.39.tar.gz
> +
> +# From upstream URL: http://nodejs.org/dist/v0.12.5/SHASUMS256.txt
> +sha256 4bc1e25f4c62ac65324d3cf4aa9de2d801cd708757c3567b6ad2ced7df30cdd2 node-v0.12.5.tar.gz
Hash manually checked, OK.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150630/fc550419/attachment.asc>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin
2015-06-30 10:42 ` [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin Martin Bark
@ 2015-06-30 17:48 ` Yann E. MORIN
0 siblings, 0 replies; 11+ messages in thread
From: Yann E. MORIN @ 2015-06-30 17:48 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
> This patch symlinks all executables in /usr/lib/node_modules/.bin
> to /usr/bin so that node.js modules installed using
> BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL are accessible from the command line.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Changes v2 -> v3
> - Create symlinks instead of setting PATH (Suggested by Yann E. MORIN)
>
> Changes v1 -> v2
> - Improved commit message
> ---
> package/nodejs/nodejs.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 59e03b0..0b3f8a5 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -111,6 +111,14 @@ define NODEJS_INSTALL_MODULES
> $(HOST_DIR)/usr/bin/npm install \
> $(NODEJS_MODULES_LIST) \
> )
> +
> + # Symlink all executables in $(TARGET_DIR)/usr/lib/node_modules/.bin to
> + # $(TARGET_DIR)/usr/bin so they are accessible from the command line
> + cd $(TARGET_DIR)/usr/bin; \
> + for f in ../../usr/lib/node_modules/.bin/*; do \
> + [ -f "$${f}" -a -x "$${f}" ] || continue; \
> + ln -sf "$${f}" "$${f##*/}" || exit 1; \
> + done
> endef
> endif
>
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [v3 4/4] package/nodejs: Define NPM command for other packages to use
2015-06-30 10:42 ` [Buildroot] [v3 4/4] package/nodejs: Define NPM command for other packages to use Martin Bark
@ 2015-06-30 17:52 ` Yann E. MORIN
0 siblings, 0 replies; 11+ messages in thread
From: Yann E. MORIN @ 2015-06-30 17:52 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
> Other nodejs-related packages will need to call npm with the same set of
> arguments as is currently used by the nodejs package itself.
>
> To avoid duplicating this code, set the NPM variable so those packages can
> re-use it.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> Note: currently, this is only used in the nodejs package itself. I
> plan on sending new nodejs-related packages that will use this, like
> a pm2 (https://github.com/Unitech/pm2) package which I have tested
> successfully using this $(NPM).
>
> Changes v2 -> v3
> - Improved commit message (Suggested by Yann E. MORIN)
>
> Changes v1 -> v2
> - No changes
> ---
> package/nodejs/nodejs.mk | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 78db49d..ea8ec0f5 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -95,6 +95,14 @@ NODEJS_MODULES_LIST= $(call qstrip,\
> $(if $(BR2_PACKAGE_NODEJS_MODULES_COFFEESCRIPT),coffee-script) \
> $(BR2_PACKAGE_NODEJS_MODULES_ADDITIONAL))
>
> +# Define NPM for other packages to use
> +NPM = $(TARGET_CONFIGURE_OPTS) \
> + LD="$(TARGET_CXX)" \
> + npm_config_arch=$(NODEJS_CPU) \
> + npm_config_target_arch=$(NODEJS_CPU) \
> + npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
> + $(HOST_DIR)/usr/bin/npm
> +
> #
> # We can only call NPM if there's something to install.
> #
> @@ -104,13 +112,7 @@ define NODEJS_INSTALL_MODULES
> # npm install call below and setting npm_config_rollback=false can both
> # help in diagnosing the problem.
> (cd $(TARGET_DIR)/usr/lib && mkdir -p node_modules && \
> - $(TARGET_CONFIGURE_OPTS) \
> - LD="$(TARGET_CXX)" \
> - npm_config_arch=$(NODEJS_CPU) \
> - npm_config_target_arch=$(NODEJS_CPU) \
> - npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
> - $(HOST_DIR)/usr/bin/npm install \
> - $(NODEJS_MODULES_LIST) \
> + $(NPM) install $(NODEJS_MODULES_LIST) \
> )
>
> # Symlink all executables in $(TARGET_DIR)/usr/lib/node_modules/.bin to
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command
2015-06-30 10:42 ` [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command Martin Bark
@ 2015-06-30 18:01 ` Yann E. MORIN
2015-06-30 23:32 ` Martin Bark
0 siblings, 1 reply; 11+ messages in thread
From: Yann E. MORIN @ 2015-06-30 18:01 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
> Many packages use node-pre-gpy as a way of deploying precompiled binary
node-pre-gpy or node-pre-gyp ? ;-)
> dependencies with fall back to compilation for other targets. node-gyp
> uses the option --arch to determine its target architecture (which is
> already set correctly), however, node-pre-gyp uses --target-arch. Without
> this set node.js packages that uses node-pre-gyp will pick the wrong target
> architecture.
So if I understand correctly, we can fall in a case where the package
claims to already have a pre-compiled binary for this target-arch, and
install that instead of building it from source, right?
I don't think this is good, for three reasons;
1) there's no way we can ensure it matches the bundled sources;
think malware sneaking into there... :-(
2) it makes complying with the licenses almost impossible (e.g a
module is GPLv2, we install the pre-built binary, we're not sure
the sources we have are the actual sources used to build the binary
we ship)
3) the architecture is not enough: what about optimisation (speed,
size...), the ABI (hardfloat vs. softfloat...) and a lot of other
compilation-related specifities?...
Can we disable this check, and *always* and *unconditionnally* build
from source, even if the module believes it has a pre-compiled binary
for the current target architecture?
Otherwise, I won't review nor ack this patch, I'm not too versed in
NodeJS to fully appreciate the problem and the proposed solution...
Sorry...
Regards,
Yann E. MORIN.
> This patch sets npm_config_target_arch to solve this issue. I have tested
> this using the node.js package serialport.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
>
> ---
> Changes v2 -> v3
> - Adjusted patch order so this is before the new definition of $(NPM)
>
> Changes v1 -> v2
> - No changes, new in v2
> ---
> package/nodejs/nodejs.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 0b3f8a5..78db49d 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -107,6 +107,7 @@ define NODEJS_INSTALL_MODULES
> $(TARGET_CONFIGURE_OPTS) \
> LD="$(TARGET_CXX)" \
> npm_config_arch=$(NODEJS_CPU) \
> + npm_config_target_arch=$(NODEJS_CPU) \
> npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
> $(HOST_DIR)/usr/bin/npm install \
> $(NODEJS_MODULES_LIST) \
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version
2015-06-30 10:42 [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Martin Bark
` (3 preceding siblings ...)
2015-06-30 17:46 ` [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Yann E. MORIN
@ 2015-06-30 22:20 ` Yann E. MORIN
2015-07-02 8:22 ` Martin Bark
4 siblings, 1 reply; 11+ messages in thread
From: Yann E. MORIN @ 2015-06-30 22:20 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
> The version of the V8 JavaScript engine used by node.js v0.12.5 requires
> at least an ARMv6 architecture with VFPv2. For this reason v0.10.39
> remains the default for ARMv5 targets, all other targets now default to
> v0.12.5.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
In fact, I missed something, which Thomas did notice...
[--SNIP--]
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index 9a39385..1e0681b 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -24,18 +24,23 @@ if BR2_PACKAGE_NODEJS
>
> choice
> prompt "Node.js version"
> - default BR2_BR2_PACKAGE_NODEJS_0_10_39
> + default BR2_BR2_PACKAGE_NODEJS_0_10_39 if BR2_ARM_CPU_ARMV5
> + default BR2_BR2_PACKAGE_NODEJS_0_12_5
This is OK and must be kept, however...
> help
> Select the version of Node.js you wish to use.
>
> config BR2_BR2_PACKAGE_NODEJS_0_10_39
> bool "v0.10.39"
>
> +config BR2_BR2_PACKAGE_NODEJS_0_12_5
> + bool "v0.12.5"
... why did you drop the dependency on !BR2_ARM_CPU_ARMV5 here?
My comment about reworking the choice was only about the default of the
choice, to have defaults that are coherent with the dependencies of the
options.
We still need to hide 0.12.5 for armv5.
Note: we put the dependencies after the prompt, like so:
# 0.12.5 uses VP8 which requires armv6 or above
config BR2_BR2_PACKAGE_NODEJS_0_12_5
bool "0.12.5"
depends on !BR2_ARM_CPU_ARMV5
Regards,
Yann E. MORIN.
> endchoice
>
> config BR2_PACKAGE_NODEJS_VERSION_STRING
> string
> default "0.10.39" if BR2_BR2_PACKAGE_NODEJS_0_10_39
> + default "0.12.5" if BR2_BR2_PACKAGE_NODEJS_0_12_5
>
> menu "Module Selection"
>
> diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
> index bc1f15f..816d602 100644
> --- a/package/nodejs/nodejs.hash
> +++ b/package/nodejs/nodejs.hash
> @@ -1,2 +1,5 @@
> # From upstream URL: http://nodejs.org/dist/v0.10.39/SHASUMS256.txt
> sha256 68f8d8f9515c4e77e2a06034b742e19e9848c1fee5bcadedc1d68f3e4302df37 node-v0.10.39.tar.gz
> +
> +# From upstream URL: http://nodejs.org/dist/v0.12.5/SHASUMS256.txt
> +sha256 4bc1e25f4c62ac65324d3cf4aa9de2d801cd708757c3567b6ad2ced7df30cdd2 node-v0.12.5.tar.gz
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command
2015-06-30 18:01 ` Yann E. MORIN
@ 2015-06-30 23:32 ` Martin Bark
0 siblings, 0 replies; 11+ messages in thread
From: Martin Bark @ 2015-06-30 23:32 UTC (permalink / raw)
To: buildroot
Yann,
On 30 June 2015 at 19:01, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Martin, All,
>
> On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
>> Many packages use node-pre-gpy as a way of deploying precompiled binary
>
> node-pre-gpy or node-pre-gyp ? ;-)
>
>> dependencies with fall back to compilation for other targets. node-gyp
>> uses the option --arch to determine its target architecture (which is
>> already set correctly), however, node-pre-gyp uses --target-arch. Without
>> this set node.js packages that uses node-pre-gyp will pick the wrong target
>> architecture.
>
> So if I understand correctly, we can fall in a case where the package
> claims to already have a pre-compiled binary for this target-arch, and
> install that instead of building it from source, right?
>
> I don't think this is good, for three reasons;
>
> 1) there's no way we can ensure it matches the bundled sources;
> think malware sneaking into there... :-(
>
> 2) it makes complying with the licenses almost impossible (e.g a
> module is GPLv2, we install the pre-built binary, we're not sure
> the sources we have are the actual sources used to build the binary
> we ship)
>
> 3) the architecture is not enough: what about optimisation (speed,
> size...), the ABI (hardfloat vs. softfloat...) and a lot of other
> compilation-related specifities?...
I agree, I'm no fan of node-pre-gyp but unfortunately quite a few
packages use it.
Just to be clear, this patch is a bug fix, if does not enable
node-pre-gyp. node-pre-gyp is a node module like any other and some
people have chosen to use it as a dependency in they node module.
Without this fix packages like serialport that use node-pre-gyp will
not build and/or run correctly.
>
> Can we disable this check, and *always* and *unconditionnally* build
> from source, even if the module believes it has a pre-compiled binary
> for the current target architecture?
I think this is a good idea. Looking at node-pre-gyp i can see it has
the option --build-from-source to force building the C++ code. I ran
a quick test and passing npm_config_build_from_source=true into npm
seems to work, the C++ code is built even if the binary version is
available.
I'll run some more tests and submit an updated patch
Thanks
Martin
>
> Otherwise, I won't review nor ack this patch, I'm not too versed in
> NodeJS to fully appreciate the problem and the proposed solution...
> Sorry...
>
> Regards,
> Yann E. MORIN.
>
>> This patch sets npm_config_target_arch to solve this issue. I have tested
>> this using the node.js package serialport.
>>
>> Signed-off-by: Martin Bark <martin@barkynet.com>
>>
>> ---
>> Changes v2 -> v3
>> - Adjusted patch order so this is before the new definition of $(NPM)
>>
>> Changes v1 -> v2
>> - No changes, new in v2
>> ---
>> package/nodejs/nodejs.mk | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
>> index 0b3f8a5..78db49d 100644
>> --- a/package/nodejs/nodejs.mk
>> +++ b/package/nodejs/nodejs.mk
>> @@ -107,6 +107,7 @@ define NODEJS_INSTALL_MODULES
>> $(TARGET_CONFIGURE_OPTS) \
>> LD="$(TARGET_CXX)" \
>> npm_config_arch=$(NODEJS_CPU) \
>> + npm_config_target_arch=$(NODEJS_CPU) \
>> npm_config_nodedir=$(BUILD_DIR)/nodejs-$(NODEJS_VERSION) \
>> $(HOST_DIR)/usr/bin/npm install \
>> $(NODEJS_MODULES_LIST) \
>> --
>> 2.1.4
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version
2015-06-30 22:20 ` Yann E. MORIN
@ 2015-07-02 8:22 ` Martin Bark
0 siblings, 0 replies; 11+ messages in thread
From: Martin Bark @ 2015-07-02 8:22 UTC (permalink / raw)
To: buildroot
Yann, All,
On 30 June 2015 at 23:20, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Martin, All,
>
> On 2015-06-30 11:42 +0100, Martin Bark spake thusly:
>> The version of the V8 JavaScript engine used by node.js v0.12.5 requires
>> at least an ARMv6 architecture with VFPv2. For this reason v0.10.39
>> remains the default for ARMv5 targets, all other targets now default to
>> v0.12.5.
>>
>> Signed-off-by: Martin Bark <martin@barkynet.com>
>
> In fact, I missed something, which Thomas did notice...
>
> [--SNIP--]
>> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
>> index 9a39385..1e0681b 100644
>> --- a/package/nodejs/Config.in
>> +++ b/package/nodejs/Config.in
>> @@ -24,18 +24,23 @@ if BR2_PACKAGE_NODEJS
>>
>> choice
>> prompt "Node.js version"
>> - default BR2_BR2_PACKAGE_NODEJS_0_10_39
>> + default BR2_BR2_PACKAGE_NODEJS_0_10_39 if BR2_ARM_CPU_ARMV5
>> + default BR2_BR2_PACKAGE_NODEJS_0_12_5
>
> This is OK and must be kept, however...
>
>> help
>> Select the version of Node.js you wish to use.
>>
>> config BR2_BR2_PACKAGE_NODEJS_0_10_39
>> bool "v0.10.39"
>>
>> +config BR2_BR2_PACKAGE_NODEJS_0_12_5
>> + bool "v0.12.5"
>
> ... why did you drop the dependency on !BR2_ARM_CPU_ARMV5 here?
>
> My comment about reworking the choice was only about the default of the
> choice, to have defaults that are coherent with the dependencies of the
> options.
>
> We still need to hide 0.12.5 for armv5.
>
> Note: we put the dependencies after the prompt, like so:
>
> # 0.12.5 uses VP8 which requires armv6 or above
> config BR2_BR2_PACKAGE_NODEJS_0_12_5
> bool "0.12.5"
> depends on !BR2_ARM_CPU_ARMV5
Woops, well spotted, my mistake. I'll fix that in a v4 patch set.
Thanks
Martin
>
> Regards,
> Yann E. MORIN.
>
>> endchoice
>>
>> config BR2_PACKAGE_NODEJS_VERSION_STRING
>> string
>> default "0.10.39" if BR2_BR2_PACKAGE_NODEJS_0_10_39
>> + default "0.12.5" if BR2_BR2_PACKAGE_NODEJS_0_12_5
>>
>> menu "Module Selection"
>>
>> diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
>> index bc1f15f..816d602 100644
>> --- a/package/nodejs/nodejs.hash
>> +++ b/package/nodejs/nodejs.hash
>> @@ -1,2 +1,5 @@
>> # From upstream URL: http://nodejs.org/dist/v0.10.39/SHASUMS256.txt
>> sha256 68f8d8f9515c4e77e2a06034b742e19e9848c1fee5bcadedc1d68f3e4302df37 node-v0.10.39.tar.gz
>> +
>> +# From upstream URL: http://nodejs.org/dist/v0.12.5/SHASUMS256.txt
>> +sha256 4bc1e25f4c62ac65324d3cf4aa9de2d801cd708757c3567b6ad2ced7df30cdd2 node-v0.12.5.tar.gz
>> --
>> 2.1.4
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-07-02 8:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-06-30 10:42 [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Martin Bark
2015-06-30 10:42 ` [Buildroot] [v3 2/4] package/nodejs: symlink /usr/lib/node_modules/.bin/* to /usr/bin Martin Bark
2015-06-30 17:48 ` Yann E. MORIN
2015-06-30 10:42 ` [Buildroot] [v3 3/4] package/nodejs: Add npm_config_target_arch to npm command Martin Bark
2015-06-30 18:01 ` Yann E. MORIN
2015-06-30 23:32 ` Martin Bark
2015-06-30 10:42 ` [Buildroot] [v3 4/4] package/nodejs: Define NPM command for other packages to use Martin Bark
2015-06-30 17:52 ` Yann E. MORIN
2015-06-30 17:46 ` [Buildroot] [v3 1/4] package/nodejs: Add node.js v0.12.5 and set as the default version Yann E. MORIN
2015-06-30 22:20 ` Yann E. MORIN
2015-07-02 8:22 ` Martin Bark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox