* [Buildroot] [PATCH] lvm2: disable PIE on ARC
@ 2015-07-01 12:35 Alexey Brodkin
2015-07-02 9:01 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Brodkin @ 2015-07-01 12:35 UTC (permalink / raw)
To: buildroot
Even though ARC gcc understands "-pie" option and attempts to generate
PIE binaries as of today PIE is not really supported for user-space
applications.
So we disable PIE detection if building for ARC.
That first fixes http://autobuild.buildroot.net/results/988/9888a7a30538c9851f4910c16674d8dbb8edeb8f/
and also prevents execution of non-supported PIE binary in runtime.
Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
package/lvm2/lvm2.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index a2db504..6939389 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -43,4 +43,8 @@ else
LVM2_CONF_OPTS += --disable-applib
endif
+ifeq ($(BR2_arc),y)
+LVM2_CONF_ENV += ac_cv_flag_HAVE_PIE=no
+endif
+
$(eval $(autotools-package))
--
2.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] lvm2: disable PIE on ARC
2015-07-01 12:35 [Buildroot] [PATCH] lvm2: disable PIE on ARC Alexey Brodkin
@ 2015-07-02 9:01 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-07-02 9:01 UTC (permalink / raw)
To: buildroot
Dear Alexey Brodkin,
On Wed, 1 Jul 2015 15:35:51 +0300, Alexey Brodkin wrote:
> Even though ARC gcc understands "-pie" option and attempts to generate
> PIE binaries as of today PIE is not really supported for user-space
> applications.
>
> So we disable PIE detection if building for ARC.
> That first fixes http://autobuild.buildroot.net/results/988/9888a7a30538c9851f4910c16674d8dbb8edeb8f/
> and also prevents execution of non-supported PIE binary in runtime.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/lvm2/lvm2.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-02 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-01 12:35 [Buildroot] [PATCH] lvm2: disable PIE on ARC Alexey Brodkin
2015-07-02 9:01 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox