Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/gcc: fix ARC failure to build in 2 phases.
@ 2015-07-02 14:44 Tal Zilcer
  2015-07-02 21:02 ` Yann E. MORIN
  2015-07-02 21:45 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Tal Zilcer @ 2015-07-02 14:44 UTC (permalink / raw)
  To: buildroot

From: Tal Zilcer <talz@ezchip.com>

When working with GCC initial at override source dir mode the
HOST_GCC_INITIAL_POST_PATCH_HOOKS is not called and compilation failes.
The solution is to use HOST_GCC_INITIAL_POST_RSYNC_HOOKS since this hook
is being called at override source dir mode.

Signed-off-by: Tal Zilcer <talz@ezchip.com>
---
 package/gcc/gcc-initial/gcc-initial.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/package/gcc/gcc-initial/gcc-initial.mk b/package/gcc/gcc-initial/gcc-initial.mk
index 0fa2353..6bb7997 100644
--- a/package/gcc/gcc-initial/gcc-initial.mk
+++ b/package/gcc/gcc-initial/gcc-initial.mk
@@ -34,6 +34,7 @@ define HOST_GCC_INITIAL_DISABLE_LIBGMON
 		$(@D)/libgcc/config.host
 endef
 HOST_GCC_INITIAL_POST_PATCH_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
+HOST_GCC_INITIAL_POST_RSYNC_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
 endif
 
 HOST_GCC_INITIAL_CONF_OPTS = \
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/gcc: fix ARC failure to build in 2 phases.
  2015-07-02 14:44 [Buildroot] [PATCH 1/1] package/gcc: fix ARC failure to build in 2 phases Tal Zilcer
@ 2015-07-02 21:02 ` Yann E. MORIN
  2015-07-02 21:45 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-07-02 21:02 UTC (permalink / raw)
  To: buildroot

Tal, All,

On 2015-07-02 17:44 +0300, Tal Zilcer spake thusly:
> From: Tal Zilcer <talz@ezchip.com>
> 
> When working with GCC initial at override source dir mode the
> HOST_GCC_INITIAL_POST_PATCH_HOOKS is not called and compilation failes.
> The solution is to use HOST_GCC_INITIAL_POST_RSYNC_HOOKS since this hook
> is being called at override source dir mode.
> 
> Signed-off-by: Tal Zilcer <talz@ezchip.com>

Based on the feedback from Alexey:
    http://lists.busybox.net/pipermail/buildroot/2015-July/131358.html

a post-rsync hook seems the most appropriate solution short- and
mid-term, so:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/gcc/gcc-initial/gcc-initial.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/package/gcc/gcc-initial/gcc-initial.mk b/package/gcc/gcc-initial/gcc-initial.mk
> index 0fa2353..6bb7997 100644
> --- a/package/gcc/gcc-initial/gcc-initial.mk
> +++ b/package/gcc/gcc-initial/gcc-initial.mk
> @@ -34,6 +34,7 @@ define HOST_GCC_INITIAL_DISABLE_LIBGMON
>  		$(@D)/libgcc/config.host
>  endef
>  HOST_GCC_INITIAL_POST_PATCH_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
> +HOST_GCC_INITIAL_POST_RSYNC_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
>  endif
>  
>  HOST_GCC_INITIAL_CONF_OPTS = \
> -- 
> 1.7.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/gcc: fix ARC failure to build in 2 phases.
  2015-07-02 14:44 [Buildroot] [PATCH 1/1] package/gcc: fix ARC failure to build in 2 phases Tal Zilcer
  2015-07-02 21:02 ` Yann E. MORIN
@ 2015-07-02 21:45 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-02 21:45 UTC (permalink / raw)
  To: buildroot

Dear Tal Zilcer,

On Thu, 2 Jul 2015 17:44:54 +0300, Tal Zilcer wrote:
> From: Tal Zilcer <talz@ezchip.com>
> 
> When working with GCC initial at override source dir mode the
> HOST_GCC_INITIAL_POST_PATCH_HOOKS is not called and compilation failes.
> The solution is to use HOST_GCC_INITIAL_POST_RSYNC_HOOKS since this hook
> is being called at override source dir mode.
> 
> Signed-off-by: Tal Zilcer <talz@ezchip.com>
> ---
>  package/gcc/gcc-initial/gcc-initial.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-02 21:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-02 14:44 [Buildroot] [PATCH 1/1] package/gcc: fix ARC failure to build in 2 phases Tal Zilcer
2015-07-02 21:02 ` Yann E. MORIN
2015-07-02 21:45 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox