Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] ti-wl12xx_target_scripts: new package
@ 2014-08-07 21:10 Jean-Baptiste Theou
  2015-07-12 16:57 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Jean-Baptiste Theou @ 2014-08-07 21:10 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Jean-Baptiste Theou <jtheou@adeneo-embedded.us>
---
 package/Config.in                                      |  1 +
 package/ti-wl12xx_target_scripts/Config.in             |  7 +++++++
 .../ti-wl12xx_target_scripts.mk                        | 18 ++++++++++++++++++
 3 files changed, 26 insertions(+)
 create mode 100644 package/ti-wl12xx_target_scripts/Config.in
 create mode 100644 package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk

diff --git a/package/Config.in b/package/Config.in
index 4520ba6..d5cb827 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -366,6 +366,7 @@ endif
 	source "package/ti-gfx/Config.in"
 	source "package/ti-uim/Config.in"
 	source "package/ti-utils/Config.in"
+	source "package/ti-wl12xx_target_scripts/Config.in"
 	source "package/uboot-tools/Config.in"
 	source "package/udev/Config.in"
 	source "package/udisks/Config.in"
diff --git a/package/ti-wl12xx_target_scripts/Config.in b/package/ti-wl12xx_target_scripts/Config.in
new file mode 100644
index 0000000..0664b3f
--- /dev/null
+++ b/package/ti-wl12xx_target_scripts/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_TI_WL12XX_TARGET_SCRIPTS
+	bool "ti-wl12xx-target-scripts"
+	help
+	  Script for TI wireless solution - WL12xx and WL18xx
+
+	  https://github.com/TI-OpenLink/wl12xx_target_scripts
+
diff --git a/package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk b/package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk
new file mode 100644
index 0000000..5b12032
--- /dev/null
+++ b/package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk
@@ -0,0 +1,18 @@
+################################################################################
+#
+# ti-wl12xx_target_scripts
+#
+################################################################################
+
+TI_WL12XX_TARGET_SCRIPTS_VERSION = 142042970a7827dfd74de2a4c4b91cff57c6b870
+TI_WL12XX_TARGET_SCRIPTS_SITE = $(call github,TI-OpenLink,wl12xx_target_scripts,$(TI_WL12XX_TARGET_SCRIPTS_VERSION))
+TI_WL12XX_TARGET_SCRIPTS_LICENSE = Apache-2.0
+
+define TI_WL12XX_TARGET_SCRIPTS_INSTALL_TARGET_CMDS
+	mkdir -p $(TARGET_DIR)/opt/ti/wl12xx_target_scripts
+	cp -R $(@D)/* \
+		$(TARGET_DIR)/opt/ti/wl12xx_target_scripts
+	chmod +x -R $(TARGET_DIR)/opt/ti/wl12xx_target_scripts
+endef
+
+$(eval $(generic-package))
-- 
2.0.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] ti-wl12xx_target_scripts: new package
  2014-08-07 21:10 [Buildroot] [PATCH 1/1] ti-wl12xx_target_scripts: new package Jean-Baptiste Theou
@ 2015-07-12 16:57 ` Thomas Petazzoni
       [not found]   ` <55A3E37A.4080503@adeneo-embedded.us>
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-12 16:57 UTC (permalink / raw)
  To: buildroot

Dear Jean-Baptiste Theou,

Sorry for the very slow response. We are in the process of triaging a
lot of old patches, so here is some feedback.

On Thu, 7 Aug 2014 14:10:43 -0700, Jean-Baptiste Theou wrote:

> diff --git a/package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk b/package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk
> new file mode 100644
> index 0000000..5b12032
> --- /dev/null
> +++ b/package/ti-wl12xx_target_scripts/ti-wl12xx_target_scripts.mk
> @@ -0,0 +1,18 @@
> +################################################################################
> +#
> +# ti-wl12xx_target_scripts
> +#
> +################################################################################
> +
> +TI_WL12XX_TARGET_SCRIPTS_VERSION = 142042970a7827dfd74de2a4c4b91cff57c6b870
> +TI_WL12XX_TARGET_SCRIPTS_SITE = $(call github,TI-OpenLink,wl12xx_target_scripts,$(TI_WL12XX_TARGET_SCRIPTS_VERSION))

The github page says "Project has moved - Please
use :http://software-dl.ti.com/ecs/WiLink8/latest/index_FDS.html".

> +TI_WL12XX_TARGET_SCRIPTS_LICENSE = Apache-2.0
> +
> +define TI_WL12XX_TARGET_SCRIPTS_INSTALL_TARGET_CMDS
> +	mkdir -p $(TARGET_DIR)/opt/ti/wl12xx_target_scripts
> +	cp -R $(@D)/* \
> +		$(TARGET_DIR)/opt/ti/wl12xx_target_scripts

This should be on one line, the line isn't longer than 80 characters.

> +	chmod +x -R $(TARGET_DIR)/opt/ti/wl12xx_target_scripts

Why do we install in /opt/ti ? It seems like a weird location for
scripts, no?

In the mean time, we've marked your patch as Changes Requested in
patchwork. Please resend an updated version taking into account the
above feedback if you're still interested by this package.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] ti-wl12xx_target_scripts: new package
       [not found]   ` <55A3E37A.4080503@adeneo-embedded.us>
@ 2015-07-13 16:43     ` Thomas Petazzoni
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-13 16:43 UTC (permalink / raw)
  To: buildroot

Dear Jean-Baptiste Theou,

On Mon, 13 Jul 2015 09:12:42 -0700, Jean-Baptiste Theou wrote:

> I am not actively working on this driver, and I don't have the HW to 
> test it properly.
> So please drop this patch.

Thanks for the feedback. We already marked the patch as "Changes
Requested", which means the patch is no longer in the list of pending
patches. So unless someone resends a new version, we will simply not
take care of it anymore.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-13 16:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-07 21:10 [Buildroot] [PATCH 1/1] ti-wl12xx_target_scripts: new package Jean-Baptiste Theou
2015-07-12 16:57 ` Thomas Petazzoni
     [not found]   ` <55A3E37A.4080503@adeneo-embedded.us>
2015-07-13 16:43     ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox