Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] fs/iso9660: change the name of the tmp dir to be consistent
@ 2015-07-13 20:52 Arnout Vandecappelle
  2015-07-13 20:55 ` Yann E. MORIN
  2015-07-13 23:34 ` Thomas Petazzoni
  0 siblings, 2 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2015-07-13 20:52 UTC (permalink / raw)
  To: buildroot

Currently, the generated rootfs will be called rootfs.iso9660, but the
temporary directory we create while building it is called
rootfs-iso9660.tmp. They are in different directories so it's not so
obvious, but still to be consistent it's better to call the temp dir
rootfs.iso9660.tmp.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 fs/iso9660/iso9660.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
index 6ed979c..d836194 100644
--- a/fs/iso9660/iso9660.mk
+++ b/fs/iso9660/iso9660.mk
@@ -35,7 +35,7 @@ ROOTFS_ISO9660_USE_INITRD = YES
 endif
 
 ifeq ($(ROOTFS_ISO9660_USE_INITRD),YES)
-ROOTFS_ISO9660_TARGET_DIR = $(BUILD_DIR)/rootfs-iso9660.tmp
+ROOTFS_ISO9660_TARGET_DIR = $(BUILD_DIR)/rootfs.iso9660.tmp
 define ROOTFS_ISO9660_CREATE_TEMPDIR
 	$(RM) -rf $(ROOTFS_ISO9660_TARGET_DIR)
 	mkdir -p $(ROOTFS_ISO9660_TARGET_DIR)
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] fs/iso9660: change the name of the tmp dir to be consistent
  2015-07-13 20:52 [Buildroot] [PATCH] fs/iso9660: change the name of the tmp dir to be consistent Arnout Vandecappelle
@ 2015-07-13 20:55 ` Yann E. MORIN
  2015-07-13 23:34 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-07-13 20:55 UTC (permalink / raw)
  To: buildroot

Arnout, All,

On 2015-07-13 22:52 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> Currently, the generated rootfs will be called rootfs.iso9660, but the
> temporary directory we create while building it is called
> rootfs-iso9660.tmp. They are in different directories so it's not so
> obvious, but still to be consistent it's better to call the temp dir
> rootfs.iso9660.tmp.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  fs/iso9660/iso9660.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
> index 6ed979c..d836194 100644
> --- a/fs/iso9660/iso9660.mk
> +++ b/fs/iso9660/iso9660.mk
> @@ -35,7 +35,7 @@ ROOTFS_ISO9660_USE_INITRD = YES
>  endif
>  
>  ifeq ($(ROOTFS_ISO9660_USE_INITRD),YES)
> -ROOTFS_ISO9660_TARGET_DIR = $(BUILD_DIR)/rootfs-iso9660.tmp
> +ROOTFS_ISO9660_TARGET_DIR = $(BUILD_DIR)/rootfs.iso9660.tmp
>  define ROOTFS_ISO9660_CREATE_TEMPDIR
>  	$(RM) -rf $(ROOTFS_ISO9660_TARGET_DIR)
>  	mkdir -p $(ROOTFS_ISO9660_TARGET_DIR)
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] fs/iso9660: change the name of the tmp dir to be consistent
  2015-07-13 20:52 [Buildroot] [PATCH] fs/iso9660: change the name of the tmp dir to be consistent Arnout Vandecappelle
  2015-07-13 20:55 ` Yann E. MORIN
@ 2015-07-13 23:34 ` Thomas Petazzoni
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-13 23:34 UTC (permalink / raw)
  To: buildroot

Dear Arnout Vandecappelle (Essensium/Mind),

On Mon, 13 Jul 2015 22:52:28 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> Currently, the generated rootfs will be called rootfs.iso9660, but the
> temporary directory we create while building it is called
> rootfs-iso9660.tmp. They are in different directories so it's not so
> obvious, but still to be consistent it's better to call the temp dir
> rootfs.iso9660.tmp.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  fs/iso9660/iso9660.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-13 23:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 20:52 [Buildroot] [PATCH] fs/iso9660: change the name of the tmp dir to be consistent Arnout Vandecappelle
2015-07-13 20:55 ` Yann E. MORIN
2015-07-13 23:34 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox