Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] inadyn: fix init script and default config file
Date: Tue, 14 Jul 2015 17:19:16 +0200	[thread overview]
Message-ID: <20150714171916.56ef4a3f@free-electrons.com> (raw)
In-Reply-To: <55A51BB2.4090304@zacarias.com.ar>

Gustavo,

On Tue, 14 Jul 2015 11:24:50 -0300, Gustavo Zacarias wrote:
> 
> 
> On 05/07/15 12:12, Thomas Petazzoni wrote:
> 
> >   * Fix the configuration file to use an existing dyndns_system and
> >     avoid a failure at startup.
> 
> You definitely don't want this, if it's not configured and requires 
> configuration for any sane usage let it be so.
> You don't want to do this kind of thing by default:
> https://en.wikipedia.org/wiki/NTP_server_misuse_and_abuse

Hu? What's the relation between NTP server misuse and Inadyn which is a
tool that updates a DynDNS entry with your IP address? Am I missing
something?

> Also trusting that 'background' is in the config doesn't seem foolproof 
> either, dropping it and adding -b to the initscript sounds better to me.

But then if 'background' is in the config file, we will background it
twice. Since inadyn generates its own PID file, it might be OK, but
it's not that nice either.

I think our init scripts are anyway done to work fine with our default
configuration files. If you change the configuration file, you have to
be ready to adjust init scripts as well I'd say, no?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-07-14 15:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-05 15:12 [Buildroot] [PATCH] inadyn: fix init script and default config file Thomas Petazzoni
2015-07-11 10:25 ` Arnout Vandecappelle
2015-07-14 14:24 ` Gustavo Zacarias
2015-07-14 15:19   ` Thomas Petazzoni [this message]
2015-07-14 15:24     ` Gustavo Zacarias
2015-07-14 15:59       ` Thomas Petazzoni
2015-07-14 16:05         ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150714171916.56ef4a3f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox