Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] inadyn: fix init script and default config file
Date: Tue, 14 Jul 2015 13:05:29 -0300	[thread overview]
Message-ID: <55A53349.6040507@zacarias.com.ar> (raw)
In-Reply-To: <20150714175909.30648ed9@free-electrons.com>

On 14/07/15 12:59, Thomas Petazzoni wrote:

> Ah, yes, I see. So maybe we should instead have:
>
> ENABLED="no"
>
> in /etc/default/inadyn
>
> and in the SXXinadyn, if ENABLED=="no", do something like:
>
> Starting inadyn: SKIPPED
>
> or something like that.
>
> Thoughts?

Yes, the initscripts enable/disable logic is pending (my fault probably, 
though i didn't follow the conclusions with detail).

> Ah, you're talking about inadyn -b option, while I was thinking of the
> start-stop-daemon option. Then it definitely makes sense, and I can get
> rid of the background option in the example config file.
>
> Sounds OK?

Yup, it's mostly covering for user omission since it costs nothing.
With the addition of -- -b :)
It also makes the systemd service more resilient, since it normally 
doesn't expect a background (at least via BR default config).
Regards.

      reply	other threads:[~2015-07-14 16:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-05 15:12 [Buildroot] [PATCH] inadyn: fix init script and default config file Thomas Petazzoni
2015-07-11 10:25 ` Arnout Vandecappelle
2015-07-14 14:24 ` Gustavo Zacarias
2015-07-14 15:19   ` Thomas Petazzoni
2015-07-14 15:24     ` Gustavo Zacarias
2015-07-14 15:59       ` Thomas Petazzoni
2015-07-14 16:05         ` Gustavo Zacarias [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A53349.6040507@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox