Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/luajit: disable for static build
@ 2015-07-17 12:46 Jörg Krause
  2015-07-18 19:08 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Jörg Krause @ 2015-07-17 12:46 UTC (permalink / raw)
  To: buildroot

luajit requires dlopen().

Fixes:
http://autobuild.buildroot.net/results/20d/20dfb10198f3688f92208591960192ca08280987/
http://autobuild.buildroot.net/results/c3c/c3cfdf8dfb315bf64caa9ed0f362016111fd93ac/
http://autobuild.buildroot.net/results/8cb/8cbf6207ecf7b254aeccd9ec5c07376a044e1f8f/

Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 package/luajit/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/luajit/Config.in b/package/luajit/Config.in
index f6995e2..8ce528b 100644
--- a/package/luajit/Config.in
+++ b/package/luajit/Config.in
@@ -8,6 +8,7 @@ config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 config BR2_PACKAGE_LUAJIT
 	bool "luajit"
 	select BR2_PACKAGE_HAS_LUAINTERPRETER
+	depends on !BR2_STATIC_LIBS # dlopen
 	# Luajit is only available for some target architectures, and
 	# has some complexity wrt 32/64. See luajit.mk for details.
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
@@ -32,3 +33,6 @@ config BR2_PACKAGE_LUAINTERPRETER_ABI_VERSION
 	default "5.1"
 
 endif
+
+comment "luajit needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/luajit: disable for static build
  2015-07-17 12:46 [Buildroot] [PATCH 1/1] package/luajit: disable for static build Jörg Krause
@ 2015-07-18 19:08 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-07-18 19:08 UTC (permalink / raw)
  To: buildroot

J?rg,

On Fri, 17 Jul 2015 14:46:37 +0200, J?rg Krause wrote:
> luajit requires dlopen().
> 
> Fixes:
> http://autobuild.buildroot.net/results/20d/20dfb10198f3688f92208591960192ca08280987/
> http://autobuild.buildroot.net/results/c3c/c3cfdf8dfb315bf64caa9ed0f362016111fd93ac/
> http://autobuild.buildroot.net/results/8cb/8cbf6207ecf7b254aeccd9ec5c07376a044e1f8f/
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
>  package/luajit/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/luajit/Config.in b/package/luajit/Config.in
> index f6995e2..8ce528b 100644
> --- a/package/luajit/Config.in
> +++ b/package/luajit/Config.in
> @@ -8,6 +8,7 @@ config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
>  config BR2_PACKAGE_LUAJIT
>  	bool "luajit"
>  	select BR2_PACKAGE_HAS_LUAINTERPRETER
> +	depends on !BR2_STATIC_LIBS # dlopen

You forgot to propagate this dependency to the sysdig package, which
selects luajit, so I've done that an applied.

Technically speaking, it is possible to build luajit in
BR2_STATIC_LIBS=y configuration, by setting LJ_TARGET_DLOPEN to 0 in
src/lj_arch.h, but then you cannot load any C module, which makes
LuaJIT maybe a little bit useless. If anyone is interested, they can
always work on making this change.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-18 19:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 12:46 [Buildroot] [PATCH 1/1] package/luajit: disable for static build Jörg Krause
2015-07-18 19:08 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox