[Buildroot] [PATCH v1 1/1] rtl8821au: new package

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Christian Stewart,

On Tue, 14 Jul 2015 16:01:01 -0700, Christian Stewart wrote:

> diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
> index 2e4c205..a99b877 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -189,6 +189,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_RTL_88XX
>  	help
>  	  Realtek rtl8821ae
>  
> +config BR2_PACKAGE_RTL8821AU
> +	bool "Realtek 8821AU"
> +	help
> +	  Realtek rtl8821au kernel module

Why are you putting the option in the middle of
package/linux-firmware/Config.in ? It should be in
package/rtl8821au/Config.in, and this file be included from
package/Config.in.

> diff --git a/package/rtl8821au/rtl8821au.hash b/package/rtl8821au/rtl8821au.hash
> new file mode 100644
> index 0000000..21f47a2
> --- /dev/null
> +++ b/package/rtl8821au/rtl8821au.hash
> @@ -0,0 +1 @@
> +sha256 7ab9aae237ff562d5c40675115ffb9e36a4774490df0a6a8a4c7746dfd567e14  rtl8821au-4.3.14.tar.gz
> diff --git a/package/rtl8821au/rtl8821au.mk b/package/rtl8821au/rtl8821au.mk
> new file mode 100644
> index 0000000..f5f3da6
> --- /dev/null
> +++ b/package/rtl8821au/rtl8821au.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# rtl8821au
> +#
> +################################################################################
> +
> +RTL8821AU_VERSION = 4.3.14
> +RTL8821AU_SITE = $(call github,paralin,rtl8821au,v$(RTL8821AU_VERSION))

This is your repo, but it doesn't seem to be the real upstream for the
project. Can you use https://github.com/ulli-kroll/rtl8821au instead,
which seems much more active ? We can accept having a few patches on
top, as long as their are also submitted upstream.

> +define RTL8821AU_BUILD_CMDS
> +	$(SED) "s/CONFIG_PLATFORM_I386_PC = y/CONFIG_PLATFORM_I386_PC = n/g" -i $(@D)/Makefile
> +	$(MAKE) -C $(@D) ARCH="$(ARCH)" KVER="$(LINUX_VERSION_PROBED)" USER_EXTRA_CFLAGS="-DCONFIG_LITTLE_ENDIAN" CROSS_COMPILE="$(CROSS_COMPILE)" KSRC="$(LINUX_BUILDDIR)" CC="$(TARGET_CC)" LD="$(TARGET_LD)" modules

Hardcoding -DCONFIG_LITTLE_ENDIAN will not work on big endian
architectures. ARCH should probably use KERNEL_ARCH.

> +endef
> +
> +define RTL8821AU_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -p -m 644 $(@D)/8821au.ko $(TARGET_DIR)/lib/modules/$(LINUX_VERSION_PROBED)/kernel/drivers/net/wireless/
> +	$(HOST_DIR)/sbin/depmod -a --basedir=$(TARGET_DIR) $(LINUX_VERSION_PROBED)
> +endef
> +
> +RTL8821AU_DEPENDENCIES = linux linux-firmware

Why do you depend on the linux-firmware package?

> +$(eval $(generic-package))

Can you look at using the kernel-module infrastructure instead, it
should make things a bit easier. If you have issues, don't hesitate to
ask. I've Cc'ed Yann E. Morin, who is the author of the kernel-module
infrastructure. See also
http://nightly.buildroot.org/manual.html#_infrastructure_for_packages_building_kernel_modules
for the official documentation of this package infrastructure.

In the mean time, I'll mark your patch as Changes Requested in our
patch tracking system, so please resubmit an updated version when you
can!

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com