From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 1/1] rtl8821au: new package
Date: Mon, 20 Jul 2015 23:49:34 +0200 [thread overview]
Message-ID: <20150720214934.GA3730@free.fr> (raw)
In-Reply-To: <CA+h8R2rrU9vxJ7KiXpTuZW5S9+w9RZJwfLx_t+04OnYRJYEmiA@mail.gmail.com>
Christian, All,
On 2015-07-20 21:35 +0000, Christian Stewart spake thusly:
> I don't think I will forget about maintaining this because we're using the
> driver here in the lab extensively. Only thing I can forsee happening is
> the vendor releasing another version at some point, but you can always
> email me to update the repo and test with the newer version and I'll get on
> it pretty quickly.
Yeah, as Thomas said, we have no choice in this case, and yuour repo is
as good as any other in this respect. Thanks for doing that work! :-)
> As per the rtl8821au business...
>
> Is this the best way to specify the defines I need in the makefile:
>
> RTL8821AU_MODULE_MAKE_OPTS = KVER="$(LINUX_VERSION_PROBED)"
> ARCH="$(KERNEL_ARCH)"
Well, you can ditch ARCH, it's already passed by the kernel-module infra.
Also, do not quote the version string, so just:
RTL8821AU_MODULE_MAKE_OPTS = KVER=$(LINUX_VERSION_PROBED)
> Also, what's the best way to determine big or little endian? All of the
> arch options have different formats for specifying it.
We do have BR2_ENDIAN that is a string for the endianness, either BIG or
LITTLE.
So I'd say:
ifeq ($(call qstrip,$(BR2_ENDAIN)),BIG)
RTL8821AU_CFLAGS_ENDIAN = -DCONFIG_BIG_ENDIAN
else
RTL8821AU_CFLAGS_ENDIAN = -DCONFIG_LITTLE_ENDIAN
endif
Then use that as:
RTL8821AU_MODULE_MAKE_OPTS = \
KVER=$(LINUX_VERSION_PROBED) \
USER_EXTRA_CFLAGS=$(RTL8821AU_CFLAGS_ENDIAN)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2015-07-20 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 23:01 [Buildroot] [PATCH v1 1/1] rtl8821au: new package Christian Stewart
2015-07-18 21:26 ` Thomas Petazzoni
[not found] ` <CA+h8R2rH2Ne_PUe85wMnEc1a817FVun0m61z+FqCfA3ph5NvMQ@mail.gmail.com>
2015-07-20 21:30 ` Thomas Petazzoni
[not found] ` <CA+h8R2pR_BU7FRm0R8EHKuA7rqgeeRrzBzy1AkvVEuqo04uAwQ@mail.gmail.com>
[not found] ` <20150720233051.6ae1947e@free-electrons.com>
2015-07-20 21:35 ` Christian Stewart
2015-07-20 21:49 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720214934.GA3730@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox