From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] freerdp: Add support for tz package
Date: Tue, 21 Jul 2015 23:28:48 +0200 [thread overview]
Message-ID: <20150721232848.489afa47@free-electrons.com> (raw)
In-Reply-To: <BLU436-SMTP472EF27D5E879E3FFB5134C7840@phx.gbl>
Dear FanChengPing,
Could you fix your setup so that the From: and Signed-off-by: are
matching, and are the same for every patch?
In this current version you posted, the first two patches have:
From: FanChengPing <vancepym@outlook.com>
Signed-off-by: Scott Fan <fancp2007@gmail.com>
(which is not good)
and the last two patches have:
From: Scott Fan <fancp2007@gmail.com>
Signed-off-by: Scott Fan <fancp2007@gmail.com>
which is good.
Also, when posting new version, please add a version number to your
patches, by using:
git format-patch --subject-prefix="PATCH v2"
as well as a changelog between the versions, either in a cover letter
e-mail (--cover argument of git format-patch) or in the individual
patches. See
http://buildroot.org/downloads/manual/manual.html#submitting-patches
for more details.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-07-21 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 1:19 [Buildroot] [PATCH 1/4] freerdp: Add support for tz package FanChengPing
2015-07-21 21:28 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721232848.489afa47@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox