Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/4] freerdp: Add support for tz package
@ 2015-07-21  1:19 FanChengPing
  2015-07-21 21:28 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: FanChengPing @ 2015-07-21  1:19 UTC (permalink / raw)
  To: buildroot

Fixes error message while freerdp connected the remote desktop:
Unable to detect time zone

Signed-off-by: Scott Fan <fancp2007@gmail.com>
---
 .../freerdp/0004-add-support-for-tz-package.patch  | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch

diff --git a/package/freerdp/0004-add-support-for-tz-package.patch b/package/freerdp/0004-add-support-for-tz-package.patch
new file mode 100644
index 0000000..93e4afd
--- /dev/null
+++ b/package/freerdp/0004-add-support-for-tz-package.patch
@@ -0,0 +1,30 @@
+From 605d0a85183d2f9d5b0da5629cbadf01173bbb2f Mon Sep 17 00:00:00 2001
+From: Scott Fan <fancp2007@gmail.com>
+Date: Mon, 13 Jul 2015 15:01:17 +0800
+Subject: [PATCH] Add support for tz package
+
+Fixes error message while freerdp connected the remote desktop:
+Unable to detect time zone
+
+Signed-off-by: Scott Fan <fancp2007@gmail.com>
+---
+ libfreerdp/locale/timezone.c | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/libfreerdp/locale/timezone.c b/libfreerdp/locale/timezone.c
+index 3070f1f..4a06786 100644
+--- a/libfreerdp/locale/timezone.c
++++ b/libfreerdp/locale/timezone.c
+@@ -1539,7 +1539,8 @@ char* freerdp_get_unix_timezone_identifier()
+ 	 * America/Montreal for example.
+ 	 */
+ 	
+-	if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1)
++	if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1 ||
++	    (len = readlink("/etc/TZ", buf, sizeof(buf) - 1)) != -1)
+ 	{
+ 		int num = 0;
+ 		int pos = len;
+-- 
+2.4.5
+
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/4] freerdp: Add support for tz package
  2015-07-21  1:19 [Buildroot] [PATCH 1/4] freerdp: Add support for tz package FanChengPing
@ 2015-07-21 21:28 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2015-07-21 21:28 UTC (permalink / raw)
  To: buildroot

Dear FanChengPing,

Could you fix your setup so that the From: and Signed-off-by: are
matching, and are the same for every patch?

In this current version you posted, the first two patches have:

From: FanChengPing <vancepym@outlook.com>
Signed-off-by: Scott Fan <fancp2007@gmail.com>

(which is not good)

and the last two patches have:

From: Scott Fan <fancp2007@gmail.com>
Signed-off-by: Scott Fan <fancp2007@gmail.com>

which is good.

Also, when posting new version, please add a version number to your
patches, by using:

	git format-patch --subject-prefix="PATCH v2"

as well as a changelog between the versions, either in a cover letter
e-mail (--cover argument of git format-patch) or in the individual
patches. See
http://buildroot.org/downloads/manual/manual.html#submitting-patches
for more details.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-21 21:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-21  1:19 [Buildroot] [PATCH 1/4] freerdp: Add support for tz package FanChengPing
2015-07-21 21:28 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox