* [Buildroot] [PATCH] uclibc: fix static linking of pthread apps for x86/x86_64
@ 2015-07-22 16:13 Waldemar Brodkorb
2015-07-22 20:38 ` Thomas Petazzoni
2015-07-28 8:31 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2015-07-22 16:13 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/182424bd2fea36af95eea31f7dd53f0399433616/
http://autobuild.buildroot.net/results/6b1e2132a34e0c263bb0f2ea31caf4ce697e9c9c/
Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
.../uclibc/1.0.4/0001-fix-static-linking-bug.patch | 64 ++++++++++++++++++++
1 file changed, 64 insertions(+)
create mode 100644 package/uclibc/1.0.4/0001-fix-static-linking-bug.patch
diff --git a/package/uclibc/1.0.4/0001-fix-static-linking-bug.patch b/package/uclibc/1.0.4/0001-fix-static-linking-bug.patch
new file mode 100644
index 0000000..a580a67
--- /dev/null
+++ b/package/uclibc/1.0.4/0001-fix-static-linking-bug.patch
@@ -0,0 +1,64 @@
+From 76513cbe06ec45d6cf0310c00eaf71d3250ed57f Mon Sep 17 00:00:00 2001
+From: Waldemar Brodkorb <wbx@uclibc-ng.org>
+Date: Wed, 22 Jul 2015 14:54:07 +0200
+Subject: [PATCH] fix static builds of pthread apps for x86/x86_64
+
+Found via buildroot autobuilder.
+
+Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
+---
+ libpthread/nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S | 6 ++++++
+ libpthread/nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S | 6 ++++++
+ 2 files changed, 12 insertions(+)
+
+diff --git a/libpthread/nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S b/libpthread/nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S
+index f38703b..ff9a784 100644
+--- a/libpthread/nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S
++++ b/libpthread/nptl/sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S
+@@ -70,6 +70,9 @@
+ .globl __lll_lock_wait_private
+ .type __lll_lock_wait_private, at function
+ .hidden __lll_lock_wait_private
++#ifndef IS_IN_libpthread
++ .weak __lll_lock_wait_private
++#endif
+ .align 16
+ __lll_lock_wait_private:
+ cfi_startproc
+@@ -320,6 +323,9 @@ __lll_timedlock_wait:
+ .globl __lll_unlock_wake_private
+ .type __lll_unlock_wake_private, at function
+ .hidden __lll_unlock_wake_private
++#ifndef IS_IN_libpthread
++ .weak __lll_unlock_wake_private
++#endif
+ .align 16
+ __lll_unlock_wake_private:
+ cfi_startproc
+diff --git a/libpthread/nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S b/libpthread/nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S
+index 50aacea..894c683 100644
+--- a/libpthread/nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S
++++ b/libpthread/nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S
+@@ -75,6 +75,9 @@
+ .globl __lll_lock_wait_private
+ .type __lll_lock_wait_private, at function
+ .hidden __lll_lock_wait_private
++#ifndef IS_IN_libpthread
++ .weak __lll_lock_wait_private
++#endif
+ .align 16
+ __lll_lock_wait_private:
+ cfi_startproc
+@@ -317,6 +320,9 @@ __lll_timedlock_wait:
+ .globl __lll_unlock_wake_private
+ .type __lll_unlock_wake_private, at function
+ .hidden __lll_unlock_wake_private
++#ifndef IS_IN_libpthread
++ .weak __lll_unlock_wake_private
++#endif
+ .align 16
+ __lll_unlock_wake_private:
+ cfi_startproc
+--
+1.7.10.4
+
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] uclibc: fix static linking of pthread apps for x86/x86_64
2015-07-22 16:13 [Buildroot] [PATCH] uclibc: fix static linking of pthread apps for x86/x86_64 Waldemar Brodkorb
@ 2015-07-22 20:38 ` Thomas Petazzoni
2015-07-28 8:31 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-22 20:38 UTC (permalink / raw)
To: buildroot
Dear Waldemar Brodkorb,
On Wed, 22 Jul 2015 18:13:26 +0200, Waldemar Brodkorb wrote:
> Fixes:
> http://autobuild.buildroot.net/results/182424bd2fea36af95eea31f7dd53f0399433616/
> http://autobuild.buildroot.net/results/6b1e2132a34e0c263bb0f2ea31caf4ce697e9c9c/
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> .../uclibc/1.0.4/0001-fix-static-linking-bug.patch | 64 ++++++++++++++++++++
> 1 file changed, 64 insertions(+)
> create mode 100644 package/uclibc/1.0.4/0001-fix-static-linking-bug.patch
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] uclibc: fix static linking of pthread apps for x86/x86_64
2015-07-22 16:13 [Buildroot] [PATCH] uclibc: fix static linking of pthread apps for x86/x86_64 Waldemar Brodkorb
2015-07-22 20:38 ` Thomas Petazzoni
@ 2015-07-28 8:31 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-28 8:31 UTC (permalink / raw)
To: buildroot
Dear Waldemar Brodkorb,
On Wed, 22 Jul 2015 18:13:26 +0200, Waldemar Brodkorb wrote:
> Fixes:
> http://autobuild.buildroot.net/results/182424bd2fea36af95eea31f7dd53f0399433616/
> http://autobuild.buildroot.net/results/6b1e2132a34e0c263bb0f2ea31caf4ce697e9c9c/
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
FWIW, we have the same problem on SuperH:
http://autobuild.buildroot.net/results/755/7559993edf68cc697832d65ab3bd925724861e5e/build-end.log
The toolchain was built with Buildroot at commit 85945aa.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-28 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 16:13 [Buildroot] [PATCH] uclibc: fix static linking of pthread apps for x86/x86_64 Waldemar Brodkorb
2015-07-22 20:38 ` Thomas Petazzoni
2015-07-28 8:31 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox