From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support
Date: Thu, 30 Jul 2015 16:50:52 +0200 [thread overview]
Message-ID: <20150730165052.1eea5a29@free-electrons.com> (raw)
In-Reply-To: <1438267651-16818-1-git-send-email-nrubinstein@aldebaran.com>
Hello,
On Thu, 30 Jul 2015 16:47:30 +0200, No? Rubinstein wrote:
> diff --git a/fs/iso9660/iso9660.mk b/fs/iso9660/iso9660.mk
> index d836194..9100547 100644
> --- a/fs/iso9660/iso9660.mk
> +++ b/fs/iso9660/iso9660.mk
> @@ -146,15 +146,14 @@ endif # ROOTFS_ISO9660_USE_INITRD
> define ROOTFS_ISO9660_CMD
> $(HOST_DIR)/usr/bin/genisoimage -J -R -b $(ROOTFS_ISO9660_BOOT_IMAGE) \
> -no-emul-boot -boot-load-size 4 -boot-info-table \
> - -o $@ $(ROOTFS_ISO9660_TARGET_DIR)
> + -o $@ $(ROOTFS_ISO9660_TARGET_DIR) \
> + $(if $(ROOTFS_ISO9660_GEN_HYBRID), && $(ROOTFS_ISO9660_GEN_HYBRID))
Can you resubmit with the && thing ? It is not needed: make will
abort automatically if genisoimage fails.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-30 14:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 14:47 [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support Noé Rubinstein
2015-07-30 14:47 ` [Buildroot] [PATCH 2/2] fs/iso9660: install Isolinux comboot modules Noé Rubinstein
2015-07-30 21:27 ` Yann E. MORIN
2015-07-30 21:31 ` Thomas Petazzoni
2015-07-30 14:50 ` Thomas Petazzoni [this message]
2015-07-30 14:56 ` [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support Noé Rubinstein
2015-07-30 15:03 ` Thomas Petazzoni
2015-07-30 16:42 ` Noé Rubinstein
2015-07-30 21:19 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730165052.1eea5a29@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox