From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support
Date: Thu, 30 Jul 2015 17:03:52 +0200 [thread overview]
Message-ID: <20150730170352.0331b2c4@free-electrons.com> (raw)
In-Reply-To: <CAOccFZCnm3yrooc7uwiAphQz9SEzFtmMkUwCyv3z6EY_OknRSg@mail.gmail.com>
Dear No? Rubinstein,
On Thu, 30 Jul 2015 16:56:34 +0200, No? Rubinstein wrote:
> On Thu, Jul 30, 2015 at 4:50 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
> > Can you resubmit with the && thing ? It is not needed: make will
> > abort automatically if genisoimage fails.
>
> The issue is syntactic: ROOTFS_ISO9660_CMD is used in this line in common.mk:
>
> echo "$$(ROOTFS_$(2)_CMD)" >> $$(FAKEROOT_SCRIPT)
>
> Therefore it can not contain any newline. This would be fixed by using
> the file function in GNU make
> <https://www.gnu.org/software/make/manual/html_node/File-Function.html>
> but it would not work with GNU make 3.81.
Hum then maybe in the end my _POST_GEN_HOOKS idea is better?
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-07-30 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 14:47 [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support Noé Rubinstein
2015-07-30 14:47 ` [Buildroot] [PATCH 2/2] fs/iso9660: install Isolinux comboot modules Noé Rubinstein
2015-07-30 21:27 ` Yann E. MORIN
2015-07-30 21:31 ` Thomas Petazzoni
2015-07-30 14:50 ` [Buildroot] [PATCH 1/2] fs/iso9660: fix hybrid image support Thomas Petazzoni
2015-07-30 14:56 ` Noé Rubinstein
2015-07-30 15:03 ` Thomas Petazzoni [this message]
2015-07-30 16:42 ` Noé Rubinstein
2015-07-30 21:19 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730170352.0331b2c4@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox