[Buildroot] [PATCH 1/2] libnfs: Without native RPC use libtirpc

[Buildroot] [PATCH 1/2] libnfs: Without native RPC use libtirpc

[Maxime Hadjinlian]

As it's done with nfs-utils, use libtirpc when no native rpc support
exists in the toolchain.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/libnfs/Config.in | 5 +----
 package/libnfs/libnfs.mk | 4 ++++
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/package/libnfs/Config.in b/package/libnfs/Config.in
index 6642fe4..e9b939f 100644
--- a/package/libnfs/Config.in
+++ b/package/libnfs/Config.in
@@ -1,10 +1,7 @@
 config BR2_PACKAGE_LIBNFS
 	bool "libnfs"
-	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
+	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
 	  nfs userspace implementation.
 
 	  http://github.com/sahlberg/libnfs
-
-comment "libnfs needs a toolchain w/ RPC"
-	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
diff --git a/package/libnfs/libnfs.mk b/package/libnfs/libnfs.mk
index 0c8c4f5..fb95e21 100644
--- a/package/libnfs/libnfs.mk
+++ b/package/libnfs/libnfs.mk
@@ -13,4 +13,8 @@ LIBNFS_LICENSE = LGPLv2.1+
 LIBNFS_LICENSE_FILES = LICENCE-LGPL-2.1.txt
 LIBNFS_DEPENDENCIES = host-pkgconf
 
+ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
+LIBNFS_DEPENDENCIES += libtirpc
+endif
+
 $(eval $(autotools-package))
-- 
2.1.4

[Buildroot] [PATCH 2/2] kodi: Without native RPC use libtirpc

[Maxime Hadjinlian]

The previous patch allow to build libnfs without native RPC support by
using libtirpc. Report that dependency here.

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/kodi/Config.in | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 91c1cce..04a9cb4 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -176,14 +176,11 @@ config BR2_PACKAGE_KODI_LIBMICROHTTPD
 
 config BR2_PACKAGE_KODI_LIBNFS
 	bool "nfs"
-	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	select BR2_PACKAGE_LIBNFS
+	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
 	help
 	  Enable NFS server support.
 
-comment "nfs support needs a toolchain w/ RPC support"
-	depends on !BR2_TOOLCHAIN_HAS_NATIVE_RPC
-
 config BR2_PACKAGE_KODI_RTMPDUMP
 	bool "rtmp"
 	select BR2_PACKAGE_RTMPDUMP
-- 
2.1.4

[Buildroot] [PATCH 1/2] libnfs: Without native RPC use libtirpc

[Baruch Siach]

Hi Maxime,

On Sun, Apr 26, 2015 at 02:54:30PM +0200, Maxime Hadjinlian wrote:
> As it's done with nfs-utils, use libtirpc when no native rpc support
> exists in the toolchain.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/libnfs/Config.in | 5 +----
>  package/libnfs/libnfs.mk | 4 ++++
>  2 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/package/libnfs/Config.in b/package/libnfs/Config.in
> index 6642fe4..e9b939f 100644
> --- a/package/libnfs/Config.in
> +++ b/package/libnfs/Config.in
> @@ -1,10 +1,7 @@
>  config BR2_PACKAGE_LIBNFS
>  	bool "libnfs"
> -	depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
> +	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC

What about libtirpc dependencies?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 1/2] libnfs: Without native RPC use libtirpc

[Maxime Hadjinlian]

Hi Baruch

On Sun, Apr 26, 2015 at 2:59 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Maxime,
>
> On Sun, Apr 26, 2015 at 02:54:30PM +0200, Maxime Hadjinlian wrote:
>> As it's done with nfs-utils, use libtirpc when no native rpc support
>> exists in the toolchain.
>>
>> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>> ---
>>  package/libnfs/Config.in | 5 +----
>>  package/libnfs/libnfs.mk | 4 ++++
>>  2 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/package/libnfs/Config.in b/package/libnfs/Config.in
>> index 6642fe4..e9b939f 100644
>> --- a/package/libnfs/Config.in
>> +++ b/package/libnfs/Config.in
>> @@ -1,10 +1,7 @@
>>  config BR2_PACKAGE_LIBNFS
>>       bool "libnfs"
>> -     depends on BR2_TOOLCHAIN_HAS_NATIVE_RPC
>> +     select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
>
> What about libtirpc dependencies?
There's only host-pkgconf, I don't think I have to add it to the
dependency of libnfs, do I ?
>
> baruch
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH 1/2] libnfs: Without native RPC use libtirpc

[Thomas Petazzoni]

Dear Maxime Hadjinlian,

On Sun, 26 Apr 2015 18:13:33 +0200, Maxime Hadjinlian wrote:

> > What about libtirpc dependencies?
> There's only host-pkgconf, I don't think I have to add it to the
> dependency of libnfs, do I ?

Config.in dependencies. From libtirpc/Config.in:

        depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2
        depends on BR2_TOOLCHAIN_HAS_THREADS

They need to be propagated when you select BR2_PACKAGE_LIBTIRPC.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] libnfs: Without native RPC use libtirpc

[Thomas Petazzoni]

Dear Maxime Hadjinlian,

On Sun, 26 Apr 2015 14:54:30 +0200, Maxime Hadjinlian wrote:
> As it's done with nfs-utils, use libtirpc when no native rpc support
> exists in the toolchain.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
>  package/libnfs/Config.in | 5 +----
>  package/libnfs/libnfs.mk | 4 ++++
>  2 files changed, 5 insertions(+), 4 deletions(-)

Both of your patches had comments, but you never addressed them. So
I've marked the two patches as Changes Requested. Please address the
comments and send an updated version. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com