Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/empty - fix build failure
@ 2015-08-04 15:53 Brendan Heading
  2015-08-06 18:59 ` Waldemar Brodkorb
  0 siblings, 1 reply; 3+ messages in thread
From: Brendan Heading @ 2015-08-04 15:53 UTC (permalink / raw)
  To: buildroot

Fixes http://autobuild.buildroot.net/results/e07/e07aec9a839e89b7452b13bf5445164530e27414/

"empty" fails to build if _POSIX_SEMAPHORES is not defined, which is the
case on a toolchain with no threading support.

Signed-off-by: Brendan Heading <brendanheading@gmail.com>
---
 package/empty/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/empty/Config.in b/package/empty/Config.in
index 7fd0877..9a77f8d 100644
--- a/package/empty/Config.in
+++ b/package/empty/Config.in
@@ -1,7 +1,11 @@
 config BR2_PACKAGE_EMPTY
 	bool "empty"
 	depends on BR2_USE_MMU # uses fork()
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  Run processes and applications under pseudo-terminal (PTY) sessions.
 
 	  http://empty.sourceforge.net/
+
+comment "empty needs a toolchain w/ threads"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/empty - fix build failure
  2015-08-04 15:53 [Buildroot] [PATCH 1/1] package/empty - fix build failure Brendan Heading
@ 2015-08-06 18:59 ` Waldemar Brodkorb
  2015-08-06 19:51   ` Brendan Heading
  0 siblings, 1 reply; 3+ messages in thread
From: Waldemar Brodkorb @ 2015-08-06 18:59 UTC (permalink / raw)
  To: buildroot

Hi Brendan,
Brendan Heading wrote,

> Fixes http://autobuild.buildroot.net/results/e07/e07aec9a839e89b7452b13bf5445164530e27414/
> 
> "empty" fails to build if _POSIX_SEMAPHORES is not defined, which is the
> case on a toolchain with no threading support.

Threads are not required for SysV semaphores. I have sent a patch
fixing the build with a toolchain without threads, but I got no
response on that.

http://patchwork.ozlabs.org/patch/493343/

best regards
 Waldemar

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/empty - fix build failure
  2015-08-06 18:59 ` Waldemar Brodkorb
@ 2015-08-06 19:51   ` Brendan Heading
  0 siblings, 0 replies; 3+ messages in thread
From: Brendan Heading @ 2015-08-06 19:51 UTC (permalink / raw)
  To: buildroot

On 6 August 2015 at 19:59, Waldemar Brodkorb <wbx@openadk.org> wrote:

> Threads are not required for SysV semaphores. I have sent a patch
> fixing the build with a toolchain without threads, but I got no
> response on that.
>
> http://patchwork.ozlabs.org/patch/493343/

Agreed, that looks like a much better solution.

Brendan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-06 19:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-04 15:53 [Buildroot] [PATCH 1/1] package/empty - fix build failure Brendan Heading
2015-08-06 18:59 ` Waldemar Brodkorb
2015-08-06 19:51   ` Brendan Heading

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox