Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 7/7 v2] mysql: add mariadb galera cluster variant
Date: Sun, 9 Aug 2015 01:22:42 +0200	[thread overview]
Message-ID: <20150808232242.GC3594@free.fr> (raw)
In-Reply-To: <20150808104308.2438494b@free-electrons.com>

Thomas, Sylvain, All,

On 2015-08-08 10:43 +0200, Thomas Petazzoni spake thusly:
> On Fri, 07 Aug 2015 15:44:58 +0200, Sylvain Raybaud wrote:
> > OK I can make a virtual package, that seems to make sense. However,
> > according to section 17.11.6, it seems that I'll have to patch all
> > packages that depend on mysql, because there is some special magic to
> > add in the depender's Config.in, am I right? Is this the way to go?
> 
> We could do something like jpeg (virtual), libjpeg and jpeg-turbo. This
> way, dependers can continue to do a "select BR2_PACKAGE_MYSQL", and
> there is a "choice" in mysql/Config.in to choose between the original
> MySQL or MariaDB. Of course the original MySQL package will have to be
> renamed to some other name than mysql.
> 
> I think the mechanism where the package depending on the virtual
> package do "depends on BR2_PACKAGE_HAS_<foo>" is very good for cases
> like OpenGL and al. where we have potentially an arbitrary/unlimited
> number of providers.
> 
> But for things like libjpeg/jpeg-turbo or mysql/mariadb, where we know
> the choice will be limited to a few alternatives, it probably makes
> sense to have something like libjpeg.
> 
> I've Cc'ed Yann, to get his opinion on the matter.

Well, I never much liked the way the jpeg package has been done.

I do understand that it makes it just work great for users. However,
that was not the way virtual packages were supposed to work; it's
just a (bad) hack (which in fact predates the actual virtual package
infra, IIRC).

And it's a hack that prevents a br2-external from providing its own
jpeg implementation (e.g. one optimised to make use of a specific SoC
hardware, for example).

Now, the mariadb vs. mysql case might not be so problematic. We don't
much expect a myriad of alternate implementations to just pop-up over
the night, and even less hardware-specific implementations. But who
knows? That's probably what we originally thought about the jpeg case,
and now I see at least one reason why we should not have done it that
way... Maybe some vendors have specially-crafted mysql /forks/ tailored
to specific use-cases (but do we care?)...

So, I'd rather that we just handle virtual packages like is done for the
GL case rather than the jpeg case (which I consider broken...)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-08-08 23:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 16:21 [Buildroot] [PATCH 0/7 v2] Set of patches to add MariaDB galera cluster Sylvain Raybaud
2015-07-09 16:21 ` [Buildroot] [PATCH 1/7 v2] check: new package Sylvain Raybaud
2015-07-10 23:06   ` Yann E. MORIN
2015-07-09 16:21 ` [Buildroot] [PATCH 2/7 v2] libaio: add host variant Sylvain Raybaud
2015-07-10 22:30   ` Yann E. MORIN
2015-07-10 23:01     ` Yann E. MORIN
2015-07-10 23:00   ` Thomas Petazzoni
2015-07-09 16:21 ` [Buildroot] [PATCH 3/7 v2] galera: new package Sylvain Raybaud
2015-07-09 21:29   ` Samuel Martin
2015-07-09 21:53     ` Arnout Vandecappelle
2015-08-21 13:20       ` Sylvain Raybaud
2015-08-21 13:39     ` Sylvain Raybaud
2015-07-09 16:21 ` [Buildroot] [PATCH 4/7 v2] pkg-cmake: add PKG_CONFIG_* variables to help cmake find host packages Sylvain Raybaud
2015-07-10 22:47   ` Samuel Martin
2015-07-09 16:21 ` [Buildroot] [PATCH 5/7 v2] busybox: adjust configuration to add fancy options to the sleep applet Sylvain Raybaud
2015-07-10 22:48   ` Samuel Martin
2015-07-10 22:58   ` Thomas Petazzoni
2015-07-10 23:06     ` Sylvain Raybaud
2015-07-09 16:22 ` [Buildroot] [PATCH 6/7 v2] mysql: move patches into a version-specific subdirectory Sylvain Raybaud
2015-07-09 16:22 ` [Buildroot] [PATCH 7/7 v2] mysql: add mariadb galera cluster variant Sylvain Raybaud
2015-07-09 21:56   ` Samuel Martin
2015-07-10  7:54     ` Thomas Petazzoni
2015-08-07 13:44       ` Sylvain Raybaud
2015-08-08  8:43         ` Thomas Petazzoni
2015-08-08 23:22           ` Yann E. MORIN [this message]
2015-08-09  8:46             ` Thomas Petazzoni
2015-08-09 12:59               ` Yann E. MORIN
2015-08-22 22:21             ` Arnout Vandecappelle
2015-08-24 10:14               ` Sylvain Raybaud
2015-08-20 12:05           ` Sylvain Raybaud
2015-08-20 12:32             ` Thomas Petazzoni
2015-08-21  8:23     ` Sylvain Raybaud
2015-08-26 21:45     ` Sylvain Raybaud
2015-10-08 15:15     ` Sylvain Raybaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150808232242.GC3594@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox