[Buildroot] [PATCH 1/1] package/libpfm4: disable Werror

[Buildroot] [PATCH 1/1] package/libpfm4: disable Werror

[Jörg Krause]

Set `DBG` to an empty value to disable -Werror when building libpfm4. Build
aborts with a musl toolchain because of warnings about redirecting incorrect
header includes.

So -Werror shouldn't be used in released code since it can cause random build
failures on moderate warnings. It also depends on the used toolchain since
different toolchains may or may not print the same warnings.

Fixes:
http://autobuild.buildroot.net/results/6df/6df9b94a79be1dc5ba878f7b67bf9ad4ce2f2e98/

Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
---
 package/libpfm4/libpfm4.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/libpfm4/libpfm4.mk b/package/libpfm4/libpfm4.mk
index e2fff80..7f14758 100644
--- a/package/libpfm4/libpfm4.mk
+++ b/package/libpfm4/libpfm4.mk
@@ -13,7 +13,8 @@ LIBPFM4_INSTALL_STAGING = YES
 
 LIBPFM4_FLAGS = SYS=Linux ARCH=$(BR2_ARCH) \
 	CC="$(TARGET_CC)" LDCONFIG=true \
-	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y)
+	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y) \
+	DBG=
 
 define LIBPFM4_BUILD_CMDS
 	$(MAKE) -C $(@D) $(LIBPFM4_FLAGS)
-- 
2.5.0

[Buildroot] [PATCH 1/1] package/libpfm4: disable Werror

[Yann E. MORIN]

J?rg, All,

On 2015-08-13 22:16 +0200, J?rg Krause spake thusly:
> Set `DBG` to an empty value to disable -Werror when building libpfm4. Build
> aborts with a musl toolchain because of warnings about redirecting incorrect
> header includes.
> 
> So -Werror shouldn't be used in released code since it can cause random build
> failures on moderate warnings. It also depends on the used toolchain since
> different toolchains may or may not print the same warnings.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6df/6df9b94a79be1dc5ba878f7b67bf9ad4ce2f2e98/
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[yann.morin.1998 at free.fr: build-tested only]
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/libpfm4/libpfm4.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libpfm4/libpfm4.mk b/package/libpfm4/libpfm4.mk
> index e2fff80..7f14758 100644
> --- a/package/libpfm4/libpfm4.mk
> +++ b/package/libpfm4/libpfm4.mk
> @@ -13,7 +13,8 @@ LIBPFM4_INSTALL_STAGING = YES
>  
>  LIBPFM4_FLAGS = SYS=Linux ARCH=$(BR2_ARCH) \
>  	CC="$(TARGET_CC)" LDCONFIG=true \
> -	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y)
> +	CONFIG_PFMLIB_SHARED=$(if $(BR2_STATIC_LIBS),n,y) \
> +	DBG=
>  
>  define LIBPFM4_BUILD_CMDS
>  	$(MAKE) -C $(@D) $(LIBPFM4_FLAGS)
> -- 
> 2.5.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/libpfm4: disable Werror

[Thomas Petazzoni]

Dear J?rg Krause,

On Thu, 13 Aug 2015 22:16:38 +0200, J?rg Krause wrote:
> Set `DBG` to an empty value to disable -Werror when building libpfm4. Build
> aborts with a musl toolchain because of warnings about redirecting incorrect
> header includes.
> 
> So -Werror shouldn't be used in released code since it can cause random build
> failures on moderate warnings. It also depends on the used toolchain since
> different toolchains may or may not print the same warnings.
> 
> Fixes:
> http://autobuild.buildroot.net/results/6df/6df9b94a79be1dc5ba878f7b67bf9ad4ce2f2e98/
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
>  package/libpfm4/libpfm4.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com