* [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking
@ 2015-08-16 21:46 Yann E. MORIN
2015-08-17 20:29 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2015-08-16 21:46 UTC (permalink / raw)
To: buildroot
When getext is enabled, popt links with -lintl, specifies it in its
popt.pc and has done so for the past 6+ years. But oprofile does not
use pkconfig to find popt, so misses -lintl, which is important for
a static build. We have to do the call to pkgconfig manually...
Fixes:
http://autobuild.buildroot.org/results/a48/a485f2171a3fcbfa2e0e5aec8e653cf88512615d/
http://autobuild.buildroot.org/results/b37/b374874f1915ab1d7aa6262604ccc8db102bb0b0/
http://autobuild.buildroot.org/results/261/2616a63081ed8c55c7ca1a6879b1a6a14e19f918/
http://autobuild.buildroot.org/results/73f/73f34ab59d54ded68ff60608a0212a6e5a5190e5/
...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Baruch Siach <baruch@tkos.co.il>
---
Change v2 -> v3:
- don't make the call to pkgconfig contional (Baruch)
- fix comment appropriately
Changes v1 -> v2:
- use PKG_CONFIG_HOST_BINARY to find popt libs (Baruch)
---
package/oprofile/oprofile.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/oprofile/oprofile.mk b/package/oprofile/oprofile.mk
index 5876307..ba36640 100644
--- a/package/oprofile/oprofile.mk
+++ b/package/oprofile/oprofile.mk
@@ -41,6 +41,12 @@ ifeq ($(BR2_PACKAGE_LIBPFM4),y)
OPROFILE_DEPENDENCIES += libpfm4
endif
+# When getext is enabled, popt links with -lintl, specifies it in its
+# popt.pc and has done so for the past 6+ years. But oprofile does not
+# use pkconfig to find popt, so misses -lintl, which is important for
+# a static build. We have to do the call to pkgconfig manually...
+OPROFILE_CONF_ENV += LIBS="`$(PKG_CONFIG_HOST_BINARY) --libs popt`"
+
define OPROFILE_INSTALL_TARGET_CMDS
$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/bin
$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/share/oprofile
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking
2015-08-16 21:46 [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking Yann E. MORIN
@ 2015-08-17 20:29 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2015-08-17 20:29 UTC (permalink / raw)
To: buildroot
Dear Yann E. MORIN,
On Sun, 16 Aug 2015 23:46:38 +0200, Yann E. MORIN wrote:
> When getext is enabled, popt links with -lintl, specifies it in its
> popt.pc and has done so for the past 6+ years. But oprofile does not
> use pkconfig to find popt, so misses -lintl, which is important for
> a static build. We have to do the call to pkgconfig manually...
>
> Fixes:
> http://autobuild.buildroot.org/results/a48/a485f2171a3fcbfa2e0e5aec8e653cf88512615d/
> http://autobuild.buildroot.org/results/b37/b374874f1915ab1d7aa6262604ccc8db102bb0b0/
> http://autobuild.buildroot.org/results/261/2616a63081ed8c55c7ca1a6879b1a6a14e19f918/
> http://autobuild.buildroot.org/results/73f/73f34ab59d54ded68ff60608a0212a6e5a5190e5/
> ...
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Baruch Siach <baruch@tkos.co.il>
>
> ---
> Change v2 -> v3:
> - don't make the call to pkgconfig contional (Baruch)
> - fix comment appropriately
Applied, thanks. Interestingly, oprofile's configure.ac checks for
pkg-config, but does not seem to use it...
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking
@ 2015-08-16 13:37 Yann E. MORIN
2015-08-16 13:43 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2015-08-16 13:37 UTC (permalink / raw)
To: buildroot
oprofile links with popt, which links with -lintl and specifies it in
its popt.pc, and has done so for the past 6+ years, but oprofile does
not use pkconfig to find popt, so we need to tell it to link with -lintl
for a static build.
Fixes:
http://autobuild.buildroot.org/results/a48/a485f2171a3fcbfa2e0e5aec8e653cf88512615d/
http://autobuild.buildroot.org/results/b37/b374874f1915ab1d7aa6262604ccc8db102bb0b0/
http://autobuild.buildroot.org/results/261/2616a63081ed8c55c7ca1a6879b1a6a14e19f918/
http://autobuild.buildroot.org/results/73f/73f34ab59d54ded68ff60608a0212a6e5a5190e5/
...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
package/oprofile/oprofile.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/oprofile/oprofile.mk b/package/oprofile/oprofile.mk
index 5876307..3a5f807 100644
--- a/package/oprofile/oprofile.mk
+++ b/package/oprofile/oprofile.mk
@@ -41,6 +41,13 @@ ifeq ($(BR2_PACKAGE_LIBPFM4),y)
OPROFILE_DEPENDENCIES += libpfm4
endif
+# popt links with -lintl and specifies it in its popt.pc, and has done
+# so for the past 6+ years, but oprofile does not use pkconfig to find
+# popt, so we need to tell it to link with -lintl for a static build.
+ifeq ($(BR2_PACKAGE_GETTEXT)$(BR2_STATIC_LIBS),yy)
+OPROFILE_CONF_OPTS += LIBS=-lintl
+endif
+
define OPROFILE_INSTALL_TARGET_CMDS
$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/bin
$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/share/oprofile
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking
2015-08-16 13:37 Yann E. MORIN
@ 2015-08-16 13:43 ` Baruch Siach
2015-08-16 14:51 ` Yann E. MORIN
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2015-08-16 13:43 UTC (permalink / raw)
To: buildroot
Hi Yann,
On Sun, Aug 16, 2015 at 03:37:29PM +0200, Yann E. MORIN wrote:
> +# popt links with -lintl and specifies it in its popt.pc, and has done
> +# so for the past 6+ years, but oprofile does not use pkconfig to find
> +# popt, so we need to tell it to link with -lintl for a static build.
> +ifeq ($(BR2_PACKAGE_GETTEXT)$(BR2_STATIC_LIBS),yy)
> +OPROFILE_CONF_OPTS += LIBS=-lintl
> +endif
Why not run $(PKG_CONFIG_HOST_BINARY) directly like we do in
package/logrotate/logrotate.mk for popt?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking
2015-08-16 13:43 ` Baruch Siach
@ 2015-08-16 14:51 ` Yann E. MORIN
0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2015-08-16 14:51 UTC (permalink / raw)
To: buildroot
Baruch, All,
On 2015-08-16 16:43 +0300, Baruch Siach spake thusly:
> On Sun, Aug 16, 2015 at 03:37:29PM +0200, Yann E. MORIN wrote:
> > +# popt links with -lintl and specifies it in its popt.pc, and has done
> > +# so for the past 6+ years, but oprofile does not use pkconfig to find
> > +# popt, so we need to tell it to link with -lintl for a static build.
> > +ifeq ($(BR2_PACKAGE_GETTEXT)$(BR2_STATIC_LIBS),yy)
> > +OPROFILE_CONF_OPTS += LIBS=-lintl
> > +endif
>
> Why not run $(PKG_CONFIG_HOST_BINARY) directly like we do in
> package/logrotate/logrotate.mk for popt?
Good idea, I'll do. Thanks! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-08-17 20:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-16 21:46 [Buildroot] [PATCH] [autobuild] package/oprofile: fix static linking Yann E. MORIN
2015-08-17 20:29 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2015-08-16 13:37 Yann E. MORIN
2015-08-16 13:43 ` Baruch Siach
2015-08-16 14:51 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox