From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [autobuild] package/nbd: fix static builds
Date: Tue, 18 Aug 2015 11:32:30 +0200 [thread overview]
Message-ID: <20150818093230.GA3799@free.fr> (raw)
In-Reply-To: <20150818111826.16620df1@free-electrons.com>
Thomas, All,
On 2015-08-18 11:18 +0200, Thomas Petazzoni spake thusly:
> On Thu, 13 Aug 2015 21:55:31 +0200, Yann E. MORIN wrote:
> > +rename err() function to avoid clashing with err() form C library
> > +
> > +err() is a function available in the C library, so when static linking,
> > +there is a clash at link timebecause the function is provided both by
> > +nbd and the C library:
> > + http://autobuild.buildroot.org/results/aa8/aa8a1ac35a93e1c8b9fddbc2b5d66ecaa921f31e/build-end.log
> > +
> > +Fix that by renaming err() to nbd_err() and providing a small maco
> > +wrapper to avoid touching the many call sites.
> > +
> > +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > +
> > +---
> > +Upstream status: hack, not submitted.
>
> Please submit the patch upstream anyway, so that upstream is aware of
> the problem, and hopefully implements a proper solution.
I'm doing a proper patch for upstream, that does the rename globally,
and that's what I'm gonna submit.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-08-18 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 19:55 [Buildroot] [PATCH] [autobuild] package/nbd: fix static builds Yann E. MORIN
2015-08-18 9:18 ` Thomas Petazzoni
2015-08-18 9:32 ` Yann E. MORIN [this message]
2015-08-18 9:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818093230.GA3799@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox