From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] [autobuild] package/nbd: fix static builds
Date: Tue, 18 Aug 2015 11:18:26 +0200 [thread overview]
Message-ID: <20150818111826.16620df1@free-electrons.com> (raw)
In-Reply-To: <1439495731-8645-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Thu, 13 Aug 2015 21:55:31 +0200, Yann E. MORIN wrote:
> Fixes:
> http://autobuild.buildroot.org/results/aa8/aa8a1ac35a93e1c8b9fddbc2b5d66ecaa921f31e/ (arm)
> http://autobuild.buildroot.org/results/e5b/e5bd05623dd6c57bb0338592ecd21a5ba0cbe95a/ (arc)
> http://autobuild.buildroot.org/results/e0f/e0fd23eec2dd31bece122d84515b2b7cb14594b8/ (ppc)
> http://autobuild.buildroot.org/results/3a2/3a2d4124f78d4e504e8e961fabe038e570923408/ (mips)
> ...
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> package/nbd/0001-avoid-name-clashing.patch | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
> create mode 100644 package/nbd/0001-avoid-name-clashing.patch
>
> diff --git a/package/nbd/0001-avoid-name-clashing.patch b/package/nbd/0001-avoid-name-clashing.patch
> new file mode 100644
> index 0000000..b3ea9c9
> --- /dev/null
> +++ b/package/nbd/0001-avoid-name-clashing.patch
> @@ -0,0 +1,28 @@
> +rename err() function to avoid clashing with err() form C library
> +
> +err() is a function available in the C library, so when static linking,
> +there is a clash at link timebecause the function is provided both by
> +nbd and the C library:
> + http://autobuild.buildroot.org/results/aa8/aa8a1ac35a93e1c8b9fddbc2b5d66ecaa921f31e/build-end.log
> +
> +Fix that by renaming err() to nbd_err() and providing a small maco
> +wrapper to avoid touching the many call sites.
> +
> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> +
> +---
> +Upstream status: hack, not submitted.
Please submit the patch upstream anyway, so that upstream is aware of
the problem, and hopefully implements a proper solution.
I've applied your patch to master, thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-08-18 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 19:55 [Buildroot] [PATCH] [autobuild] package/nbd: fix static builds Yann E. MORIN
2015-08-18 9:18 ` Thomas Petazzoni [this message]
2015-08-18 9:32 ` Yann E. MORIN
2015-08-18 9:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818111826.16620df1@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox