* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
@ 2015-08-13 10:50 Anthony Viallard
2015-08-13 10:52 ` Baruch Siach
2015-08-13 11:04 ` Viallard Anthony
0 siblings, 2 replies; 7+ messages in thread
From: Anthony Viallard @ 2015-08-13 10:50 UTC (permalink / raw)
To: buildroot
Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
---
package/msmtp/msmtp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/msmtp/msmtp.mk b/package/msmtp/msmtp.mk
index bff2620..7c8261e 100644
--- a/package/msmtp/msmtp.mk
+++ b/package/msmtp/msmtp.mk
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
MSMTP_DEPENDENCIES = host-pkgconf
MSMTP_CONF_OPTS = \
--without-libidn \
+ --disable-gai-idn \
--without-libgsasl
MSMTP_LICENSE = GPLv3+
MSMTP_LICENSE_FILES = COPYING
--
2.4.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
2015-08-13 10:50 Anthony Viallard
@ 2015-08-13 10:52 ` Baruch Siach
2015-08-13 11:04 ` Viallard Anthony
1 sibling, 0 replies; 7+ messages in thread
From: Baruch Siach @ 2015-08-13 10:52 UTC (permalink / raw)
To: buildroot
Hi Anthony,
On Thu, Aug 13, 2015 at 12:50:11PM +0200, Anthony Viallard wrote:
> Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
> ---
> package/msmtp/msmtp.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/msmtp/msmtp.mk b/package/msmtp/msmtp.mk
> index bff2620..7c8261e 100644
> --- a/package/msmtp/msmtp.mk
> +++ b/package/msmtp/msmtp.mk
> @@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
> MSMTP_DEPENDENCIES = host-pkgconf
> MSMTP_CONF_OPTS = \
> --without-libidn \
> + --disable-gai-idn \
Please explain why in the commit log. Does it break at build time, run time,
something else?
> --without-libgsasl
> MSMTP_LICENSE = GPLv3+
> MSMTP_LICENSE_FILES = COPYING
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
2015-08-13 10:50 Anthony Viallard
2015-08-13 10:52 ` Baruch Siach
@ 2015-08-13 11:04 ` Viallard Anthony
2015-08-13 11:22 ` Baruch Siach
1 sibling, 1 reply; 7+ messages in thread
From: Viallard Anthony @ 2015-08-13 11:04 UTC (permalink / raw)
To: buildroot
On 08/13/2015 12:50 PM, Anthony Viallard wrote:
> Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
> ---
> package/msmtp/msmtp.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/msmtp/msmtp.mk b/package/msmtp/msmtp.mk
> index bff2620..7c8261e 100644
> --- a/package/msmtp/msmtp.mk
> +++ b/package/msmtp/msmtp.mk
> @@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
> MSMTP_DEPENDENCIES = host-pkgconf
> MSMTP_CONF_OPTS = \
> --without-libidn \
> + --disable-gai-idn \
> --without-libgsasl
> MSMTP_LICENSE = GPLv3+
> MSMTP_LICENSE_FILES = COPYING
>
Hi buildroot guys,
I don't known if there is a consensus about IDN usage for buildroot. I
didn't see an option in the config about it. I presume IDN should be
disabled for all package, am I right ?
autoconf can't see if AI_IDN is really supported
(http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.
Before I did the above patch, msmtp failed to send mail. The output was:
msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags
Regards,
Anthony.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
2015-08-13 11:04 ` Viallard Anthony
@ 2015-08-13 11:22 ` Baruch Siach
0 siblings, 0 replies; 7+ messages in thread
From: Baruch Siach @ 2015-08-13 11:22 UTC (permalink / raw)
To: buildroot
Hi Anthony,
On Thu, Aug 13, 2015 at 01:04:17PM +0200, Viallard Anthony wrote:
> On 08/13/2015 12:50 PM, Anthony Viallard wrote:
> >Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
> >---
> > package/msmtp/msmtp.mk | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/package/msmtp/msmtp.mk b/package/msmtp/msmtp.mk
> >index bff2620..7c8261e 100644
> >--- a/package/msmtp/msmtp.mk
> >+++ b/package/msmtp/msmtp.mk
> >@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
> > MSMTP_DEPENDENCIES = host-pkgconf
> > MSMTP_CONF_OPTS = \
> > --without-libidn \
> >+ --disable-gai-idn \
> > --without-libgsasl
> > MSMTP_LICENSE = GPLv3+
> > MSMTP_LICENSE_FILES = COPYING
>
> I don't known if there is a consensus about IDN usage for buildroot. I
> didn't see an option in the config about it. I presume IDN should be
> disabled for all package, am I right ?
>
> autoconf can't see if AI_IDN is really supported (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
> It seems weird but this is the case apparently.
>
> Before I did the above patch, msmtp failed to send mail. The output was:
>
> msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags
Excellent. Please add that to the commit log. If someone later feels the need
for IDN, that person should come up with a solution.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
@ 2015-08-13 12:36 Anthony Viallard
2015-08-18 10:54 ` Baruch Siach
2015-08-18 12:18 ` Thomas Petazzoni
0 siblings, 2 replies; 7+ messages in thread
From: Anthony Viallard @ 2015-08-13 12:36 UTC (permalink / raw)
To: buildroot
I don't known if there is a consensus about IDN usage for buildroot. I
didn't see an option in the config about it. I presume IDN should be
disabled for all package, am I right ?
autoconf can't see if AI_IDN is really supported (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
It seems weird but this is the case apparently.
Before I did the above patch, msmtp failed to send mail. The output was:
msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags
Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
---
package/msmtp/msmtp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/msmtp/msmtp.mk b/package/msmtp/msmtp.mk
index bff2620..7c8261e 100644
--- a/package/msmtp/msmtp.mk
+++ b/package/msmtp/msmtp.mk
@@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
MSMTP_DEPENDENCIES = host-pkgconf
MSMTP_CONF_OPTS = \
--without-libidn \
+ --disable-gai-idn \
--without-libgsasl
MSMTP_LICENSE = GPLv3+
MSMTP_LICENSE_FILES = COPYING
--
2.4.6
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
2015-08-13 12:36 [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature Anthony Viallard
@ 2015-08-18 10:54 ` Baruch Siach
2015-08-18 12:18 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Baruch Siach @ 2015-08-18 10:54 UTC (permalink / raw)
To: buildroot
Hi Anthony,
On Thu, Aug 13, 2015 at 02:36:01PM +0200, Anthony Viallard wrote:
> I don't known if there is a consensus about IDN usage for buildroot. I
> didn't see an option in the config about it. I presume IDN should be
> disabled for all package, am I right ?
This part should not appear in the commit log. The rest looks OK to me.
> autoconf can't see if AI_IDN is really supported
> (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
> It seems weird but this is the case apparently.
>
> Before I did the above patch, msmtp failed to send mail. The output was:
>
> msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags
> Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
The convention is to have an empty line just above the sign-off line.
> ---
> package/msmtp/msmtp.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/msmtp/msmtp.mk b/package/msmtp/msmtp.mk
> index bff2620..7c8261e 100644
> --- a/package/msmtp/msmtp.mk
> +++ b/package/msmtp/msmtp.mk
> @@ -10,6 +10,7 @@ MSMTP_SOURCE = msmtp-$(MSMTP_VERSION).tar.xz
> MSMTP_DEPENDENCIES = host-pkgconf
> MSMTP_CONF_OPTS = \
> --without-libidn \
> + --disable-gai-idn \
> --without-libgsasl
> MSMTP_LICENSE = GPLv3+
> MSMTP_LICENSE_FILES = COPYING
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature
2015-08-13 12:36 [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature Anthony Viallard
2015-08-18 10:54 ` Baruch Siach
@ 2015-08-18 12:18 ` Thomas Petazzoni
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2015-08-18 12:18 UTC (permalink / raw)
To: buildroot
Dear Anthony Viallard,
On Thu, 13 Aug 2015 14:36:01 +0200, Anthony Viallard wrote:
> I don't known if there is a consensus about IDN usage for buildroot. I
> didn't see an option in the config about it. I presume IDN should be
> disabled for all package, am I right ?
>
> autoconf can't see if AI_IDN is really supported (http://sourceforge.net/p/msmtp/code/ci/907916e8089ea9303a7c091b763087530c88a063/).
> It seems weird but this is the case apparently.
>
> Before I did the above patch, msmtp failed to send mail. The output was:
>
> msmtp: cannot locate host smtp.mandrillapp.com: Bad value for ai_flags
> Signed-off-by: Anthony Viallard <viallard@syscom-instruments.com>
> ---
> package/msmtp/msmtp.mk | 1 +
> 1 file changed, 1 insertion(+)
Applied after tweaking the commit log. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-08-18 12:18 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-13 12:36 [Buildroot] [PATCH 1/1] msmtp: don't try to use IDN feature Anthony Viallard
2015-08-18 10:54 ` Baruch Siach
2015-08-18 12:18 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2015-08-13 10:50 Anthony Viallard
2015-08-13 10:52 ` Baruch Siach
2015-08-13 11:04 ` Viallard Anthony
2015-08-13 11:22 ` Baruch Siach
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox